fix(react-icons): allow React 18 in peerDependencies #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Nov 24, 2022
| @@ -52,7 +52,7 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "@griffel/react": "^1.0.0", | |||
| "react": ">=16.8.0 <=18.0.0" | |||
| "react": ">=16.8.0 <19.0.0" | |||
There was a problem hiding this comment.
Allows React 18, the same as in @fluentui/react-components, https://github.com/microsoft/fluentui/blob/8fcefaeacac2e2cc2cd7ca5b76c1ca5e7e547682/packages/react-components/react-components/package.json#L80.
layershifter
force-pushed
the
fix/allow-react18
branch
from
c632e08
to
fb96ce3
Compare
layershifter
commented
Nov 24, 2022
| @@ -51,8 +51,7 @@ | |||
| "tslib": "^2.1.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "@griffel/react": "^1.0.0", | |||
There was a problem hiding this comment.
@griffel/react is gone as it's also in regular dependencies (see line 50).
|
@tomi-msft can you please take a look? |
tomi-msft
approved these changes
Nov 27, 2022
|
@tomi-msft Thanks for the merge, encountered the same issue so happy with this fix. Any idea when we can expect a new release which includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #517.
See title 馃憜