Bundleicon fix (#523)

* Automate bumping react-icons beta version number * revert * remove manifest.json * Release 1.1.179 * revert * fix:update bundleIcon utility to handle props properly Co-authored-by: Fluent Build System <flubuild@microsoft.com>
microsoft · Nov 14, 2022 · 028f3c8 · 028f3c8
1 parent 8ed4829
commit 028f3c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react-icons/package.json b/packages/react-icons/package.json
@@ -52,7 +52,7 @@
   },
   "peerDependencies": {
     "@griffel/react": "^1.0.0",
-    "react": ">=16.8.0 <18.0.0"
+    "react": ">=16.8.0 <=18.0.0"
   },
   "files": [
     "lib/",

diff --git a/packages/react-icons/src/utils/bundleIcon.tsx b/packages/react-icons/src/utils/bundleIcon.tsx
@@ -10,12 +10,12 @@ const useBundledIconStyles = makeStyles({
 
 const bundleIcon = (FilledIcon: React.FC<FluentIconsProps>, RegularIcon: React.FC<FluentIconsProps>) => {
     const Component: React.FC<FluentIconsProps> = (props) => {
-        const { className, primaryFill = 'currentColor', filled } = props;
+        const { className, primaryFill = 'currentColor', filled, ...rest } = props;
         const styles = useBundledIconStyles();
         return (
             <React.Fragment>
                 <FilledIcon
-                    {...props}
+                    {...rest}
                     className={mergeClasses(
                         styles.root,
                         filled && styles.visible,
@@ -25,7 +25,7 @@ const bundleIcon = (FilledIcon: React.FC<FluentIconsProps>, RegularIcon: React.F
                     fill={primaryFill}
                 />
                 <RegularIcon
-                    {...props}
+                    {...rest}
                     className={mergeClasses(
                       styles.root,
                       !filled && styles.visible,