This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
refactor(customPropTypes): remove usage of _.chain #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
May 27, 2019
| xdescribe('is conformant', () => { | ||
| isConformant(Box) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
This file does nothing, let's remove dead code.
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1399 +/- ##
==========================================
- Coverage 73.47% 73.45% -0.02%
==========================================
Files 778 778
Lines 5859 5859
Branches 1726 1726
==========================================
- Hits 4305 4304 -1
- Misses 1548 1549 +1
Partials 6 6
Continue to review full report at Codecov.
|
bmdalex
approved these changes
May 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picked from #1169.
This PR removes the usage of Lodash's
_.chain():https://medium.com/making-internets/why-using-chain-is-a-mistake-9bc1f80d51ba
The main problem: with
_.chain()you will include the whole Lodash and you will not be able to pick single modules.babel-plugin-lodashwill also stuck in this case.