This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(package): use Project References in TS #1387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 24, 2019
layershifter
changed the title
Chore/ts references
chore(package): use Project References in TS
May 27, 2019
Changed dependencies are detected.Changed dependencies in
Perf comparison
Generated by 🚫 dangerJS |
layershifter
force-pushed
the
chore/ts-references
branch
from
May 27, 2019 14:27
26edf79
to
fe7b8b3
Compare
…om/stardust-ui/react into chore/ts-references � Conflicts: � build/gulp/tasks/bundle.ts � gulpfile.ts
layershifter
requested review from
dvdzkwsk,
dzearing,
ecraig12345,
JasonGore,
jdhuntington,
kenotron,
levithomason,
miroslavstastny and
mnajdova
as code owners
January 10, 2020 16:16
mnajdova
approved these changes
Jan 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #508.
This PR introduces changes to our
tsconfig.json
's to use Project References feature. It was designed also to handle monorepo cases (microsoft/TypeScript#25376).https://www.typescriptlang.org/docs/handbook/project-references.html
Generated types structure
This feature allows to properly define
rootDir
option intsconfig.json
and output proper typings by compiler:Without references feature it will fail because TypeScript doesn't know anything about modules structure: