Enable source link in nuget packages #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was disabled in #262, but instead of been disabled only for OSx it was never set to be true at first place, so it was off for all platforms. Regarding OSx it looks like bug was fixed somewhere around 2019 (dotnet/sourcelink#288)
brendankowitz
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was disabled in #262, but instead of been disabled only for OSx it was never set to be true at first place, so it was off for all platforms.
Regarding OSx it looks like bug was fixed somewhere around 2019 (dotnet/sourcelink#288)
Related issues
Addresses [#1674 ].
Testing
in progress
FHIR Team Checklist
Semver Change (docs)
Patch (to regenerate nuget with right information)