Adds support for EDDSA signatures #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution @mz2. Please make sure that the spec tests pass. |
ajaykn
suggested changes
May 27, 2020
| @@ -409,12 +409,13 @@ def self.update_release(api_token, owner_name, app_name, release_id, release_not | |||
| end | |||
|
|
|||
| # updates release metadata | |||
| def self.update_release_metadata(api_token, owner_name, app_name, release_id, dsa_signature) | |||
| def self.update_release_metadata(api_token, owner_name, app_name, release_id, dsa_signature, eddsa_signature) | |||
| return if dsa_signature.to_s == '' | |||
There was a problem hiding this comment.
I think, this condition needs to be updated with eddsa_signature as well.
|
@mz2 if you are still interested in getting this PR merged, please consider the above comments. |
|
Closing as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for EDDSA signing Sparkle builds.