Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz testing of execution context #896

Merged
merged 16 commits into from
Apr 7, 2022
Merged

Conversation

Alan-Jowett
Copy link
Member

@Alan-Jowett Alan-Jowett commented Apr 5, 2022

Signed-off-by: Alan Jowett alanjo@microsoft.com

Description

Add a test pass that fuzzes the EBPF execution context.

Testing

CI/CD

Documentation

N/A

Address part of #620

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #896 (fea6019) into main (54516ec) will increase coverage by 0.57%.
The diff coverage is 83.65%.

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
+ Coverage   80.23%   80.80%   +0.57%     
==========================================
  Files          84       85       +1     
  Lines       14791    14887      +96     
  Branches      488      488              
==========================================
+ Hits        11867    12030     +163     
+ Misses       2633     2566      -67     
  Partials      291      291              
Impacted Files Coverage Δ
libs/execution_context/ebpf_native.c 67.16% <ø> (+4.03%) ⬆️
libs/platform/ebpf_platform.h 100.00% <ø> (ø)
libs/platform/user/ebpf_platform_user.cpp 78.72% <ø> (ø)
libs/execution_context/ebpf_core.c 87.60% <66.66%> (+4.46%) ⬆️
tests/fuzz/execution_context.cpp 83.52% <83.52%> (ø)
libs/platform/ebpf_object.c 95.59% <100.00%> (+1.25%) ⬆️
libs/platform/user/ebpf_handle_user.c 76.71% <100.00%> (ø)
tests/end_to_end/test_helper.cpp 84.64% <100.00%> (+0.12%) ⬆️
libs/api/ebpf_api.cpp 76.76% <0.00%> (+0.11%) ⬆️
libs/execution_context/ebpf_program.c 77.16% <0.00%> (+0.35%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54516ec...fea6019. Read the comment docs.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR description to reference issue #620. You might also want to explain the relationship to issue #709

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
tests/fuzz/execution_context.cpp Outdated Show resolved Hide resolved
tests/fuzz/execution_context.cpp Outdated Show resolved Hide resolved
tests/fuzz/execution_context.cpp Outdated Show resolved Hide resolved
tests/fuzz/execution_context.cpp Show resolved Hide resolved
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
dthaler
dthaler previously approved these changes Apr 5, 2022
Copy link
Collaborator

@dthaler dthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, though I updated the PR description to say it only addresses part, not all, of 620, and updated 620 with a bulleted list of which this PR addresses the first one.

shankarseal
shankarseal previously approved these changes Apr 7, 2022
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@dthaler dthaler merged commit 59716df into microsoft:main Apr 7, 2022
@Alan-Jowett Alan-Jowett deleted the fuzzing branch April 7, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants