Fixes for kernel mode multi-threaded test #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dv-msft
force-pushed
the
3453-km-mt-stress-fix
branch
from
4237fab
to
e224583
Compare
dv-msft
changed the title
dv-msft
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
reviewed
May 26, 2024
dv-msft
force-pushed
the
3453-km-mt-stress-fix
branch
from
e224583
to
32298d5
Compare
dthaler
approved these changes
May 28, 2024
Alan-Jowett
reviewed
May 28, 2024
| if (test_control_info.use_unique_native_programs && context_entry.role == thread_role_type::CREATOR) { | ||
|
|
||
| // Create unique native programs for 'creator' threads only. | ||
| _make_unique_file_copy(program_attribs.native_file_name, (compartment_id - 1)); | ||
| context_entry.is_native_program = true; | ||
| context_entry.file_name = |
There was a problem hiding this comment.
Some reason why you aren't using the std::filesytem classes for paths etc?
Alan-Jowett
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes bugs in the existing kernel-mode multi-threaded stress test. Specifically:
Testing
Tested locally and via CI/CD runs on a private self-hosted runner.
Documentation
No doc changes.
Installation
No installer impact.
Fixes #3453