Cache choco packages to work around connectivity issues #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
added 3 commits
May 10, 2024 15:56
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
dthaler
reviewed
May 11, 2024
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
dthaler
approved these changes
May 13, 2024
dv-msft
approved these changes
May 21, 2024
shankarseal
pushed a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Jun 3, 2024
* Cache choco packages to work around connectivity issues Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Download file as cache key if needed Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Skip choco if gather_dumps is false Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> * Apply suggestions from code review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> --------- Signed-off-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Alan Jowett <alan.jowett@microsoft.com> Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
.github/workflows/reusable-test.ymlfile, specifically in thejobs:section. The changes involve setting up a local cache for Chocolatey (choco) packages and adding a cache entry for any installed choco packages. The cache key is based on the hash of the workflow file, so any changes to the choco packages in the file will invalidate the cache.Key changes:
.github/workflows/reusable-test.yml: Added a new step to create a local folder for caching Chocolatey packages. The cache location is set using thechoco config setcommand. This step is skipped if theshould_skipoutput of theskip_checkstep is 'true'..github/workflows/reusable-test.yml: Added another step to cache the Chocolatey packages. The cache uses theactions/cacheaction with a specific commit hash. The cache key is generated using thehashFilesfunction with the workflow file as input. This step is also skipped if theshould_skipoutput of theskip_checkstep is 'true'.Testing
CI/CD
Documentation
No.
Installation
No.