Update scorecard workflow to latest #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we tried this before in PR microsoft#1161 and had to revert it in PR microsoft#1174 but the issue it was blocked on seems to be fixed and this should fix the various scorecard failures we are now seeing. MsQuic which originally did the same as we did already snapped to latest as can be seen at https://github.com/microsoft/msquic/blob/main/.github/workflows/scorecards-analysis.yml and its scorecard runs are passing. Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler
requested review from
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft,
delaramamiri and
gtrevi
as code owners
Alan-Jowett
approved these changes
Apr 26, 2023
shpalani
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that we tried this before in PR #1161 and had to revert it in PR #1174 but the issue it was blocked on seems to be fixed and this should fix the various scorecard failures we are now seeing.
MsQuic which originally did the same as we did already snapped to latest as can be seen at
https://github.com/microsoft/msquic/blob/main/.github/workflows/scorecards-analysis.yml and its scorecard runs are passing.
Testing
Match msquic config which is passing.
Similarly, l3afd was hitting the same scorecard failures we are, and l3af-project/l3afd#230 makes this same fix and scorecards pass with it.
Documentation
No impact.