This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
chore: update with upstream changes for 2.x #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix for handling braces in path * fix entry parts checking * fix braces test * fix braces test * fix paths in test for windows
Includes a test case that reproduces the issue without the fix.
Attempt to get tests passing with updated deps
Update Travis & AppVeyor to allow node 0.10 failures
Update badges/changelog
Fixes paulmillr#668 Chokidar@2 includes anymatch@2 which has a (potentially) breaking change as described in the changelog: https://github.com/micromatch/anymatch#change-log When the `cwd` is set Chokidar will join the ignore pattern to the cwd, and if this isn't absolute, it causes `anymatch` to fail: ```js // where cwd = c:\Users\remy\ anymatch('C:\\Users\\remy\\**\\node_modules\\**', 'C:\\Users\\remy\\node_modules\\project'); // === false ``` https://runkit.com/embed/rn05fobk294p So this change adds the upath module (used by Chokidar during testing and about 35K footprint) to normalize the path to bash-like slashes which corrects the issue.
Fix windows ignore when using anymatch@2 & cwd option
Fix uncaught exception "Cannot read property 'lastChange' of undefined".
Changed to current url
Update README.md
Accept upath minor and security patches
Unlink and re-add fails when multiple paths are passed
This also fixes an issue that using fd = 0 is not closed in case Windows is used and a `EPERM` error is triggered.
* Add dtslint and @types/node Adding dtslint to test (lint) the type definitions and @types/node since they're a depedency of these types * Assert the types are valid in CI * Create the tsconfig for validating types * Port (copy/paste) existing types from DefinitelyTyped * Add the types key and include in the package
* A better workaround for atomic writes. * Adding comments.
This reverts commit 8f56261.
…obs with subfolders (paulmillr#818) * fix paulmillr#806: Chokidar doesn't let process exit when watching globs with subfolders * fix paulmillr#806: Chokidar doesn't let process exit when watching globs with subfolders
deepak1556
force-pushed
the
fsevents_node12_compat
branch
from
d88d19c
to
9d2fb2d
Compare
bpasero
suggested changes
Jul 2, 2019
index.js
Outdated
| @@ -3,11 +3,14 @@ var EventEmitter = require('events').EventEmitter; | |||
| var fs = require('fs'); | |||
| var sysPath = require('path'); | |||
| var asyncEach = require('async-each'); | |||
| var anymatch = require('vscode-anymatch'); | |||
| var anymatch = require('anymatch'); | |||
There was a problem hiding this comment.
@deepak1556 please take note that vscode-anymatch was added specifically to fix microsoft/vscode#57263. We need to also bring anymatch to latest it seems and see if the change is still needed that I did.
package.json
Outdated
| ], | ||
| "dependencies": { | ||
| "anymatch": "^2.0.0", |
deepak1556
force-pushed
the
fsevents_node12_compat
branch
from
c98d1a9
to
42800a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to pull in fsevents@1.2.9 safely that provides node 12 compatibility fsevents/fsevents#274. Might help in transitioning to official chokidar@3 as a follow up and drop this fork.
Required for https://github.com/microsoft/vscode/tree/electron-6.0.x