Skip to content

port: add speach middleware to runtime #3435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2021
Merged

port: add speach middleware to runtime #3435

merged 3 commits into from
Mar 25, 2021
+240 −2

Conversation

joshgummersall
Copy link
Contributor

Fixes #3432

@joshgummersall joshgummersall requested review from stevengum and a team as code owners March 24, 2021 21:18
@joshgummersall joshgummersall force-pushed the jpg/speech-middleware branch from 2a872a0 to ed93196 Compare March 24, 2021 21:25
tracyboehrer
tracyboehrer approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@tracyboehrer tracyboehrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on JS-happy-things, but I can attest that the middleware does the same thing as the DotNet version.

port: add speak middleware to runtime

Unverified

No user is associated with the committer email.
Learn about vigilant mode
3104214 
Fixes #3432
@joshgummersall joshgummersall force-pushed the jpg/speech-middleware branch from ed93196 to 3104214 Compare March 24, 2021 23:16
stevengum
stevengum reviewed Mar 24, 2021
View reviewed changes
@coveralls
Copy link

coveralls commented Mar 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 684801694

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 84.99%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 60.47%
Totals Coverage Status
Change from base Build 684494096: -0.04%
Covered Lines: 18812
Relevant Lines: 21075
💛 - Coveralls

Josh Gummersall added 2 commits March 24, 2021 16:41
fix: add telephony to channels, remove console

Unverified

No user is associated with the committer email.
Learn about vigilant mode
c7a493c
fix: coerce to strings

Unverified

No user is associated with the committer email.
Learn about vigilant mode
25c537f
@stevengum stevengum merged commit a9003e5 into main Mar 25, 2021
@stevengum stevengum deleted the jpg/speech-middleware branch March 25, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer

@stevengum stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Added SetSpeakMiddleware to Runtime (#5343)
4 participants
@joshgummersall @coveralls @tracyboehrer @stevengum