Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around coveralls parallel upload issue #9635

Merged
merged 4 commits into from Mar 16, 2020

Conversation

Charles-Gagnon
Copy link
Contributor

This is an attempt to work around an issue with coveralls where push CI builds don't seem to handle parallel uploads correctly.

lemurheavy/coveralls-public#1403 seems to be the same/a similar type of issue

So instead of using parallel upload I'm just having it merge all the files together before doing the upload.

@github-actions
Copy link

Coverage Status

Coverage remained the same at 29.892% when pulling c91e971 on chgagnon/coverallsFix into 64eb406 on master.

@aaomidi
Copy link
Contributor

aaomidi commented Mar 16, 2020

Go for it! This seems like it'd be a good solution. If not we can write a quick utility to merge them!

@aaomidi aaomidi mentioned this pull request Mar 16, 2020
@Charles-Gagnon Charles-Gagnon merged commit 0ad40c1 into master Mar 16, 2020
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/coverallsFix branch March 16, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants