Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAzureDacpacDeploymentV1: Quote user supplied strings #19754

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Frankkkkk
Copy link

Task name: SqlAzureDacpacDeploymentV1

Description: Quote user supplied strings to remove ambiguity
Documentation changes required: N

Added unit tests: N
Attached related issue: N
Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
Signed-off-by: Frank Villaro-Dixon <frank.villarodixon@merkle.com>
@v-mohithgc
Copy link
Contributor

Hi @Frankkkkk , thanks for contributing.
In order to procced with approvals and to merge this PR, it is necessary to build and test these changes.
So for that, follow the below simple instructions. Build, test and commit changes to this branch. I will check with relevant task owners to approve this.

Local task test
Have code changes ready (checkout to this branch), navigate to task root path ie >C:...\azure-pipelines-tasks
Note: tfx build works only on node 8 and 10, so make sure to use node 8/10 while testing the task

Step 1: run "npm i"

Step 2: Build:

node make.js build --task SqlAzureDacpacDeploymentV1

Step 3: Install tfx:

npm install -g tfx-cli

Step 4: Login:

tfx login
Service URL : [your task test org url]
PAT :

Step 5: Upload:

tfx build tasks upload --task-path C:\AzurePipelineTask\azure-pipelines-tasks \ _build\Tasks\SqlAzureDacpacDeploymentV1

New task version will be uploaded to your org, please test the changes by running the pipeline.

Step 6: Delete: // optional and can be done after all the testing is completed.

tfx build tasks delete --task-id { }

@Frankkkkk
Copy link
Author

Works fine, thanks!

@Frankkkkk
Copy link
Author

Hi @v-mohithgc any news before I rebase please ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants