-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command for uploading Android mappings #594
Add command for uploading Android mappings #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments which are largely advisory. I may take a deeper look at the tests still, but in concept LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor note about the README.md text for future reference. Lovely tests. I've only cast my eye briefly over this as it already has 2 approves and is merged :)
@@ -72,6 +72,7 @@ Below is the list of commands currently supported by Visual Studio App Center CL | |||
| | | | |||
| `appcenter crashes upload-missing-symbols` | Upload missing crash symbols for the application (only from macOS) | | |||
| `appcenter crashes upload-symbols` | Upload the crash symbols for the application | | |||
| `appcenter crashes upload-mappings` | Upload Android mapping files for the application | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is semi-automatically updated as part of the release process - you don't need to change it on the feature PRs :)
Adds the
crashes upload-mappings
command with argumentsUploadSymbolsBeginRequest
model and generified the upload symbols helper functionality to remove references to only uploading zip files as symbol artifacts