Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for uploading Android mappings #594

Merged

Conversation

matthiaswenz
Copy link
Contributor

Adds the crashes upload-mappings command with arguments

--mapping|-m -> for the mapping file name
--version-name|-n -> for the version name (marketing version i.e. "1.0")
--version-code|-c -> for the version code (build number, i.e. "1")
  1. All three arguments are required. The version name and version code are required in App Center Diagnostics to associate the mappings with the right published app version
  2. Android ProGuard mappings are directly uploaded as a mapping.txt file
  3. Internally changed the upload of symbols to use the generated UploadSymbolsBeginRequest model and generified the upload symbols helper functionality to remove references to only uploading zip files as symbol artifacts

@matthiaswenz matthiaswenz self-assigned this Jun 7, 2019
@matthiaswenz matthiaswenz added the Crashes Crashes CLI label Jun 7, 2019
Copy link

@bry-guy bry-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments which are largely advisory. I may take a deeper look at the tests still, but in concept LGTM :)

src/commands/crashes/upload-mappings.ts Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Outdated Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Outdated Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Outdated Show resolved Hide resolved
src/commands/crashes/upload-mappings.ts Outdated Show resolved Hide resolved
@matthiaswenz matthiaswenz merged commit d9e4938 into microsoft:master Jun 10, 2019
Copy link
Member

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor note about the README.md text for future reference. Lovely tests. I've only cast my eye briefly over this as it already has 2 approves and is merged :)

@@ -72,6 +72,7 @@ Below is the list of commands currently supported by Visual Studio App Center CL
| | |
| `appcenter crashes upload-missing-symbols` | Upload missing crash symbols for the application (only from macOS) |
| `appcenter crashes upload-symbols` | Upload the crash symbols for the application |
| `appcenter crashes upload-mappings` | Upload Android mapping files for the application |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is semi-automatically updated as part of the release process - you don't need to change it on the feature PRs :)

@owenniblock owenniblock mentioned this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crashes Crashes CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants