Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace uglifyjs with terser for minifying prod builds #1061

Merged
merged 1 commit into from Aug 13, 2019

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Aug 13, 2019

Description of changes

Replaces the minifier we're using on prod builds from uglify-js to terser.

Terser is a more updated replacement for UglifyJS. Webpack 4 switched to using it as the default minifier in Nov 2018 (webpack/webpack#8392). The reasons we'd want to switch:

  • Unblocks future updates to typescript output target; uglify only supports up to ES5 javascript, Terser supports more recent javascript as input
  • Closer to the "normal" webpack happy path
  • As of recently, more widely used (with webpack)

It is essentially a drop in replacement; we expect no customer-visible changes as a result of this update.

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • [n/a] Added relevant unit test for your changes. (yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team August 13, 2019 18:50
@dbjorge dbjorge merged commit de1cf60 into microsoft:master Aug 13, 2019
@dbjorge dbjorge deleted the replace-uglify-with-terser branch August 13, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants