Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added null handling in scanner.ts #2015

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashwinGokhale
Copy link

@ashwinGokhale ashwinGokhale commented Feb 20, 2024

Details

Null pointer exception when reading the scan results:

##[error][Exception]ErrorWithCause: An error occurred while scanning website page http://localhost:9009/
at Logger.trackExceptionAny (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:189664:29)
at Scanner. (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190823:29)
at Generator.next ()
at fulfilled (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190741:58)
caused by: TypeError: Cannot read property 'baseUrl' of undefined
at Scanner.getCombinedReportParameters (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190837:60)
at Scanner. (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190815:55)
at Generator.next ()
at fulfilled (/__w/_tasks/accessibility-insights_4811a442-2fd3-5aa8-ba1a-14cb7e24c113/2.0.6/index.js:190741:58)
Accessibility scanning of URL http://localhost:9009/ completed

Motivation

Addresses #2014

Context

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)

@ashwinGokhale ashwinGokhale requested a review from a team as a code owner February 20, 2024 21:42
@v-viyada
Copy link
Contributor

Thanks for submitting PR. We are interested in review this PR but we cannot take this immediately due to some other pending priority issues. We will take this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants