fix(58399): [isolatedDeclarations][5.5] Autofix does not work when JSX prop contains a dash #58478

a-tarasyuk · 2024-05-08T19:57:15Z

…sed by missing parent nodes

src/services/codefixes/fixMissingTypeAnnotationOnExports.ts

jakebailey · 2024-05-08T21:08:15Z

typescript-bot · 2024-05-08T21:08:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

jakebailey

Assuming perf is fine, LGTM. Doubt it will say anything; the function very clearly says:

/**
 * Creates a deep, memberwise clone of a node with no source map location.
 *
 * WARNING: This is an expensive operation and is only intended to be used in refactorings
 * and code fixes (because those are triggered by explicit user actions).
 *
 * @internal
 */
export function getSynthesizedDeepClone<T extends Node | undefined>(node: T, includeTrivia = true): T {

typescript-bot · 2024-05-08T21:44:09Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,500k (± 0.98%)}	_{192,874k (± 0.75%)}	_~	_192,131k	_195,798k	_{p=0.936 n=6}
_{Parse Time}	_{1.54s (± 1.42%)}	_{1.56s (± 0.96%)}	_~	_1.54s	_1.58s	_{p=0.060 n=6}
_{Bind Time}	_{0.87s (± 0.86%)}	_{0.86s (± 0.60%)}	_~	_0.86s	_0.87s	_{p=0.069 n=6}
_{Check Time}	_{11.28s (± 0.50%)}	_{11.28s (± 0.30%)}	_~	_11.22s	_11.32s	_{p=0.936 n=6}
_{Emit Time}	_{3.17s (± 0.79%)}	_{3.18s (± 0.69%)}	_~	_3.16s	_3.22s	_{p=0.625 n=6}
_{Total Time}	_{16.86s (± 0.47%)}	_{16.89s (± 0.27%)}	_~	_16.83s	_16.96s	_{p=0.336 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,141	_407,141	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,993k (± 0.00%)}	_{1,221,958k (± 0.00%)}	_~	_1,221,875k	_1,221,998k	_{p=0.471 n=6}
_{Parse Time}	_{8.09s (± 0.47%)}	_{8.09s (± 0.68%)}	_~	_8.03s	_8.17s	_{p=1.000 n=6}
_{Bind Time}	_{2.25s (± 0.67%)}	_{2.23s (± 0.75%)}	_~	_2.22s	_2.26s	_{p=0.131 n=6}
_{Check Time}	_{36.38s (± 0.55%)}	_{36.46s (± 0.62%)}	_~	_36.15s	_36.79s	_{p=0.575 n=6}
_{Emit Time}	_{17.55s (± 0.65%)}	_{17.51s (± 0.32%)}	_~	_17.45s	_17.61s	_{p=0.574 n=6}
_{Total Time}	_{64.27s (± 0.39%)}	_{64.29s (± 0.37%)}	_~	_63.94s	_64.65s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,956,528	_1,956,528	_~	_~	_~	_{p=1.000 n=6}
_Types	_676,220	_676,220	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,765,439k (± 0.00%)}	_{1,765,448k (± 0.00%)}	_~	_1,765,376k	_1,765,556k	_{p=0.689 n=6}
_{Parse Time}	_{7.97s (± 0.52%)}	_{7.96s (± 0.32%)}	_~	_7.92s	_7.98s	_{p=0.375 n=6}
_{Bind Time}	_{2.74s (± 0.68%)}	_{2.74s (± 0.60%)}	_~	_2.72s	_2.76s	_{p=0.934 n=6}
_{Check Time}	_{66.45s (± 0.34%)}	_{66.71s (± 0.15%)}	_{+0.25s (+ 0.38%)}	_66.59s	_66.89s	_{p=0.045 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 2.52%)}	_~	_0.16s	_0.17s	_{p=0.595 n=6}
_{Total Time}	_{77.33s (± 0.25%)}	_{77.57s (± 0.10%)}	_{+0.24s (+ 0.31%)}	_77.49s	_77.70s	_{p=0.037 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,218,923	_1,218,925	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,674	_258,677	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,334,044k (± 0.04%)}	_{2,332,493k (± 0.05%)}	_{-1,552k (- 0.07%)}	_2,331,591k	_2,334,486k	_{p=0.045 n=6}
_{Parse Time}	_{7.42s (± 0.79%)}	_{7.44s (± 1.30%)}	_~	_7.32s	_7.58s	_{p=1.000 n=6}
_{Bind Time}	_{2.75s (± 1.10%)}	_{2.75s (± 1.07%)}	_~	_2.71s	_2.79s	_{p=1.000 n=6}
_{Check Time}	_{48.80s (± 0.57%)}	_{48.85s (± 0.49%)}	_~	_48.62s	_49.25s	_{p=0.936 n=6}
_{Emit Time}	_{3.88s (± 1.86%)}	_{3.98s (± 2.97%)}	_~	_3.81s	_4.14s	_{p=0.128 n=6}
_{Total Time}	_{62.86s (± 0.49%)}	_{63.01s (± 0.53%)}	_~	_62.49s	_63.46s	_{p=0.298 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,218,923	_1,218,925	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_258,674	_258,677	_{+3 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,525,663k (±11.34%)}	_{2,408,637k (± 0.03%)}	_~	_2,407,695k	_2,409,690k	_{p=0.810 n=6}
_{Parse Time}	_{7.75s (± 1.04%)}	_{7.77s (± 0.82%)}	_~	_7.70s	_7.87s	_{p=0.810 n=6}
_{Bind Time}	_{2.48s (± 1.66%)}	_{2.49s (± 1.16%)}	_~	_2.44s	_2.53s	_{p=0.627 n=6}
_{Check Time}	_{49.39s (± 0.60%)}	_{49.45s (± 0.38%)}	_~	_49.19s	_49.75s	_{p=0.298 n=6}
_{Emit Time}	_{3.89s (± 3.74%)}	_{3.84s (± 2.79%)}	_~	_3.67s	_3.95s	_{p=0.689 n=6}
_{Total Time}	_{63.52s (± 0.43%)}	_{63.55s (± 0.45%)}	_~	_63.31s	_64.08s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,476	_256,476	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,239	_104,239	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{425,331k (± 0.01%)}	_{425,346k (± 0.01%)}	_~	_425,316k	_425,377k	_{p=0.689 n=6}
_{Parse Time}	_{4.17s (± 0.48%)}	_{4.19s (± 0.38%)}	_~	_4.18s	_4.22s	_{p=0.145 n=6}
_{Bind Time}	_{1.61s (± 0.68%)}	_{1.61s (± 0.55%)}	_~	_1.60s	_1.62s	_{p=0.932 n=6}
_{Check Time}	_{21.90s (± 0.45%)}	_{21.98s (± 0.19%)}	_~	_21.93s	_22.03s	_{p=0.199 n=6}
_{Emit Time}	_{1.72s (± 2.06%)}	_{1.72s (± 1.71%)}	_~	_1.68s	_1.75s	_{p=1.000 n=6}
_{Total Time}	_{29.40s (± 0.39%)}	_{29.50s (± 0.20%)}	_~	_29.40s	_29.57s	_{p=0.108 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,813k (± 0.02%)}	_{369,827k (± 0.02%)}	_~	_369,750k	_369,960k	_{p=0.873 n=6}
_{Parse Time}	_{2.32s (± 1.31%)}	_{2.34s (± 0.94%)}	_~	_2.32s	_2.36s	_{p=0.361 n=6}
_{Bind Time}	_{1.35s (± 1.52%)}	_{1.33s (± 1.00%)}	_~	_1.32s	_1.35s	_{p=0.082 n=6}
_{Check Time}	_{13.28s (± 0.90%)}	_{13.24s (± 0.42%)}	_~	_13.17s	_13.30s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.95s (± 0.80%)}	_{16.92s (± 0.35%)}	_~	_16.85s	_17.00s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,809,033	_2,809,033	_~	_~	_~	_{p=1.000 n=6}
_Types	_953,187	_953,187	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,980,814k (± 0.00%)}	_{2,980,772k (± 0.00%)}	_~	_2,980,673k	_2,980,883k	_{p=0.423 n=6}
_{Parse Time}	_{11.47s (± 0.26%)}	_{11.49s (± 0.48%)}	_~	_11.43s	_11.59s	_{p=0.628 n=6}
_{Bind Time}	_{3.43s (± 0.24%)}	_{3.43s (± 0.15%)}	_~	_3.43s	_3.44s	_{p=0.929 n=6}
_{Check Time}	_{62.77s (± 0.46%)}	_{62.63s (± 0.51%)}	_~	_62.15s	_62.94s	_{p=0.521 n=6}
_{Emit Time}	_{20.19s (± 0.99%)}	_{20.19s (± 0.58%)}	_~	_20.03s	_20.32s	_{p=0.810 n=6}
_{Total Time}	_{97.87s (± 0.46%)}	_{97.75s (± 0.42%)}	_~	_97.08s	_98.18s	_{p=0.748 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,424	_108,424	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,481k (± 0.02%)}	_{410,449k (± 0.01%)}	_~	_410,421k	_410,492k	_{p=0.378 n=6}
_{Parse Time}	_{3.85s (± 0.72%)}	_{3.82s (± 0.70%)}	_~	_3.79s	_3.87s	_{p=0.145 n=6}
_{Bind Time}	_{1.67s (± 0.82%)}	_{1.66s (± 0.59%)}	_{-0.02s (- 1.00%)}	_1.65s	_1.67s	_{p=0.044 n=6}
_{Check Time}	_{16.89s (± 0.49%)}	_{16.87s (± 0.34%)}	_~	_16.80s	_16.95s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.42s (± 0.44%)}	_{22.36s (± 0.21%)}	_~	_22.28s	_22.41s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,576	_524,576	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,847	_178,847	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,564k (± 0.01%)}	_{462,504k (± 0.01%)}	_~	_462,423k	_462,553k	_{p=0.054 n=6}
_{Parse Time}	_{2.61s (± 0.61%)}	_{2.61s (± 0.86%)}	_~	_2.60s	_2.66s	_{p=0.866 n=6}
_{Bind Time}	_{0.98s (± 1.06%)}	_{0.97s (± 1.06%)}	_~	_0.96s	_0.98s	_{p=0.652 n=6}
_{Check Time}	_{15.30s (± 0.62%)}	_{15.35s (± 0.80%)}	_~	_15.22s	_15.49s	_{p=0.625 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.89s (± 0.53%)}	_{18.94s (± 0.55%)}	_~	_18.82s	_19.06s	_{p=0.467 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,419ms (± 0.22%)}	_{3,082ms (±11.79%)}	_~	_2,740ms	_3,425ms	_{p=0.065 n=6}
_{Req 2 - geterr}	_{7,597ms (± 0.68%)}	_{7,094ms (±10.32%)}	_~	_6,121ms	_7,598ms	_{p=0.092 n=6}
_{Req 3 - references}	_{439ms (± 1.48%)}	_{402ms (±11.17%)}	_~	_344ms	_439ms	_{p=0.053 n=6}
_{Req 4 - navto}	_{336ms (± 0.91%)}	_{317ms (± 9.71%)}	_~	_277ms	_338ms	_{p=0.288 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{112ms (± 0.75%)}	_{115ms (± 3.06%)}	_~	_111ms	_121ms	_{p=0.067 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,921ms (± 1.15%)}	_{2,940ms (± 0.83%)}	_~	_2,899ms	_2,973ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{4,759ms (± 9.36%)}	_{4,766ms (± 9.47%)}	_~	_4,563ms	_5,688ms	_{p=0.748 n=6}
_{Req 3 - references}	_{375ms (± 8.32%)}	_{370ms (± 9.47%)}	_~	_355ms	_442ms	_{p=0.165 n=6}
_{Req 4 - navto}	_{297ms (±10.29%)}	_{298ms (± 9.86%)}	_~	_274ms	_336ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{99ms (±13.89%)}	_{99ms (±10.12%)}	_~	_86ms	_109ms	_{p=1.000 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{6,104ms (± 0.70%)}	_{6,120ms (± 0.44%)}	_~	_6,084ms	_6,160ms	_{p=0.520 n=6}
_{Req 2 - geterr}	_{1,396ms (± 9.77%)}	_{1,334ms (± 1.27%)}	_{🟩-62ms (- 4.44%)}	_1,305ms	_1,358ms	_{p=0.045 n=6}
_{Req 3 - references}	_{111ms (± 9.91%)}	_{107ms (± 3.36%)}	_~	_100ms	_109ms	_{p=0.932 n=6}
_{Req 4 - navto}	_{520ms (± 6.82%)}	_{516ms (± 4.30%)}	_~	_500ms	_559ms	_{p=0.748 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,095ms (± 9.71%)}	_{1,055ms (± 0.89%)}	_~	_1,042ms	_1,068ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.69ms (± 0.16%)}	_{227.80ms (± 0.20%)}	_~	_225.24ms	_232.45ms	_{p=0.055 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{294.41ms (± 0.30%)}	_{294.40ms (± 0.27%)}	_~	_287.72ms	_298.67ms	_{p=0.534 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{287.87ms (± 0.25%)}	_{287.89ms (± 0.28%)}	_~	_280.93ms	_292.05ms	_{p=0.712 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{234.69ms (± 0.16%)}	_{234.63ms (± 0.16%)}	_~	_233.11ms	_240.49ms	_{p=0.093 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

fix(58399): preserve original node to eliminate formatter crashes cau…

2c487fd

…sed by missing parent nodes

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 8, 2024

a-tarasyuk commented May 8, 2024

View reviewed changes

src/services/codefixes/fixMissingTypeAnnotationOnExports.ts Outdated Show resolved Hide resolved

use setParentRecursive

f863835

a-tarasyuk requested a review from jakebailey May 8, 2024 20:27

use setParentRecursive in getSynthesizedDeepClone

6c1fa9d

a-tarasyuk requested a review from andrewbranch May 8, 2024 20:59

update baseline

c1dd332

jakebailey approved these changes May 8, 2024

View reviewed changes

jakebailey merged commit dcec37e into microsoft:main May 8, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(58399): [isolatedDeclarations][5.5] Autofix does not work when JSX prop contains a dash #58478

fix(58399): [isolatedDeclarations][5.5] Autofix does not work when JSX prop contains a dash #58478

a-tarasyuk commented May 8, 2024

jakebailey commented May 8, 2024

typescript-bot commented May 8, 2024 •

edited

jakebailey left a comment

typescript-bot commented May 8, 2024

tsc

tsserver

startup

fix(58399): [isolatedDeclarations][5.5] Autofix does not work when JSX prop contains a dash #58478

fix(58399): [isolatedDeclarations][5.5] Autofix does not work when JSX prop contains a dash #58478

Conversation

a-tarasyuk commented May 8, 2024

jakebailey commented May 8, 2024

typescript-bot commented May 8, 2024 • edited

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented May 8, 2024

tsc

tsserver

startup

typescript-bot commented May 8, 2024 •

edited