Correct Regular Expressions Behavior Related to Annex B #58320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
graphemecluster
commented
Apr 25, 2024
src/compiler/scanner.ts
Outdated
| @@ -3390,7 +3400,7 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean | |||
| error(Diagnostics.Unicode_property_value_expressions_are_only_available_when_the_Unicode_u_flag_or_the_Unicode_Sets_v_flag_is_set, start, pos - start); | |||
| } | |||
| } | |||
| else if (unicodeMode) { | |||
| else if (!annexB) { | |||
There was a problem hiding this comment.
In Annex B, braces after p actually should not be parsed at all, but it does provide helpful errors like #58275 (comment)
There was a problem hiding this comment.
Not really outdated
graphemecluster
changed the title
graphemecluster
commented
Apr 27, 2024
Comment on lines
+80
to
+88
| /\q\u\i\c\k\_\f\o\x\-\j\u\m\p\s/, | ||
|
|
||
| !!! error TS1125: Hexadecimal digit expected. | ||
| ~~ | ||
| !!! error TS1510: '\k' must be followed by a capturing group name enclosed in angle brackets. | ||
|
|
||
| !!! error TS1125: Hexadecimal digit expected. | ||
|
|
||
| !!! error TS1125: Hexadecimal digit expected. |
There was a problem hiding this comment.
These are all valid in Annex B. Even /\u{1/ is. In Annex B essentially all weird things are valid, you know. Currently (after #58295) /[\1]/ is valid but /[\8]/ isn’t. I don’t think it’s ideal.
This was referenced Apr 27, 2024
|
Again, FWIW this might be of interest to @rbuckton and @jakebailey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #58295
This fixes issues like the
'}' expectedcases given at #58275 (comment).