Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse program structure if we errored on filenames differing by case #58299

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jakebailey
Copy link
Member

This is speculation based on #58011 and typescript-eslint/typescript-eslint#1192. Not 100% certain it'll help, and can't test without a repro...

@jakebailey
Copy link
Member Author

@typescript-bot pack this

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 24, 2024
@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 24, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
pack this ✅ Started ✅ Results

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 24, 2024

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/161434/artifacts?artifactName=tgz&fileId=90CB9D05B2C2595FA1654CD93049A3B6EC5174276FD7446DD28F001F4E2A881E02&fileName=/typescript-5.5.0-insiders.20240424.tgz"
    }
}

and then running npm install.


There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.5.0-pr-58299-2".;

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont think this is going to cause any change in memory.. Also not reusing because there is error is more perf impacting as well. We need concrete repro to actually identify the issue. The linked issue talks about problem only with programatic usage so i would say there is something there but without repro its hard to just speculate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants