WIP: allow circular project references

[Zzzen]

Fixes #33685

This issue is still being discussed, so there's no need to delve into it here. However, I would like to proceed with packing it and migrating our current project to project references, in order to prepare for the eventual elimination of circular references.

[typescript-bot]

The TypeScript team hasn't accepted the linked issue #33685. If you can get it accepted, this PR will have a better chance of being reviewed.

[Zzzen]

@typescript-bot pack this

[Zzzen]

@jakebailey Could you help me pack it?

[jakebailey]

I mean, I guess I can, but your PR comment implies that you're wanting us to pack this so you can use it in production, which feels a little concerning. Packed builds are really only for testing and to give to people who are having problems to make sure the fix works. If you are actually wanting to use this for anything else... it feels like you probably are actually just trying to work on a continued fork of TS? We're can't keep packing this over and over to support that use case...

I also don't think it's "eventual" that we do this, either.

@typescript-bot pack this

[typescript-bot]

Heya @jakebailey, I've started to run the tarball bundle task on this PR at f4923a4. You can monitor the build here.

[typescript-bot]

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/154201/artifacts?artifactName=tgz&fileId=23414506DC401DC1E74E22A39B5F732972DEAE572B3BDB56AF931DE9D643415102&fileName=/typescript-5.1.0-insiders.20230512.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.1.0-pr-54216-5".;

[Zzzen]

Thank you for raising your concerns. I understand your point of view, but let me clarify our intentions. Yes, we do want to use this in production, but we're also actively working on refactoring our code to eliminate circular dependencies. This version should help us through the refactoring process, and we don't want to maintain a fork of the TypeScript compiler either, will switch back to the official versions once it's done.

[ozyman42]

Could we add a compiler option which keeps the existing logic in place (fails if any circular dependency exists)?

[Zzzen]

If I'm understanding correctly, it seems that no additional options are required because it will still fail unless all circular dependencies are explicitly identified as such.

[Zzzen]

If I'm understanding correctly, it seems that no additional options are required because it will still fail unless all circular dependencies are explicitly identified as such.