Allowed tuples to have both named and anonymous members #53356

JoshuaKGoldberg · 2023-03-19T19:02:08Z

Previously, the labeledElementDeclarations property on TupleTypes was all-or-nothing for having named vs. anonymous members. Now that it's possible for them to mix-and-match, this PR pulls logic from getParameterNameAtPosition into getTupleElementLabel for filling in a name (`${restParameterName}_${index}`).

Co-authored-by: Mateusz Burzyński mateuszburzynski@gmail.com

JoshuaKGoldberg · 2023-03-19T19:52:57Z

src/compiler/types.ts

@@ -6399,7 +6399,7 @@ export interface TupleType extends GenericType {
    hasRestElement: boolean;
    combinedFlags: ElementFlags;
    readonly: boolean;
-    labeledElementDeclarations?: readonly (NamedTupleMember | ParameterDeclaration)[];
+    labeledElementDeclarations?: readonly (NamedTupleMember | ParameterDeclaration | undefined)[];


[Breaking API Change] Is this the right choice to make? One alternative could be to rename it to elementDeclarations with a type like readonly (ParameterDeclaration | TypeNode). My hunch is that that would be preferable, but I'm going with this smaller change for now to make reviewing easier.

Renaming it doesn't feel like a good idea compared to this; I assume that this array is indexed such that there are empty spaces where there are no names?

I assume that this array is indexed such that there are empty spaces where there are no names?

To the best of my knowledge - yes. There are a couple of places in this PR where it seems to be handled this way

What would the alternative be if not an array with missing names?

I think that most implementations that would include keeping labeledElementDeclarations with partial labels could be considered a breaking change. Even if you somehow omit undefined positions you still end up with a .length mismatch between those and other properties and that would be rather disastrous.

I think the current structure of this object makes the most sense but if you consider it to be too big of a breaking change then I think a different property should be added when mixed labels are involved and this one should be kept as undefined in such situations. That will be inconvenient to work with but if maintaining a backward compatibility is the goal then I don't see any other straightforward way of achieving this.

As in, this array seems to be the only one in the interface which actually describes each element; if we were to keep this array without making elements undefined, then the only thing I can think is that all of the named members gets smooshed up together, except now their indexes are lost.

So, it seems to me that the change in the PR is the least breaky option when we're now saying that something can potentially be undefined, because otherwise someone may iterate over this list thinking they're seeing everything, right?

Sorry, I mean "what would the alternative be if not an array which can contain undefined?"

I was responding to exactly that but perhaps I wasn't super clear. Should I try to rephrase my original answer?

if we were to keep this array without making elements undefined, then the only thing I can think is that all of the named members gets smooshed up together, except now their indexes are lost.

yeah, that would be IMHO bad - I mentioned that here: "Even if you somehow omit undefined positions you still end up with a .length mismatch between those and other properties and that would be rather disastrous.". But right now one alternative option comes to my mind - the missing labels could be prefilled with some defaults. You already generate such things for function parameters and stuff at times, like arg_0, etc, or something like that.

I know we generate synthetic nodes for names for stuff like declaration emit, but do we commonly store them in the types? (I genuinely don't know the answer!)

I don't know that either and perhaps you don't ever do that right now. I prefer to leave those optional members as undefined, that's just an idea that would help you to minimize the impact of this change if you think that this is a strong requirement for this PR to land.

I think we're agreeing? I think I too prefer to make them undefined just like this PR does; I just wanted to make sure that was the best choice given the break. Reasonably no matter what, if downstream users care about this particular bit, they're going to have to fix their code.

tests/baselines/reference/namedTupleMembersErrors.types

src/compiler/checker.ts

Co-authored-by: Jake Bailey <jabaile@microsoft.com>

src/compiler/checker.ts

Co-authored-by: Jake Bailey <jabaile@microsoft.com>

Andarist · 2023-03-24T15:00:55Z

I think that it would be nice to get some code coverage for generic mapped types with array constraints. With them named and anonymous elements should be preserved in the same way. Similarly, it should be possible to add new named/anonymous elements using generic conditional types.

tests/baselines/reference/partiallyNamedTuples.types

tests/cases/conformance/types/tuple/named/partiallyNamedTuples.ts

…types Keep partial labels in `createTupleTargetType`

tests/cases/conformance/types/tuple/named/partiallyNamedTuples.ts

This reverts commit 796ec06.

typescript-bot · 2023-06-15T20:43:15Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 6a7fdd1. You can monitor the build here.

typescript-bot · 2023-06-15T20:43:15Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 6a7fdd1. You can monitor the build here.

typescript-bot · 2023-06-15T20:43:15Z

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 6a7fdd1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-15T20:43:15Z

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 6a7fdd1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-15T20:43:15Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 6a7fdd1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-06-15T20:45:14Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155492/artifacts?artifactName=tgz&fileId=34ECE4E0DBA7A648A8E18CCCC5BCD760BD4EEAB6ABD100E36CC69554625B304302&fileName=/typescript-5.2.0-insiders.20230615.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-53356-21".;

typescript-bot · 2023-06-15T20:57:27Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..53356

_Metric	_main	₅₃₃₅₆	_Delta	_Best	_Worst	_p-value
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{365,530k (± 0.01%)}	_{365,555k (± 0.01%)}	_~	_365,508k	_365,595k	_{p=0.298 n=6}
_{Parse Time}	_{3.56s (± 0.49%)}	_{3.54s (± 0.40%)}	_~	_3.52s	_3.56s	_{p=0.121 n=6}
_{Bind Time}	_{1.18s (± 0.44%)}	_{1.18s (± 0.46%)}	_{+0.01s (+ 0.71%)}	_1.18s	_1.19s	_{p=0.038 n=6}
_{Check Time}	_{9.62s (± 0.40%)}	_{9.64s (± 0.26%)}	_~	_9.61s	_9.68s	_{p=0.369 n=6}
_{Emit Time}	_{7.95s (± 0.86%)}	_{7.97s (± 0.86%)}	_~	_7.84s	_8.05s	_{p=0.568 n=6}
_{Total Time}	_{22.30s (± 0.47%)}	_{22.33s (± 0.43%)}	_~	_22.17s	_22.47s	_{p=0.572 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{192,572k (± 0.03%)}	_{193,739k (± 0.90%)}	_~	_192,533k	_196,014k	_{p=0.173 n=6}
_{Parse Time}	_{1.59s (± 0.76%)}	_{1.60s (± 1.58%)}	_~	_1.55s	_1.62s	_{p=0.112 n=6}
_{Bind Time}	_{0.83s (± 1.01%)}	_{0.82s (± 0.77%)}	_~	_0.81s	_0.83s	_{p=0.226 n=6}
_{Check Time}	_{10.15s (± 0.93%)}	_{10.17s (± 0.97%)}	_~	_10.04s	_10.33s	_{p=0.873 n=6}
_{Emit Time}	_{3.00s (± 1.02%)}	_{3.01s (± 0.42%)}	_~	_2.99s	_3.02s	_{p=0.935 n=6}
_{Total Time}	_{15.58s (± 0.62%)}	_{15.60s (± 0.72%)}	_~	_15.48s	_15.79s	_{p=0.630 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{345,877k (± 0.00%)}	_{345,887k (± 0.01%)}	_~	_345,859k	_345,913k	_{p=0.470 n=6}
_{Parse Time}	_{2.73s (± 0.67%)}	_{2.74s (± 0.36%)}	_~	_2.73s	_2.76s	_{p=0.251 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.37%)}	_~	_1.08s	_1.09s	_{p=0.595 n=6}
_{Check Time}	_{7.84s (± 0.49%)}	_{7.88s (± 0.83%)}	_~	_7.83s	_8.00s	_{p=0.571 n=6}
_{Emit Time}	_{4.44s (± 0.54%)}	_{4.46s (± 0.31%)}	_~	_4.45s	_4.48s	_{p=0.105 n=6}
_{Total Time}	_{16.10s (± 0.41%)}	_{16.18s (± 0.42%)}	_~	_16.10s	_16.28s	_{p=0.077 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,992k (± 0.01%)}	_{299,984k (± 0.01%)}	_~	_299,962k	_300,014k	_{p=0.378 n=6}
_{Parse Time}	_{2.16s (± 0.59%)}	_{2.17s (± 1.26%)}	_~	_2.14s	_2.20s	_{p=0.864 n=6}
_{Bind Time}	_{1.24s (± 0.61%)}	_{1.24s (± 1.29%)}	_~	_1.22s	_1.26s	_{p=1.000 n=6}
_{Check Time}	_{7.30s (± 0.27%)}	_{7.31s (± 0.44%)}	_~	_7.28s	_7.37s	_{p=0.871 n=6}
_{Emit Time}	_{4.31s (± 0.46%)}	_{4.35s (± 0.78%)}	_~	_4.31s	_4.39s	_{p=0.050 n=6}
_{Total Time}	_{15.01s (± 0.24%)}	_{15.06s (± 0.60%)}	_~	_14.97s	_15.19s	_{p=0.422 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{480,361k (± 0.01%)}	_{480,346k (± 0.00%)}	_~	_480,303k	_480,360k	_{p=0.688 n=6}
_{Parse Time}	_{3.26s (± 0.39%)}	_{3.25s (± 0.37%)}	_~	_3.24s	_3.27s	_{p=0.362 n=6}
_{Bind Time}	_{0.93s (± 0.59%)}	_{0.94s (± 0.00%)}	_~	_0.94s	_0.94s	_{p=0.071 n=6}
_{Check Time}	_{17.90s (± 0.91%)}	_{17.91s (± 0.73%)}	_~	_17.75s	_18.12s	_{p=0.810 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.10s (± 0.77%)}	_{22.10s (± 0.56%)}	_~	_21.96s	_22.31s	_{p=0.810 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{560,644k (± 0.02%)}	_{560,617k (± 0.01%)}	_~	_560,535k	_560,691k	_{p=0.336 n=6}
_{Parse Time}	_{3.99s (± 0.49%)}	_{4.00s (± 0.54%)}	_~	_3.98s	_4.04s	_{p=0.220 n=6}
_{Bind Time}	_{1.76s (± 0.43%)}	_{1.76s (± 0.59%)}	_~	_1.75s	_1.78s	_{p=0.273 n=6}
_{Check Time}	_{3.06s (± 0.64%)}	_{3.07s (± 0.34%)}	_~	_3.06s	_3.09s	_{p=0.332 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{8.90s (± 0.37%)}	_{8.94s (± 0.18%)}	_~	_8.91s	_8.95s	_{p=0.077 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₃₃₅₆	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

jakebailey · 2023-06-15T21:05:03Z

@typescript-bot test this

typescript-bot · 2023-06-15T21:05:05Z

Heya @jakebailey, I've started to run the extended test suite on this PR at 6a7fdd1. You can monitor the build here.

typescript-bot · 2023-06-15T21:10:23Z

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/53356/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-53356/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-06-15T22:07:44Z

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/53356/merge:

Everything looks good!

typescript-bot · 2023-06-15T22:44:54Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

typescript-bot · 2023-06-16T00:40:16Z

Hey @jakebailey, it looks like the DT test run failed. Please check the log for more details.
You can check the log here.

jakebailey · 2023-06-22T18:26:05Z

@typescript-bot run dt

typescript-bot · 2023-06-22T18:26:08Z

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 6a7fdd1. You can monitor the build here.

Update: The results are in!

jakebailey

So, I think this looks fine, and I think the break is probably also fine because it's introducing a new feature that downstream API users will have to handle (and existing code will not contain undefined and so will keep working with existing tooling).

Maybe someone else has an opinion here; @DanielRosenwasser?

typescript-bot · 2023-06-22T20:41:20Z

Hey @jakebailey, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

src/compiler/checker.ts

Co-authored-by: Daniel Rosenwasser <drosenwasser@microsoft.com>

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 19, 2023

Allowed tuples to have both named and anonymous members

b7816ea

JoshuaKGoldberg force-pushed the mixed-tuple-naming branch from 2dda8ac to b7816ea Compare March 19, 2023 19:51

JoshuaKGoldberg commented Mar 19, 2023

View reviewed changes

Andarist reviewed Mar 19, 2023

View reviewed changes

tests/baselines/reference/namedTupleMembersErrors.types Outdated Show resolved Hide resolved

JoshuaKGoldberg added 2 commits March 22, 2023 18:10

What a fun little caching issue

2c316ce

fix: it's any member being defined, not the array length

d246ce9

jakebailey reviewed Mar 23, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg and others added 2 commits March 23, 2023 12:09

Lint fix

c5efef9

Switch to mapDefined, very nice

9859f6a

Co-authored-by: Jake Bailey <jabaile@microsoft.com>

jakebailey reviewed Mar 23, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg marked this pull request as ready for review March 23, 2023 16:48

Clear mapDefined result

99c4a01

Co-authored-by: Jake Bailey <jabaile@microsoft.com>

JoshuaKGoldberg requested review from jakebailey and Andarist and removed request for jakebailey March 24, 2023 12:14

JoshuaKGoldberg added 4 commits March 26, 2023 15:03

More baselines

c3c2da3

Added ConditionalTuple test case

c994d4b

without ^?

31f493a

accept baselines

df397a7

JoshuaKGoldberg commented Mar 26, 2023

View reviewed changes

tests/baselines/reference/partiallyNamedTuples.types Outdated Show resolved Hide resolved

Keep partial labels in createTupleTargetType

bf4b8cb

Andarist reviewed Mar 27, 2023

View reviewed changes

tests/cases/conformance/types/tuple/named/partiallyNamedTuples.ts Show resolved Hide resolved

JoshuaKGoldberg and others added 2 commits March 27, 2023 10:05

Merge pull request #3 from Andarist/keep-partial-labels-tuple-target-…

3431d24

…types Keep partial labels in `createTupleTargetType`

Remove redundant tests

796ec06

Andarist reviewed Mar 27, 2023

View reviewed changes

tests/cases/conformance/types/tuple/named/partiallyNamedTuples.ts Outdated Show resolved Hide resolved

sandersn added this to Not started in PR Backlog Mar 27, 2023

JoshuaKGoldberg added 2 commits March 27, 2023 14:11

Revert "Remove redundant tests"

ffcfc79

This reverts commit 796ec06.

ToMixedTuple again

72ad400

jakebailey added the Breaking Change Would introduce errors in existing code label Jun 22, 2023

jakebailey approved these changes Jun 22, 2023

View reviewed changes

PR Backlog automation moved this from Waiting on reviewers to Needs merge Jun 22, 2023

DanielRosenwasser reviewed Jun 23, 2023

View reviewed changes

src/compiler/checker.ts Show resolved Hide resolved

Daniel Rosenwasser: Prettier as a Service

88eadca

Co-authored-by: Daniel Rosenwasser <drosenwasser@microsoft.com>

DanielRosenwasser approved these changes Jun 26, 2023

View reviewed changes

DanielRosenwasser merged commit 5b85e94 into microsoft:main Jun 26, 2023
17 checks passed

PR Backlog automation moved this from Needs merge to Done Jun 26, 2023

JoshuaKGoldberg deleted the mixed-tuple-naming branch June 26, 2023 17:42

DanielRosenwasser added this to the TypeScript 5.2.0 milestone Jun 29, 2023

alex-kinokon mentioned this pull request Aug 22, 2023

ts 5.2 API Change: labeledElementDeclarations can contain undefined TypeStrong/typedoc#2369

Closed

jakebailey mentioned this pull request Sep 19, 2023

Preserve partially typed tuple names in more places #55789

Merged

This was referenced Mar 21, 2024

Merging tuples in templates looses labeling #43020

Closed

Infer and preserve the label of an element for Named Tuples #49122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allowed tuples to have both named and anonymous members #53356

Allowed tuples to have both named and anonymous members #53356

JoshuaKGoldberg commented Mar 19, 2023 •

edited

JoshuaKGoldberg Mar 19, 2023 •

edited

jakebailey Jun 16, 2023

Andarist Jun 16, 2023

jakebailey Jun 16, 2023

Andarist Jun 19, 2023

jakebailey Jun 20, 2023

Andarist Jun 20, 2023

jakebailey Jun 20, 2023

Andarist Jun 20, 2023

jakebailey Jun 20, 2023

Andarist commented Mar 24, 2023

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023

jakebailey commented Jun 15, 2023

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 15, 2023

typescript-bot commented Jun 15, 2023

typescript-bot commented Jun 16, 2023

jakebailey commented Jun 22, 2023

typescript-bot commented Jun 22, 2023 •

edited

jakebailey left a comment

typescript-bot commented Jun 22, 2023

Allowed tuples to have both named and anonymous members #53356

Allowed tuples to have both named and anonymous members #53356

Conversation

JoshuaKGoldberg commented Mar 19, 2023 • edited

JoshuaKGoldberg Mar 19, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Andarist commented Mar 24, 2023

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023

jakebailey commented Jun 15, 2023

typescript-bot commented Jun 15, 2023 • edited

typescript-bot commented Jun 15, 2023

/mnt/ts_downloads/rxjs-src/build.sh

typescript-bot commented Jun 15, 2023

typescript-bot commented Jun 15, 2023

typescript-bot commented Jun 16, 2023

jakebailey commented Jun 22, 2023

typescript-bot commented Jun 22, 2023 • edited

jakebailey left a comment

Choose a reason for hiding this comment

typescript-bot commented Jun 22, 2023

JoshuaKGoldberg commented Mar 19, 2023 •

edited

JoshuaKGoldberg Mar 19, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 15, 2023 •

edited

typescript-bot commented Jun 22, 2023 •

edited