Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dom update 2022 12 26 #52024

Closed
wants to merge 2 commits into from
Closed

Conversation

8ma10s
Copy link

@8ma10s 8ma10s commented Dec 26, 2022

My intention is to make PublicKeyCredential.isConditionalmediationAvailable method available.

Update *.generated.ts

Rationale for updating these files manually

Since https://github.com/microsoft/TypeScript/blob/main/src/lib/README.md says:

The DOM files ending in .generated.d.ts aren't meant to be edited by hand.

If you need to make changes to such files, make a change to the input files for [our library generator](https://github.com/microsoft/TypeScript-DOM-lib-generator).

I went to https://github.com/microsoft/TypeScript-DOM-lib-generator, but it looks like the workflow pr-to-typescript (https://github.com/microsoft/TypeScript-DOM-lib-generator/blob/main/.github/workflows/pr-to-typescript.yml) hasn't been used (run) for years.
(I also tried running the workflow on my own fork, but it's of course fails because I don't have the secret secrets.TS_GITHUB_BOT_AUTH.

I noticed that the last PR associated with generated files' changes (#51300) made manual commits to the author's forked repo, I followed the same approach.

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update some generated declaration files related to the DOM. These files aren't meant to be edited by hand, as they are synchronized with files in the TSJS-lib-generator repository. You can read more here. For house-keeping purposes, this pull request will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants