Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native generators/iterables, remove helper cruft #51921

Merged
merged 25 commits into from
Jan 6, 2023
Merged

Use native generators/iterables, remove helper cruft #51921

merged 25 commits into from
Jan 6, 2023

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Dec 16, 2022 •
edited

This PR:

  • Removes unused functions from core.ts.
  • Removes getEntries, which with our new target was always equal to Object.entries
  • Switches nearly every instance of iterators and iteration over to native generators / iterators and for-of, yield, yield*, etc.
  • Switches a couple of arrayFrom(it).map(fn) to the more efficient but less discoverable arrayFrom(it, fn).
  • Removes Collection and ReadonlyCollection entirely, as they were only used in a couple of places which could be more specific. Split out into Completely remove Collection/ReadonlyCollection types #52134 with Completely remove Push type #52133 for Push too.
  • Removes sum, which was a weird function which arbitrarily added up values off of properties of objects.
  • Adds new helper function variants that use iterators where convenient.

This PR doesn't remove arrayFrom, as it turns out to be much faster than Array.from. It also doesn't remove isArray pending #17002.

There's only one main instance where we don't use a native generator, and that's decodeMappings, which seems difficult to change.

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 16, 2022 •
edited

Heya @jakebailey, I've started to run the perf test suite on this PR at 67025d7. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 374,499k (± 0.03%) 374,517k (± 0.01%) +18k (+ 0.00%) 374,446k 374,585k
Parse Time 1.56s (± 0.77%) 1.58s (± 0.77%) +0.01s (+ 0.77%) 1.55s 1.60s
Bind Time 0.53s (± 0.64%) 0.54s (± 1.03%) +0.00s (+ 0.94%) 0.53s 0.55s
Check Time 3.72s (± 0.61%) 3.75s (± 0.98%) +0.02s (+ 0.64%) 3.69s 3.85s
Emit Time 3.82s (± 0.39%) 3.83s (± 1.18%) +0.01s (+ 0.37%) 3.71s 3.93s
Total Time 9.64s (± 0.33%) 9.69s (± 0.76%) +0.05s (+ 0.55%) 9.51s 9.89s
Compiler-Unions - node (v18.10.0, x64)
Memory used 201,783k (± 0.97%) 199,502k (± 0.97%) -2,281k (- 1.13%) 197,727k 203,478k
Parse Time 0.62s (± 1.04%) 0.62s (± 0.89%) -0.00s (- 0.00%) 0.61s 0.63s
Bind Time 0.35s (± 1.48%) 0.35s (± 1.58%) +0.00s (+ 0.28%) 0.34s 0.37s
Check Time 4.69s (± 0.41%) 4.72s (± 0.86%) +0.04s (+ 0.75%) 4.62s 4.79s
Emit Time 1.42s (± 0.88%) 1.42s (± 0.90%) -0.00s (- 0.21%) 1.39s 1.45s
Total Time 7.09s (± 0.31%) 7.12s (± 0.69%) +0.03s (+ 0.47%) 7.03s 7.21s
Monaco - node (v18.10.0, x64)
Memory used 356,379k (± 0.02%) 356,344k (± 0.02%) -35k (- 0.01%) 356,107k 356,452k
Parse Time 1.16s (± 0.70%) 1.19s (± 1.67%) +0.02s (+ 2.15%) 1.16s 1.26s
Bind Time 0.49s (± 1.38%) 0.49s (± 1.00%) +0.00s (+ 0.00%) 0.49s 0.51s
Check Time 3.47s (± 0.53%) 3.51s (± 0.97%) +0.04s (+ 1.01%) 3.44s 3.60s
Emit Time 2.01s (± 0.52%) 2.03s (± 1.41%) +0.02s (+ 1.09%) 1.98s 2.09s
Total Time 7.14s (± 0.42%) 7.22s (± 0.98%) +0.09s (+ 1.23%) 7.10s 7.40s
TFS - node (v18.10.0, x64)
Memory used 312,931k (± 0.16%) 313,601k (± 0.24%) +670k (+ 0.21%) 312,686k 314,936k
Parse Time 0.95s (± 0.99%) 0.96s (± 1.15%) +0.01s (+ 0.74%) 0.94s 0.98s
Bind Time 0.54s (± 7.60%) 0.51s (± 9.00%) 🟩-0.02s (- 4.28%) 0.44s 0.58s
Check Time 3.20s (± 0.62%) 3.22s (± 1.18%) +0.01s (+ 0.37%) 3.16s 3.33s
Emit Time 1.99s (± 0.67%) 2.00s (± 1.08%) +0.01s (+ 0.30%) 1.95s 2.04s
Total Time 6.68s (± 0.41%) 6.68s (± 0.89%) +0.00s (+ 0.04%) 6.50s 6.79s
material-ui - node (v18.10.0, x64)
Memory used 485,693k (± 0.01%) 485,074k (± 0.01%) -619k (- 0.13%) 484,951k 485,187k
Parse Time 1.35s (± 0.72%) 1.37s (± 1.04%) +0.02s (+ 1.63%) 1.34s 1.41s
Bind Time 0.39s (± 1.15%) 0.40s (± 0.86%) +0.01s (+ 2.32%) 0.39s 0.40s
Check Time 9.57s (± 0.42%) 9.65s (± 0.73%) +0.07s (+ 0.75%) 9.48s 9.81s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 11.31s (± 0.38%) 11.42s (± 0.64%) +0.10s (+ 0.91%) 11.23s 11.56s
xstate - node (v18.10.0, x64)
Memory used 569,841k (± 0.01%) 569,546k (± 0.01%) -295k (- 0.05%) 569,455k 569,685k
Parse Time 1.91s (± 0.50%) 1.91s (± 0.63%) +0.01s (+ 0.26%) 1.89s 1.95s
Bind Time 0.69s (± 3.08%) 0.69s (± 1.69%) -0.00s (- 0.58%) 0.67s 0.72s
Check Time 0.98s (± 0.68%) 0.99s (± 0.83%) +0.01s (+ 1.12%) 0.98s 1.02s
Emit Time 0.05s (± 0.00%) 0.05s (± 0.00%) 0.00s ( 0.00%) 0.05s 0.05s
Total Time 3.64s (± 0.76%) 3.65s (± 0.43%) +0.02s (+ 0.47%) 3.63s 3.69s
Angular - node (v16.17.1, x64)
Memory used 373,833k (± 0.01%) 373,759k (± 0.02%) -73k (- 0.02%) 373,544k 373,847k
Parse Time 1.90s (± 0.68%) 1.91s (± 0.52%) +0.01s (+ 0.32%) 1.89s 1.94s
Bind Time 0.65s (± 0.77%) 0.64s (± 0.46%) -0.00s (- 0.47%) 0.64s 0.65s
Check Time 4.80s (± 0.69%) 4.81s (± 0.68%) +0.01s (+ 0.25%) 4.75s 4.90s
Emit Time 4.56s (± 0.77%) 4.58s (± 1.49%) +0.03s (+ 0.57%) 4.46s 4.82s
Total Time 11.90s (± 0.50%) 11.95s (± 0.75%) +0.05s (+ 0.39%) 11.77s 12.27s
Compiler-Unions - node (v16.17.1, x64)
Memory used 203,387k (± 0.61%) 200,185k (± 0.51%) -3,202k (- 1.57%) 199,411k 202,998k
Parse Time 0.79s (± 0.73%) 0.80s (± 0.97%) +0.01s (+ 0.76%) 0.78s 0.81s
Bind Time 0.44s (± 0.83%) 0.44s (± 1.07%) +0.00s (+ 0.92%) 0.43s 0.45s
Check Time 5.59s (± 0.74%) 5.64s (± 0.86%) +0.05s (+ 0.82%) 5.53s 5.76s
Emit Time 1.79s (± 1.12%) 1.79s (± 0.72%) -0.00s (- 0.06%) 1.77s 1.82s
Total Time 8.61s (± 0.47%) 8.67s (± 0.65%) +0.06s (+ 0.69%) 8.54s 8.83s
Monaco - node (v16.17.1, x64)
Memory used 355,744k (± 0.01%) 355,692k (± 0.02%) -52k (- 0.01%) 355,488k 355,797k
Parse Time 1.43s (± 0.65%) 1.44s (± 0.57%) +0.02s (+ 1.12%) 1.43s 1.47s
Bind Time 0.59s (± 0.98%) 0.60s (± 0.78%) +0.01s (+ 1.69%) 0.59s 0.61s
Check Time 4.39s (± 0.63%) 4.40s (± 0.71%) +0.01s (+ 0.23%) 4.31s 4.47s
Emit Time 2.43s (± 0.82%) 2.45s (± 1.26%) +0.02s (+ 0.95%) 2.40s 2.52s
Total Time 8.84s (± 0.46%) 8.89s (± 0.71%) +0.06s (+ 0.66%) 8.76s 9.06s
TFS - node (v16.17.1, x64)
Memory used 312,142k (± 0.01%) 312,074k (± 0.03%) -68k (- 0.02%) 311,867k 312,202k
Parse Time 1.16s (± 1.34%) 1.19s (± 2.37%) +0.02s (+ 1.89%) 1.15s 1.28s
Bind Time 0.57s (± 1.43%) 0.59s (± 5.06%) +0.02s (+ 2.98%) 0.55s 0.69s
Check Time 4.11s (± 0.54%) 4.12s (± 0.51%) +0.01s (+ 0.27%) 4.06s 4.16s
Emit Time 2.45s (± 0.68%) 2.46s (± 0.80%) +0.01s (+ 0.29%) 2.42s 2.51s
Total Time 8.29s (± 0.46%) 8.35s (± 0.38%) +0.06s (+ 0.71%) 8.29s 8.41s
material-ui - node (v16.17.1, x64)
Memory used 484,991k (± 0.00%) 484,398k (± 0.01%) -593k (- 0.12%) 484,286k 484,551k
Parse Time 1.66s (± 0.57%) 1.67s (± 0.69%) +0.01s (+ 0.60%) 1.64s 1.69s
Bind Time 0.48s (± 0.69%) 0.49s (± 0.75%) +0.01s (+ 1.25%) 0.48s 0.49s
Check Time 11.13s (± 1.47%) 11.03s (± 0.73%) -0.11s (- 0.95%) 10.87s 11.16s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.28s (± 1.28%) 13.19s (± 0.62%) -0.09s (- 0.67%) 13.06s 13.32s
xstate - node (v16.17.1, x64)
Memory used 567,481k (± 0.01%) 567,198k (± 0.01%) -283k (- 0.05%) 567,061k 567,391k
Parse Time 2.28s (± 0.36%) 2.30s (± 0.50%) +0.02s (+ 1.01%) 2.27s 2.33s
Bind Time 0.82s (± 2.57%) 0.82s (± 1.98%) +0.00s (+ 0.37%) 0.79s 0.86s
Check Time 1.30s (± 0.54%) 1.32s (± 0.90%) +0.02s (+ 1.31%) 1.29s 1.34s
Emit Time 0.06s (± 0.00%) 0.06s (± 0.00%) 0.00s ( 0.00%) 0.06s 0.06s
Total Time 4.47s (± 0.49%) 4.51s (± 0.58%) +0.04s (+ 0.81%) 4.46s 4.56s
Angular - node (v14.15.1, x64)
Memory used 367,555k (± 0.00%) 367,513k (± 0.01%) -41k (- 0.01%) 367,439k 367,559k
Parse Time 2.03s (± 0.43%) 2.04s (± 0.46%) +0.01s (+ 0.39%) 2.02s 2.06s
Bind Time 0.68s (± 0.53%) 0.69s (± 0.64%) +0.01s (+ 1.17%) 0.68s 0.70s
Check Time 5.12s (± 0.52%) 5.14s (± 0.52%) +0.02s (+ 0.37%) 5.10s 5.20s
Emit Time 4.64s (± 0.50%) 4.70s (± 0.96%) +0.06s (+ 1.18%) 4.63s 4.83s
Total Time 12.48s (± 0.35%) 12.57s (± 0.51%) +0.09s (+ 0.71%) 12.46s 12.73s
Compiler-Unions - node (v14.15.1, x64)
Memory used 199,470k (± 0.51%) 197,277k (± 0.51%) -2,193k (- 1.10%) 194,545k 197,982k
Parse Time 0.90s (± 0.66%) 0.90s (± 0.54%) +0.01s (+ 0.89%) 0.89s 0.91s
Bind Time 0.47s (± 0.73%) 0.47s (± 1.10%) +0.00s (+ 0.86%) 0.46s 0.49s
Check Time 5.87s (± 0.69%) 5.86s (± 0.40%) -0.01s (- 0.17%) 5.80s 5.91s
Emit Time 1.87s (± 0.63%) 1.88s (± 0.71%) +0.01s (+ 0.48%) 1.85s 1.91s
Total Time 9.10s (± 0.50%) 9.11s (± 0.31%) +0.01s (+ 0.12%) 9.05s 9.19s
Monaco - node (v14.15.1, x64)
Memory used 350,655k (± 0.01%) 350,696k (± 0.01%) +41k (+ 0.01%) 350,642k 350,743k
Parse Time 1.57s (± 0.41%) 1.57s (± 0.53%) +0.00s (+ 0.13%) 1.56s 1.59s
Bind Time 0.63s (± 0.47%) 0.64s (± 0.70%) +0.01s (+ 0.95%) 0.63s 0.65s
Check Time 4.65s (± 0.52%) 4.70s (± 0.63%) +0.05s (+ 1.14%) 4.63s 4.77s
Emit Time 2.54s (± 0.88%) 2.56s (± 0.66%) +0.03s (+ 1.14%) 2.52s 2.60s
Total Time 9.39s (± 0.38%) 9.48s (± 0.43%) +0.09s (+ 0.95%) 9.34s 9.55s
TFS - node (v14.15.1, x64)
Memory used 309,177k (± 0.01%) 309,180k (± 0.01%) +2k (+ 0.00%) 309,083k 309,232k
Parse Time 1.30s (± 0.45%) 1.32s (± 0.62%) +0.01s (+ 1.07%) 1.30s 1.34s
Bind Time 0.60s (± 0.75%) 0.61s (± 0.98%) +0.01s (+ 1.34%) 0.60s 0.62s
Check Time 4.34s (± 0.75%) 4.37s (± 0.56%) +0.02s (+ 0.55%) 4.29s 4.41s
Emit Time 2.72s (± 0.69%) 2.74s (± 0.41%) +0.02s (+ 0.70%) 2.71s 2.76s
Total Time 8.96s (± 0.47%) 9.03s (± 0.25%) +0.07s (+ 0.78%) 8.97s 9.07s
material-ui - node (v14.15.1, x64)
Memory used 480,430k (± 0.01%) 479,748k (± 0.00%) -683k (- 0.14%) 479,673k 479,793k
Parse Time 1.87s (± 0.37%) 1.88s (± 0.54%) +0.01s (+ 0.53%) 1.86s 1.91s
Bind Time 0.52s (± 0.85%) 0.53s (± 0.71%) +0.00s (+ 0.57%) 0.52s 0.53s
Check Time 11.41s (± 0.50%) 11.45s (± 0.59%) +0.04s (+ 0.31%) 11.34s 11.62s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 13.81s (± 0.44%) 13.85s (± 0.51%) +0.04s (+ 0.32%) 13.73s 14.06s
xstate - node (v14.15.1, x64)
Memory used 555,990k (± 0.01%) 555,832k (± 0.01%) -157k (- 0.03%) 555,636k 555,910k
Parse Time 2.61s (± 0.85%) 2.65s (± 1.09%) +0.04s (+ 1.49%) 2.59s 2.71s
Bind Time 0.78s (± 0.43%) 0.78s (± 0.61%) +0.00s (+ 0.38%) 0.78s 0.80s
Check Time 1.43s (± 0.47%) 1.44s (± 0.70%) +0.01s (+ 0.56%) 1.42s 1.46s
Emit Time 0.07s (± 0.00%) 0.07s (± 3.23%) -0.00s (- 1.43%) 0.06s 0.07s
Total Time 4.89s (± 0.46%) 4.95s (± 0.54%) +0.05s (+ 1.10%) 4.90s 5.02s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 10
Baseline main 10

TSServer

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,066ms (± 0.34%) 1,067ms (± 0.54%) +1ms (+ 0.11%) 1,057ms 1,084ms
Req 2 - geterr 2,496ms (± 0.43%) 2,511ms (± 1.06%) +15ms (+ 0.58%) 2,454ms 2,569ms
Req 3 - references 164ms (± 1.19%) 164ms (± 0.54%) +0ms (+ 0.12%) 163ms 167ms
Req 4 - navto 142ms (± 1.02%) 144ms (± 1.40%) +2ms (+ 1.62%) 140ms 149ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 54ms (± 7.48%) 55ms (± 7.97%) +1ms (+ 1.30%) 47ms 62ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,141ms (± 0.48%) 1,141ms (± 0.78%) +0ms (+ 0.02%) 1,126ms 1,166ms
Req 2 - geterr 1,571ms (± 0.48%) 1,571ms (± 0.76%) +1ms (+ 0.03%) 1,554ms 1,601ms
Req 3 - references 171ms (± 0.53%) 172ms (± 0.65%) +1ms (+ 0.35%) 170ms 175ms
Req 4 - navto 152ms (± 0.94%) 153ms (± 0.70%) +1ms (+ 0.53%) 150ms 155ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 52ms (± 1.43%) 52ms (± 1.95%) -0ms (- 0.77%) 48ms 53ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 1,552ms (± 0.56%) 1,553ms (± 0.62%) +1ms (+ 0.06%) 1,526ms 1,570ms
Req 2 - geterr 547ms (± 0.75%) 545ms (± 1.67%) -2ms (- 0.31%) 531ms 566ms
Req 3 - references 57ms (± 3.74%) 53ms (± 3.48%) 🟩-4ms (- 7.57%) 50ms 57ms
Req 4 - navto 195ms (± 0.75%) 195ms (± 0.95%) +0ms (+ 0.15%) 191ms 199ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 210ms (± 0.98%) 214ms (± 1.90%) +4ms (+ 1.81%) 206ms 225ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,327ms (± 0.59%) 1,327ms (± 0.49%) -0ms (- 0.02%) 1,315ms 1,339ms
Req 2 - geterr 3,102ms (± 1.20%) 3,090ms (± 0.74%) -12ms (- 0.40%) 3,037ms 3,132ms
Req 3 - references 192ms (± 0.69%) 193ms (± 0.68%) +1ms (+ 0.47%) 191ms 196ms
Req 4 - navto 156ms (± 0.61%) 156ms (± 0.73%) +0ms (+ 0.13%) 154ms 158ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 1.48%) 58ms (± 2.56%) +1ms (+ 1.58%) 55ms 61ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,405ms (± 0.76%) 1,413ms (± 0.87%) +9ms (+ 0.61%) 1,383ms 1,441ms
Req 2 - geterr 2,087ms (± 0.84%) 2,085ms (± 0.82%) -2ms (- 0.11%) 2,052ms 2,116ms
Req 3 - references 201ms (± 0.58%) 202ms (± 0.50%) +0ms (+ 0.20%) 200ms 204ms
Req 4 - navto 166ms (± 1.04%) 168ms (± 1.34%) +2ms (+ 1.02%) 165ms 175ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 56ms (± 1.07%) 55ms (± 1.68%) -0ms (- 0.72%) 54ms 58ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 1,861ms (± 0.61%) 1,865ms (± 0.37%) +4ms (+ 0.22%) 1,854ms 1,887ms
Req 2 - geterr 689ms (± 0.71%) 691ms (± 0.57%) +1ms (+ 0.20%) 683ms 700ms
Req 3 - references 68ms (± 1.55%) 64ms (± 1.45%) 🟩-5ms (- 6.73%) 62ms 66ms
Req 4 - navto 193ms (± 1.37%) 195ms (± 1.12%) +2ms (+ 0.98%) 191ms 202ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 253ms (± 0.76%) 256ms (± 1.18%) +3ms (+ 1.03%) 252ms 267ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,474ms (± 0.38%) 1,482ms (± 0.50%) +8ms (+ 0.53%) 1,465ms 1,500ms
Req 2 - geterr 3,292ms (± 0.27%) 3,301ms (± 0.60%) +9ms (+ 0.26%) 3,258ms 3,345ms
Req 3 - references 210ms (± 1.10%) 209ms (± 1.04%) -1ms (- 0.48%) 207ms 217ms
Req 4 - navto 170ms (± 1.12%) 172ms (± 0.84%) +2ms (+ 1.12%) 169ms 176ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 57ms (± 1.19%) 58ms (± 3.24%) +1ms (+ 1.05%) 56ms 63ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,576ms (± 0.69%) 1,578ms (± 0.58%) +2ms (+ 0.15%) 1,563ms 1,605ms
Req 2 - geterr 2,221ms (± 0.29%) 2,228ms (± 0.43%) +7ms (+ 0.32%) 2,211ms 2,252ms
Req 3 - references 217ms (± 0.63%) 219ms (± 0.90%) +2ms (+ 0.87%) 216ms 223ms
Req 4 - navto 177ms (± 1.09%) 179ms (± 0.72%) +2ms (+ 1.13%) 176ms 183ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 61ms (± 6.71%) 61ms (± 7.18%) 0ms ( 0.00%) 56ms 73ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,988ms (± 0.46%) 1,996ms (± 0.28%) +8ms (+ 0.39%) 1,980ms 2,007ms
Req 2 - geterr 747ms (± 0.58%) 750ms (± 0.56%) +3ms (+ 0.43%) 742ms 760ms
Req 3 - references 74ms (± 0.75%) 68ms (± 2.16%) 🟩-6ms (- 7.99%) 66ms 72ms
Req 4 - navto 215ms (± 1.01%) 218ms (± 0.66%) +3ms (+ 1.54%) 213ms 220ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 285ms (± 0.65%) 276ms (± 1.41%) -9ms (- 2.99%) 271ms 290ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 10
Baseline main 10

Startup

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 120.15ms (± 0.63%) 118.43ms (± 0.41%) -1.71ms (- 1.43%) 116.16ms 124.28ms
tsserver-startup - node (v16.17.1, x64)
Execution time 201.95ms (± 0.48%) 200.66ms (± 0.44%) -1.29ms (- 0.64%) 196.33ms 209.62ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 194.04ms (± 0.40%) 194.04ms (± 0.39%) -0.00ms (- 0.00%) 190.69ms 201.08ms
typescript-startup - node (v16.17.1, x64)
Execution time 179.35ms (± 0.37%) 178.58ms (± 0.32%) -0.77ms (- 0.43%) 175.87ms 188.16ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-131-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51921 10
Baseline main 10

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 20, 2022 •
edited

Heya @jakebailey, I've started to run the perf test suite on this PR at dbf27e9. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,315k (± 0.01%) 372,261k (± 0.01%) -54k (- 0.01%) 372,214k 372,324k
Parse Time 3.95s (± 1.06%) 3.96s (± 0.80%) +0.01s (+ 0.18%) 3.91s 3.99s
Bind Time 1.20s (± 0.83%) 1.20s (± 1.54%) -0.01s (- 0.75%) 1.17s 1.22s
Check Time 8.60s (± 0.38%) 8.59s (± 0.35%) -0.02s (- 0.18%) 8.55s 8.63s
Emit Time 7.60s (± 0.60%) 7.52s (± 0.28%) -0.07s (- 0.98%) 7.50s 7.56s
Total Time 21.36s (± 0.37%) 21.27s (± 0.12%) -0.09s (- 0.44%) 21.22s 21.29s
Compiler-Unions - node (v18.10.0, x64)
Memory used 200,893k (± 1.53%) 195,829k (± 0.02%) -5,064k (- 2.52%) 195,787k 195,873k
Parse Time 1.66s (± 0.95%) 1.65s (± 1.35%) -0.02s (- 1.03%) 1.60s 1.67s
Bind Time 0.79s (± 0.62%) 0.79s (± 0.64%) -0.00s (- 0.35%) 0.79s 0.80s
Check Time 9.46s (± 0.52%) 9.40s (± 0.77%) -0.06s (- 0.58%) 9.30s 9.52s
Emit Time 2.77s (± 1.09%) 2.77s (± 1.47%) +0.00s (+ 0.01%) 2.73s 2.83s
Total Time 14.69s (± 0.42%) 14.62s (± 0.45%) -0.07s (- 0.49%) 14.51s 14.70s
Monaco - node (v18.10.0, x64)
Memory used 353,974k (± 0.01%) 353,937k (± 0.01%) -37k (- 0.01%) 353,914k 353,968k
Parse Time 2.94s (± 1.44%) 2.95s (± 0.71%) +0.00s (+ 0.15%) 2.93s 2.99s
Bind Time 1.04s (± 1.30%) 1.04s (± 1.49%) -0.00s (- 0.22%) 1.01s 1.06s
Check Time 7.22s (± 0.54%) 7.20s (± 0.32%) -0.02s (- 0.22%) 7.17s 7.23s
Emit Time 4.27s (± 0.74%) 4.27s (± 0.61%) +0.00s (+ 0.06%) 4.23s 4.31s
Total Time 15.47s (± 0.75%) 15.46s (± 0.34%) -0.01s (- 0.08%) 15.40s 15.52s
TFS - node (v18.10.0, x64)
Memory used 309,854k (± 0.01%) 309,849k (± 0.00%) -5k (- 0.00%) 309,825k 309,867k
Parse Time 2.24s (± 1.27%) 2.25s (± 0.54%) +0.01s (+ 0.24%) 2.23s 2.26s
Bind Time 1.16s (± 0.72%) 1.16s (± 0.58%) +0.01s (+ 0.45%) 1.16s 1.17s
Check Time 6.81s (± 0.24%) 6.78s (± 0.54%) -0.03s (- 0.44%) 6.72s 6.81s
Emit Time 3.93s (± 0.83%) 3.92s (± 1.09%) -0.00s (- 0.09%) 3.88s 4.00s
Total Time 14.13s (± 0.49%) 14.11s (± 0.42%) -0.02s (- 0.16%) 14.06s 14.22s
material-ui - node (v18.10.0, x64)
Memory used 485,040k (± 0.01%) 484,369k (± 0.01%) -671k (- 0.14%) 484,317k 484,435k
Parse Time 3.55s (± 0.97%) 3.50s (± 0.41%) -0.05s (- 1.29%) 3.49s 3.53s
Bind Time 0.96s (± 0.61%) 0.96s (± 0.59%) -0.00s (- 0.17%) 0.95s 0.97s
Check Time 16.92s (± 0.26%) 16.92s (± 0.86%) -0.00s (- 0.03%) 16.70s 17.15s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.43s (± 0.32%) 21.38s (± 0.68%) -0.05s (- 0.24%) 21.16s 21.61s
xstate - node (v18.10.0, x64)
Memory used 569,641k (± 0.01%) 569,463k (± 0.03%) -178k (- 0.03%) 569,282k 569,655k
Parse Time 4.44s (± 0.66%) 4.40s (± 0.78%) -0.04s (- 0.84%) 4.35s 4.46s
Bind Time 1.70s (± 1.12%) 1.70s (± 0.92%) +0.00s (+ 0.23%) 1.68s 1.72s
Check Time 2.61s (± 0.35%) 2.60s (± 0.92%) -0.00s (- 0.06%) 2.58s 2.63s
Emit Time 0.08s (± 0.24%) 0.08s (± 0.21%) +0.00s (+ 0.13%) 0.08s 0.08s
Total Time 8.82s (± 0.26%) 8.79s (± 0.48%) -0.03s (- 0.36%) 8.72s 8.84s
Angular - node (v16.17.1, x64)
Memory used 371,685k (± 0.01%) 371,627k (± 0.01%) -57k (- 0.02%) 371,578k 371,661k
Parse Time 4.14s (± 0.24%) 4.13s (± 0.46%) -0.01s (- 0.15%) 4.11s 4.16s
Bind Time 1.27s (± 0.71%) 1.27s (± 0.90%) -0.00s (- 0.20%) 1.24s 1.28s
Check Time 9.30s (± 0.43%) 9.28s (± 0.39%) -0.01s (- 0.12%) 9.23s 9.34s
Emit Time 8.01s (± 0.57%) 7.98s (± 0.51%) -0.02s (- 0.30%) 7.92s 8.03s
Total Time 22.71s (± 0.30%) 22.66s (± 0.39%) -0.05s (- 0.21%) 22.56s 22.81s
Compiler-Unions - node (v16.17.1, x64)
Memory used 200,905k (± 0.88%) 198,652k (± 0.90%) -2,253k (- 1.12%) 197,461k 200,995k
Parse Time 1.81s (± 0.60%) 1.80s (± 0.36%) -0.01s (- 0.33%) 1.80s 1.81s
Bind Time 0.85s (± 0.57%) 0.84s (± 1.02%) -0.01s (- 0.65%) 0.84s 0.86s
Check Time 10.21s (± 0.99%) 10.14s (± 1.23%) -0.07s (- 0.68%) 10.00s 10.32s
Emit Time 2.99s (± 0.74%) 2.98s (± 1.15%) -0.01s (- 0.42%) 2.94s 3.02s
Total Time 15.86s (± 0.59%) 15.76s (± 0.75%) -0.10s (- 0.60%) 15.62s 15.90s
Monaco - node (v16.17.1, x64)
Memory used 353,252k (± 0.01%) 353,219k (± 0.01%) -33k (- 0.01%) 353,186k 353,245k
Parse Time 3.15s (± 0.97%) 3.15s (± 0.51%) -0.00s (- 0.13%) 3.13s 3.17s
Bind Time 1.12s (± 0.71%) 1.13s (± 0.51%) +0.01s (+ 0.46%) 1.13s 1.14s
Check Time 7.85s (± 0.49%) 7.84s (± 0.61%) -0.01s (- 0.13%) 7.81s 7.94s
Emit Time 4.51s (± 1.07%) 4.47s (± 0.47%) -0.05s (- 1.02%) 4.44s 4.50s
Total Time 16.64s (± 0.60%) 16.58s (± 0.38%) -0.06s (- 0.35%) 16.53s 16.69s
TFS - node (v16.17.1, x64)
Memory used 309,204k (± 0.00%) 309,213k (± 0.01%) +9k (+ 0.00%) 309,188k 309,236k
Parse Time 2.61s (± 1.26%) 2.59s (± 0.99%) -0.02s (- 0.76%) 2.56s 2.62s
Bind Time 1.06s (± 1.83%) 1.07s (± 2.17%) +0.01s (+ 1.15%) 1.05s 1.10s
Check Time 7.42s (± 0.66%) 7.42s (± 0.32%) +0.00s (+ 0.06%) 7.38s 7.45s
Emit Time 4.21s (± 0.87%) 4.21s (± 0.56%) +0.00s (+ 0.08%) 4.19s 4.24s
Total Time 15.29s (± 0.56%) 15.29s (± 0.30%) -0.00s (- 0.01%) 15.24s 15.34s
material-ui - node (v16.17.1, x64)
Memory used 484,323k (± 0.01%) 483,686k (± 0.00%) -637k (- 0.13%) 483,671k 483,696k
Parse Time 3.66s (± 0.42%) 3.67s (± 0.41%) +0.01s (+ 0.30%) 3.66s 3.69s
Bind Time 1.01s (± 0.79%) 1.01s (± 0.57%) -0.00s (- 0.00%) 1.00s 1.02s
Check Time 17.96s (± 1.92%) 17.89s (± 0.64%) -0.07s (- 0.38%) 17.75s 18.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.63s (± 1.60%) 22.57s (± 0.51%) -0.06s (- 0.25%) 22.42s 22.75s
xstate - node (v16.17.1, x64)
Memory used 567,262k (± 0.02%) 567,067k (± 0.02%) -195k (- 0.03%) 566,933k 567,200k
Parse Time 4.76s (± 0.45%) 4.74s (± 0.48%) -0.02s (- 0.41%) 4.71s 4.76s
Bind Time 1.67s (± 1.63%) 1.64s (± 1.82%) -0.02s (- 1.40%) 1.58s 1.67s
Check Time 2.84s (± 0.61%) 2.83s (± 0.36%) -0.01s (- 0.39%) 2.81s 2.84s
Emit Time 0.09s (± 4.67%) 0.09s (± 4.53%) -0.00s (- 0.11%) 0.08s 0.09s
Total Time 9.35s (± 0.43%) 9.29s (± 0.32%) -0.06s (- 0.60%) 9.26s 9.34s
Angular - node (v14.15.1, x64)
Memory used 365,246k (± 0.00%) 365,233k (± 0.01%) -13k (- 0.00%) 365,191k 365,274k
Parse Time 4.16s (± 0.58%) 4.14s (± 0.45%) -0.02s (- 0.55%) 4.11s 4.16s
Bind Time 1.30s (± 0.35%) 1.30s (± 0.54%) -0.00s (- 0.19%) 1.29s 1.31s
Check Time 9.67s (± 0.64%) 9.62s (± 0.44%) -0.05s (- 0.48%) 9.57s 9.67s
Emit Time 8.21s (± 0.53%) 8.16s (± 0.53%) -0.05s (- 0.63%) 8.10s 8.21s
Total Time 23.35s (± 0.49%) 23.23s (± 0.15%) -0.13s (- 0.54%) 23.19s 23.29s
Compiler-Unions - node (v14.15.1, x64)
Memory used 194,954k (± 0.02%) 192,534k (± 0.15%) -2,420k (- 1.24%) 192,006k 192,758k
Parse Time 1.86s (± 0.95%) 1.84s (± 0.50%) -0.03s (- 1.41%) 1.83s 1.85s
Bind Time 0.88s (± 0.81%) 0.87s (± 0.60%) -0.00s (- 0.54%) 0.86s 0.88s
Check Time 10.16s (± 0.64%) 10.20s (± 1.05%) +0.04s (+ 0.37%) 10.10s 10.40s
Emit Time 3.14s (± 1.11%) 3.23s (± 5.48%) +0.09s (+ 2.84%) 3.09s 3.50s
Total Time 16.04s (± 0.59%) 16.13s (± 1.46%) +0.09s (+ 0.58%) 15.91s 16.53s
Monaco - node (v14.15.1, x64)
Memory used 348,052k (± 0.01%) 348,058k (± 0.01%) +6k (+ 0.00%) 348,033k 348,108k
Parse Time 3.25s (± 0.88%) 3.26s (± 1.72%) +0.00s (+ 0.05%) 3.18s 3.34s
Bind Time 1.12s (± 0.61%) 1.12s (± 0.93%) -0.00s (- 0.25%) 1.11s 1.14s
Check Time 8.20s (± 0.34%) 8.14s (± 0.28%) -0.06s (- 0.75%) 8.11s 8.16s
Emit Time 4.75s (± 0.34%) 4.68s (± 0.50%) -0.07s (- 1.43%) 4.65s 4.71s
Total Time 17.33s (± 0.35%) 17.19s (± 0.31%) -0.14s (- 0.79%) 17.13s 17.28s
TFS - node (v14.15.1, x64)
Memory used 304,118k (± 0.01%) 304,115k (± 0.00%) -3k (- 0.00%) 304,104k 304,123k
Parse Time 2.72s (± 0.78%) 2.70s (± 1.02%) -0.02s (- 0.70%) 2.66s 2.73s
Bind Time 1.08s (± 0.26%) 1.08s (± 0.51%) +0.01s (+ 0.56%) 1.08s 1.09s
Check Time 7.74s (± 0.66%) 7.72s (± 0.56%) -0.03s (- 0.37%) 7.66s 7.78s
Emit Time 4.56s (± 0.87%) 4.56s (± 1.15%) -0.00s (- 0.01%) 4.52s 4.66s
Total Time 16.10s (± 0.44%) 16.06s (± 0.59%) -0.04s (- 0.25%) 15.95s 16.23s
material-ui - node (v14.15.1, x64)
Memory used 479,794k (± 0.00%) 479,145k (± 0.00%) -649k (- 0.14%) 479,129k 479,161k
Parse Time 3.93s (± 0.98%) 3.88s (± 0.68%) -0.04s (- 1.08%) 3.85s 3.91s
Bind Time 1.05s (± 0.49%) 1.04s (± 0.51%) -0.01s (- 0.85%) 1.03s 1.05s
Check Time 19.13s (± 0.48%) 19.05s (± 0.58%) -0.09s (- 0.45%) 18.95s 19.25s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 24.11s (± 0.31%) 23.97s (± 0.49%) -0.14s (- 0.56%) 23.88s 24.20s
xstate - node (v14.15.1, x64)
Memory used 555,627k (± 0.00%) 555,332k (± 0.00%) -295k (- 0.05%) 555,310k 555,369k
Parse Time 5.15s (± 0.80%) 5.12s (± 0.62%) -0.03s (- 0.64%) 5.07s 5.16s
Bind Time 1.59s (± 0.74%) 1.59s (± 0.52%) +0.00s (+ 0.17%) 1.58s 1.60s
Check Time 3.01s (± 0.42%) 2.99s (± 0.55%) -0.01s (- 0.49%) 2.97s 3.01s
Emit Time 0.10s (± 0.10%) 0.10s (± 0.21%) +0.00s (+ 0.07%) 0.10s 0.10s
Total Time 9.85s (± 0.38%) 9.80s (± 0.41%) -0.05s (- 0.52%) 9.77s 9.86s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

TSServer

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,545ms (± 1.87%) 2,551ms (± 2.00%) +6ms (+ 0.22%) 2,474ms 2,629ms
Req 2 - geterr 5,676ms (± 0.62%) 5,676ms (± 1.40%) +0ms (+ 0.00%) 5,619ms 5,806ms
Req 3 - references 359ms (± 1.62%) 363ms (± 1.37%) +3ms (+ 0.93%) 356ms 368ms
Req 4 - navto 293ms (± 2.13%) 290ms (± 1.56%) -2ms (- 0.81%) 281ms 293ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 80ms (± 9.21%) 78ms (± 8.19%) -2ms (- 2.98%) 73ms 89ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,738ms (± 1.14%) 2,741ms (± 1.68%) +3ms (+ 0.09%) 2,668ms 2,786ms
Req 2 - geterr 4,173ms (± 0.80%) 4,147ms (± 0.83%) -25ms (- 0.61%) 4,102ms 4,185ms
Req 3 - references 360ms (± 1.45%) 357ms (± 0.51%) -3ms (- 0.92%) 354ms 359ms
Req 4 - navto 293ms (± 0.39%) 293ms (± 0.63%) +0ms (+ 0.10%) 290ms 294ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 66ms (± 2.40%) 66ms (± 1.96%) -0ms (- 0.46%) 65ms 68ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,623ms (± 0.78%) 3,606ms (± 0.69%) -17ms (- 0.47%) 3,576ms 3,634ms
Req 2 - geterr 1,316ms (± 1.20%) 1,312ms (± 0.57%) -4ms (- 0.34%) 1,304ms 1,322ms
Req 3 - references 105ms (± 2.73%) 101ms (± 2.65%) 🟩-4ms (- 4.09%) 97ms 104ms
Req 4 - navto 364ms (± 2.17%) 364ms (± 1.50%) -0ms (- 0.00%) 357ms 372ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 434ms (± 1.30%) 436ms (± 1.53%) +2ms (+ 0.53%) 427ms 443ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,778ms (± 0.94%) 2,764ms (± 0.35%) -13ms (- 0.49%) 2,754ms 2,780ms
Req 2 - geterr 6,116ms (± 0.35%) 6,075ms (± 0.76%) -41ms (- 0.67%) 6,015ms 6,152ms
Req 3 - references 366ms (± 0.73%) 364ms (± 1.53%) -2ms (- 0.54%) 356ms 373ms
Req 4 - navto 279ms (± 0.93%) 278ms (± 1.36%) -1ms (- 0.51%) 275ms 285ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 84ms (± 7.71%) 82ms (± 7.56%) -1ms (- 1.64%) 77ms 94ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,918ms (± 1.02%) 2,902ms (± 0.41%) -16ms (- 0.56%) 2,882ms 2,919ms
Req 2 - geterr 4,517ms (± 0.76%) 4,497ms (± 0.29%) -20ms (- 0.44%) 4,480ms 4,518ms
Req 3 - references 387ms (± 0.37%) 385ms (± 0.61%) -2ms (- 0.45%) 381ms 387ms
Req 4 - navto 295ms (± 1.56%) 296ms (± 0.98%) +1ms (+ 0.40%) 293ms 300ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 75ms (± 4.09%) 71ms (± 3.41%) 🟩-3ms (- 4.12%) 69ms 75ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,758ms (± 0.25%) 3,745ms (± 0.54%) -12ms (- 0.33%) 3,721ms 3,776ms
Req 2 - geterr 1,445ms (± 2.23%) 1,447ms (± 1.58%) +2ms (+ 0.16%) 1,410ms 1,471ms
Req 3 - references 108ms (± 1.46%) 105ms (± 1.24%) 🟩-3ms (- 3.16%) 103ms 107ms
Req 4 - navto 350ms (± 0.71%) 349ms (± 0.76%) -1ms (- 0.37%) 346ms 353ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 454ms (± 1.40%) 450ms (± 0.95%) -4ms (- 0.89%) 444ms 455ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,060ms (± 0.87%) 3,039ms (± 0.53%) -21ms (- 0.67%) 3,012ms 3,060ms
Req 2 - geterr 5,942ms (± 0.33%) 5,961ms (± 0.43%) +19ms (+ 0.31%) 5,916ms 5,997ms
Req 3 - references 391ms (± 0.25%) 381ms (± 0.18%) -10ms (- 2.54%) 380ms 382ms
Req 4 - navto 289ms (± 0.81%) 292ms (± 0.37%) +3ms (+ 0.93%) 290ms 293ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 83ms (± 1.97%) 78ms (± 1.18%) 🟩-5ms (- 5.52%) 77ms 80ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,205ms (± 0.78%) 3,192ms (± 0.85%) -12ms (- 0.38%) 3,161ms 3,225ms
Req 2 - geterr 4,433ms (± 0.68%) 4,406ms (± 0.49%) -27ms (- 0.62%) 4,366ms 4,424ms
Req 3 - references 408ms (± 1.23%) 405ms (± 1.40%) -3ms (- 0.70%) 399ms 414ms
Req 4 - navto 313ms (± 0.80%) 302ms (± 2.45%) 🟩-10ms (- 3.36%) 292ms 313ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 80ms (± 4.47%) 86ms (±11.29%) +7ms (+ 8.41%) 76ms 103ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,800ms (± 0.55%) 3,772ms (± 0.69%) -28ms (- 0.75%) 3,733ms 3,809ms
Req 2 - geterr 1,459ms (± 0.26%) 1,461ms (± 0.98%) +2ms (+ 0.16%) 1,440ms 1,483ms
Req 3 - references 132ms (± 1.66%) 124ms (± 2.14%) 🟩-8ms (- 6.13%) 121ms 127ms
Req 4 - navto 396ms (± 0.57%) 397ms (± 2.29%) +1ms (+ 0.27%) 379ms 405ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 490ms (± 3.00%) 485ms (± 0.66%) -5ms (- 1.05%) 481ms 489ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

Startup

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 138.35ms (± 0.21%) 137.52ms (± 0.22%) -0.83ms (- 0.60%) 136.49ms 140.44ms
tsserver-startup - node (v16.17.1, x64)
Execution time 222.49ms (± 0.27%) 220.97ms (± 0.21%) -1.52ms (- 0.68%) 219.55ms 226.53ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 223.69ms (± 0.20%) 222.60ms (± 0.22%) -1.09ms (- 0.49%) 220.82ms 231.88ms
typescript-startup - node (v16.17.1, x64)
Execution time 206.36ms (± 0.19%) 206.16ms (± 0.21%) -0.20ms (- 0.10%) 204.57ms 213.01ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

Running this through benchstat in its current state, it appears to all be noise and some wins that could be chance:

name                                   old s/op   new s/op   delta
Angular_v18_10_0_parseTime             3.98 ± 1%  3.96 ± 1%    ~     (p=0.699 n=6+6)
Angular_v18_10_0_bindTime              1.21 ± 2%  1.20 ± 2%    ~     (p=0.093 n=6+6)
Angular_v18_10_0_checkTime             8.60 ± 1%  8.59 ± 0%    ~     (p=0.699 n=6+6)
Angular_v18_10_0_emitTime              7.53 ± 0%  7.52 ± 0%    ~     (p=0.699 n=6+6)
Angular_v18_10_0_totalTime             21.3 ± 0%  21.3 ± 0%    ~     (p=0.180 n=6+6)
Angular_v16_17_1_parseTime             4.13 ± 0%  4.13 ± 1%    ~     (p=1.000 n=5+6)
Angular_v16_17_1_bindTime              1.26 ± 1%  1.27 ± 1%    ~     (p=0.329 n=6+5)
Angular_v16_17_1_checkTime             9.25 ± 0%  9.28 ± 1%    ~     (p=0.132 n=6+6)
Angular_v16_17_1_emitTime              7.97 ± 0%  7.98 ± 1%    ~     (p=0.485 n=6+6)
Angular_v16_17_1_totalTime             22.6 ± 0%  22.7 ± 1%    ~     (p=0.394 n=6+6)
Angular_v14_15_1_parseTime             4.18 ± 1%  4.14 ± 1%  -0.91%  (p=0.026 n=6+6)
Angular_v14_15_1_bindTime              1.30 ± 1%  1.30 ± 1%    ~     (p=0.855 n=6+6)
Angular_v14_15_1_checkTime             9.67 ± 1%  9.62 ± 1%    ~     (p=0.240 n=6+6)
Angular_v14_15_1_emitTime              8.23 ± 1%  8.16 ± 1%    ~     (p=0.093 n=6+6)
Angular_v14_15_1_totalTime             23.4 ± 1%  23.2 ± 0%    ~     (p=0.082 n=6+5)
Compiler_Unions_v18_10_0_parseTime     1.67 ± 1%  1.66 ± 1%    ~     (p=0.126 n=6+5)
Compiler_Unions_v18_10_0_bindTime      0.80 ± 0%  0.79 ± 1%  -0.78%  (p=0.000 n=5+6)
Compiler_Unions_v18_10_0_checkTime     9.47 ± 1%  9.40 ± 1%    ~     (p=0.084 n=6+6)
Compiler_Unions_v18_10_0_emitTime      2.78 ± 1%  2.77 ± 2%    ~     (p=0.818 n=6+6)
Compiler_Unions_v18_10_0_totalTime     14.7 ± 1%  14.6 ± 1%  -0.63%  (p=0.026 n=6+6)
Compiler_Unions_v16_17_1_parseTime     1.81 ± 0%  1.80 ± 1%  -0.68%  (p=0.009 n=6+6)
Compiler_Unions_v16_17_1_bindTime      0.84 ± 2%  0.84 ± 0%    ~     (p=0.126 n=6+5)
Compiler_Unions_v16_17_1_checkTime     10.2 ± 1%  10.1 ± 2%    ~     (p=0.394 n=6+6)
Compiler_Unions_v16_17_1_emitTime      3.09 ± 8%  2.98 ± 1%    ~     (p=0.485 n=6+6)
Compiler_Unions_v16_17_1_totalTime     15.9 ± 2%  15.8 ± 1%    ~     (p=0.180 n=6+6)
Compiler_Unions_v14_15_1_parseTime     1.85 ± 2%  1.84 ± 1%    ~     (p=0.180 n=6+6)
Compiler_Unions_v14_15_1_bindTime      0.88 ± 0%  0.87 ± 1%    ~     (p=0.114 n=4+6)
Compiler_Unions_v14_15_1_checkTime     10.1 ± 1%  10.2 ± 2%    ~     (p=0.180 n=6+6)
Compiler_Unions_v14_15_1_emitTime      3.13 ± 1%  3.23 ± 8%    ~     (p=0.589 n=6+6)
Compiler_Unions_v14_15_1_totalTime     16.0 ± 1%  16.1 ± 2%    ~     (p=0.394 n=6+6)
Monaco_v18_10_0_parseTime              2.95 ± 1%  2.95 ± 1%    ~     (p=0.905 n=6+6)
Monaco_v18_10_0_bindTime               1.05 ± 4%  1.04 ± 2%    ~     (p=0.699 n=6+6)
Monaco_v18_10_0_checkTime              7.25 ± 1%  7.20 ± 0%  -0.71%  (p=0.026 n=6+6)
Monaco_v18_10_0_emitTime               4.26 ± 1%  4.27 ± 1%    ~     (p=0.589 n=6+6)
Monaco_v18_10_0_totalTime              15.5 ± 1%  15.5 ± 0%    ~     (p=0.180 n=6+6)
Monaco_v16_17_1_parseTime              3.16 ± 1%  3.15 ± 1%    ~     (p=0.589 n=6+6)
Monaco_v16_17_1_bindTime               1.12 ± 1%  1.13 ± 1%    ~     (p=0.662 n=5+6)
Monaco_v16_17_1_checkTime              7.86 ± 1%  7.83 ± 0%    ~     (p=0.177 n=6+5)
Monaco_v16_17_1_emitTime               4.49 ± 1%  4.47 ± 1%    ~     (p=0.485 n=6+6)
Monaco_v16_17_1_totalTime              16.6 ± 1%  16.6 ± 1%    ~     (p=0.180 n=6+6)
Monaco_v14_15_1_parseTime              3.22 ± 0%  3.26 ± 3%    ~     (p=0.114 n=4+6)
Monaco_v14_15_1_bindTime               1.12 ± 2%  1.12 ± 2%    ~     (p=0.310 n=6+6)
Monaco_v14_15_1_checkTime              8.16 ± 1%  8.14 ± 0%    ~     (p=0.818 n=6+6)
Monaco_v14_15_1_emitTime               4.72 ± 1%  4.68 ± 1%  -0.85%  (p=0.015 n=6+6)
Monaco_v14_15_1_totalTime              17.2 ± 0%  17.2 ± 1%    ~     (p=0.240 n=6+6)
TFS_v18_10_0_parseTime                 2.25 ± 2%  2.25 ± 1%    ~     (p=0.937 n=6+6)
TFS_v18_10_0_bindTime                  1.17 ± 2%  1.16 ± 1%    ~     (p=0.589 n=6+6)
TFS_v18_10_0_checkTime                 6.84 ± 1%  6.78 ± 1%  -0.90%  (p=0.026 n=6+6)
TFS_v18_10_0_emitTime                  3.93 ± 1%  3.91 ± 1%    ~     (p=0.082 n=6+5)
TFS_v18_10_0_totalTime                 14.2 ± 1%  14.1 ± 0%  -0.73%  (p=0.004 n=6+5)
TFS_v16_17_1_parseTime                 2.59 ± 1%  2.59 ± 1%    ~     (p=0.818 n=6+6)
TFS_v16_17_1_bindTime                  1.05 ± 2%  1.07 ± 3%    ~     (p=0.180 n=6+6)
TFS_v16_17_1_checkTime                 7.39 ± 0%  7.42 ± 0%    ~     (p=0.093 n=6+6)
TFS_v16_17_1_emitTime                  4.21 ± 2%  4.21 ± 1%    ~     (p=0.818 n=6+6)
TFS_v16_17_1_totalTime                 15.2 ± 0%  15.3 ± 0%    ~     (p=0.093 n=6+6)
TFS_v14_15_1_parseTime                 2.73 ± 2%  2.70 ± 1%    ~     (p=0.132 n=6+6)
TFS_v14_15_1_bindTime                  1.08 ± 1%  1.08 ± 1%    ~     (p=0.727 n=6+6)
TFS_v14_15_1_checkTime                 7.72 ± 0%  7.72 ± 1%    ~     (p=0.699 n=6+6)
TFS_v14_15_1_emitTime                  4.58 ± 1%  4.54 ± 1%    ~     (p=0.126 n=6+5)
TFS_v14_15_1_totalTime                 16.1 ± 1%  16.1 ± 1%    ~     (p=0.394 n=6+6)
material_ui_v18_10_0_parseTime         3.52 ± 1%  3.50 ± 0%    ~     (p=0.052 n=6+5)
material_ui_v18_10_0_bindTime          0.96 ± 1%  0.96 ± 1%    ~     (p=0.699 n=6+6)
material_ui_v18_10_0_checkTime         17.0 ± 1%  16.9 ± 0%    ~     (p=0.257 n=6+4)
material_ui_v18_10_0_emitTime          0.00       0.00         ~     (all equal)
material_ui_v18_10_0_totalTime         21.5 ± 1%  21.4 ± 0%    ~     (p=0.476 n=6+4)
material_ui_v16_17_1_parseTime         3.66 ± 0%  3.67 ± 1%    ~     (p=0.429 n=5+6)
material_ui_v16_17_1_bindTime          1.02 ± 1%  1.01 ± 1%    ~     (p=0.065 n=6+6)
material_ui_v16_17_1_checkTime         18.0 ± 1%  17.9 ± 1%    ~     (p=0.065 n=6+6)
material_ui_v16_17_1_emitTime          0.00       0.00         ~     (all equal)
material_ui_v16_17_1_totalTime         22.7 ± 1%  22.6 ± 1%    ~     (p=0.180 n=6+6)
material_ui_v14_15_1_parseTime         3.89 ± 0%  3.88 ± 1%    ~     (p=0.792 n=5+6)
material_ui_v14_15_1_bindTime          1.05 ± 1%  1.05 ± 0%    ~     (p=0.177 n=6+5)
material_ui_v14_15_1_checkTime         19.0 ± 1%  19.0 ± 1%    ~     (p=0.485 n=6+6)
material_ui_v14_15_1_emitTime          0.00       0.00         ~     (all equal)
material_ui_v14_15_1_totalTime         23.9 ± 0%  23.9 ± 0%    ~     (p=0.662 n=6+5)
xstate_v18_10_0_parseTime              4.45 ± 1%  4.40 ± 0%  -1.17%  (p=0.016 n=5+4)
xstate_v18_10_0_bindTime               1.69 ± 1%  1.70 ± 1%    ~     (p=0.394 n=6+6)
xstate_v18_10_0_checkTime              2.62 ± 1%  2.60 ± 1%    ~     (p=0.485 n=6+6)
xstate_v18_10_0_emitTime               0.08 ± 0%  0.08 ± 0%    ~     (p=0.310 n=6+6)
xstate_v18_10_0_totalTime              8.84 ± 1%  8.79 ± 1%    ~     (p=0.310 n=6+6)
xstate_v16_17_1_parseTime              4.75 ± 0%  4.74 ± 1%    ~     (p=0.589 n=6+6)
xstate_v16_17_1_bindTime               1.66 ± 1%  1.66 ± 1%    ~     (p=0.429 n=6+5)
xstate_v16_17_1_checkTime              2.83 ± 1%  2.83 ± 1%    ~     (p=0.485 n=6+6)
xstate_v16_17_1_emitTime               0.09 ± 0%  0.09 ± 0%  -0.20%  (p=0.032 n=5+5)
xstate_v16_17_1_totalTime              9.32 ± 0%  9.29 ± 1%    ~     (p=0.065 n=6+6)
xstate_v14_15_1_parseTime              5.12 ± 1%  5.12 ± 1%    ~     (p=0.937 n=6+6)
xstate_v14_15_1_bindTime               1.59 ± 1%  1.59 ± 1%    ~     (p=0.818 n=6+6)
xstate_v14_15_1_checkTime              3.00 ± 0%  2.99 ± 1%    ~     (p=0.610 n=4+6)
xstate_v14_15_1_emitTime               0.10 ± 0%  0.10 ± 0%    ~     (p=0.288 n=6+6)
xstate_v14_15_1_totalTime              9.82 ± 0%  9.80 ± 1%    ~     (p=0.240 n=6+6)

@jakebailey jakebailey mentioned this pull request Jan 5, 2023
Merged
jakebailey
jakebailey commented Jan 6, 2023
View reviewed changes
src/compiler/core.ts
@@ -2903,15 +2690,6 @@ export function enumerateInsertsAndDeletes<T, U>(newItems: readonly T[], oldItem
return hasChanges;
}

/** @internal */
export function fill<T>(length: number, cb: (index: number) => T): T[] {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's the same as arrayOf.

@jakebailey jakebailey changed the title Further clean up core.ts helpers (Array.from, real iterators, etc) Use native generators/iterables, remove core.ts cruft Jan 6, 2023
@jakebailey jakebailey changed the title Use native generators/iterables, remove core.ts cruft Use native generators/iterables, remove core.ts cruft, fully remove Collection/ReadonlyCollection Jan 6, 2023
jakebailey
jakebailey commented Jan 6, 2023
View reviewed changes
src/compiler/checker.ts
Comment on lines -350 to +351
hasDecorators,
HasDecorators,
hasDecorators,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying :(

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 6, 2023
@jakebailey jakebailey marked this pull request as ready for review January 6, 2023 20:13
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 6, 2023 •
edited

Heya @jakebailey, I've started to run the perf test suite on this PR at 09f17c6. You can monitor the build here.

Update: The results are in!

@jakebailey
Copy link
Member Author

This should be ready for review, though likely I can split out the Collection removal into a different PR. (The other PRs I've sent for cleanups had been pulled out of this one.)

@jakebailey jakebailey marked this pull request as draft January 6, 2023 21:23
@jakebailey jakebailey mentioned this pull request Jan 6, 2023
Draft
@jakebailey jakebailey marked this pull request as ready for review January 6, 2023 21:42
@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Angular - node (v18.10.0, x64)
Memory used 372,685k (± 0.01%) 372,649k (± 0.01%) -37k (- 0.01%) 372,591k 372,700k
Parse Time 3.98s (± 1.56%) 3.98s (± 0.78%) -0.01s (- 0.19%) 3.94s 4.02s
Bind Time 1.19s (± 0.66%) 1.19s (± 0.47%) -0.00s (- 0.21%) 1.19s 1.20s
Check Time 8.58s (± 0.36%) 8.63s (± 0.58%) +0.06s (+ 0.69%) 8.58s 8.69s
Emit Time 7.53s (± 0.48%) 7.57s (± 1.09%) +0.04s (+ 0.55%) 7.47s 7.68s
Total Time 21.28s (± 0.30%) 21.37s (± 0.53%) +0.09s (+ 0.43%) 21.23s 21.50s
Compiler-Unions - node (v18.10.0, x64)
Memory used 203,003k (± 1.11%) 202,074k (± 1.43%) -929k (- 0.46%) 198,278k 204,082k
Parse Time 1.66s (± 1.89%) 1.65s (± 1.44%) -0.02s (- 0.93%) 1.63s 1.69s
Bind Time 0.80s (± 0.62%) 0.79s (± 0.76%) -0.01s (- 1.07%) 0.79s 0.80s
Check Time 9.48s (± 0.87%) 9.50s (± 0.58%) +0.02s (+ 0.19%) 9.40s 9.56s
Emit Time 2.77s (± 0.42%) 2.78s (± 1.31%) +0.00s (+ 0.09%) 2.73s 2.81s
Total Time 14.72s (± 0.50%) 14.72s (± 0.49%) -0.00s (- 0.01%) 14.62s 14.80s
Monaco - node (v18.10.0, x64)
Memory used 354,128k (± 0.01%) 354,092k (± 0.01%) -35k (- 0.01%) 354,033k 354,129k
Parse Time 2.94s (± 1.01%) 2.95s (± 0.60%) +0.01s (+ 0.27%) 2.92s 2.97s
Bind Time 1.04s (± 1.14%) 1.04s (± 1.15%) +0.00s (+ 0.09%) 1.03s 1.06s
Check Time 7.23s (± 0.55%) 7.25s (± 0.82%) +0.02s (+ 0.26%) 7.20s 7.36s
Emit Time 4.26s (± 0.70%) 4.28s (± 1.01%) +0.01s (+ 0.33%) 4.23s 4.35s
Total Time 15.47s (± 0.44%) 15.51s (± 0.73%) +0.04s (+ 0.27%) 15.41s 15.73s
TFS - node (v18.10.0, x64)
Memory used 310,016k (± 0.01%) 310,006k (± 0.00%) -10k (- 0.00%) 309,997k 310,014k
Parse Time 2.26s (± 0.62%) 2.25s (± 0.85%) -0.01s (- 0.55%) 2.22s 2.27s
Bind Time 1.16s (± 0.46%) 1.16s (± 1.01%) -0.01s (- 0.46%) 1.15s 1.18s
Check Time 6.78s (± 0.48%) 6.78s (± 0.54%) -0.00s (- 0.03%) 6.72s 6.83s
Emit Time 3.91s (± 0.88%) 3.91s (± 0.68%) -0.00s (- 0.08%) 3.86s 3.93s
Total Time 14.11s (± 0.43%) 14.09s (± 0.32%) -0.02s (- 0.17%) 14.03s 14.15s
material-ui - node (v18.10.0, x64)
Memory used 485,221k (± 0.01%) 485,237k (± 0.01%) +16k (+ 0.00%) 485,169k 485,313k
Parse Time 3.53s (± 0.49%) 3.54s (± 0.79%) +0.01s (+ 0.18%) 3.51s 3.57s
Bind Time 0.97s (± 0.93%) 0.96s (± 0.97%) -0.00s (- 0.44%) 0.95s 0.98s
Check Time 16.99s (± 0.16%) 16.95s (± 0.43%) -0.04s (- 0.26%) 16.87s 17.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 21.49s (± 0.14%) 21.45s (± 0.37%) -0.04s (- 0.18%) 21.39s 21.61s
xstate - node (v18.10.0, x64)
Memory used 570,274k (± 0.03%) 570,316k (± 0.02%) +42k (+ 0.01%) 570,168k 570,543k
Parse Time 4.43s (± 0.37%) 4.43s (± 0.67%) -0.00s (- 0.00%) 4.38s 4.47s
Bind Time 1.70s (± 1.06%) 1.70s (± 0.57%) +0.00s (+ 0.29%) 1.69s 1.72s
Check Time 2.60s (± 0.83%) 2.61s (± 0.79%) +0.01s (+ 0.32%) 2.58s 2.63s
Emit Time 0.08s (± 0.10%) 0.08s (± 0.16%) -0.00s (- 0.00%) 0.08s 0.08s
Total Time 8.81s (± 0.23%) 8.81s (± 0.24%) +0.01s (+ 0.09%) 8.78s 8.84s
Angular - node (v16.17.1, x64)
Memory used 372,009k (± 0.01%) 371,997k (± 0.01%) -12k (- 0.00%) 371,964k 372,037k
Parse Time 4.17s (± 0.37%) 4.15s (± 0.64%) -0.02s (- 0.42%) 4.12s 4.18s
Bind Time 1.27s (± 0.67%) 1.26s (± 0.43%) -0.01s (- 0.71%) 1.26s 1.27s
Check Time 9.30s (± 0.48%) 9.36s (± 0.45%) +0.05s (+ 0.57%) 9.31s 9.42s
Emit Time 7.97s (± 0.66%) 7.97s (± 0.64%) -0.01s (- 0.12%) 7.89s 8.02s
Total Time 22.71s (± 0.43%) 22.74s (± 0.37%) +0.02s (+ 0.10%) 22.66s 22.88s
Compiler-Unions - node (v16.17.1, x64)
Memory used 199,966k (± 0.03%) 199,849k (± 0.10%) -117k (- 0.06%) 199,545k 200,016k
Parse Time 1.81s (± 0.42%) 1.80s (± 0.53%) -0.01s (- 0.74%) 1.79s 1.81s
Bind Time 0.84s (± 1.06%) 0.84s (± 0.83%) -0.01s (- 0.69%) 0.83s 0.85s
Check Time 10.10s (± 0.87%) 10.07s (± 0.59%) -0.04s (- 0.38%) 9.97s 10.14s
Emit Time 2.99s (± 1.03%) 3.07s (± 5.99%) +0.08s (+ 2.51%) 2.94s 3.31s
Total Time 15.76s (± 0.63%) 15.77s (± 1.18%) +0.02s (+ 0.11%) 15.62s 16.08s
Monaco - node (v16.17.1, x64)
Memory used 353,439k (± 0.01%) 353,407k (± 0.01%) -32k (- 0.01%) 353,366k 353,450k
Parse Time 3.19s (± 1.47%) 3.17s (± 0.88%) -0.01s (- 0.40%) 3.15s 3.22s
Bind Time 1.13s (± 1.36%) 1.12s (± 1.58%) -0.01s (- 1.07%) 1.10s 1.14s
Check Time 7.87s (± 0.53%) 7.89s (± 0.67%) +0.02s (+ 0.26%) 7.82s 7.97s
Emit Time 4.47s (± 0.82%) 4.47s (± 0.50%) -0.00s (- 0.03%) 4.44s 4.50s
Total Time 16.65s (± 0.55%) 16.65s (± 0.55%) -0.01s (- 0.04%) 16.50s 16.76s
TFS - node (v16.17.1, x64)
Memory used 309,375k (± 0.00%) 309,367k (± 0.00%) -8k (- 0.00%) 309,344k 309,381k
Parse Time 2.61s (± 1.76%) 2.61s (± 1.23%) -0.00s (- 0.19%) 2.56s 2.64s
Bind Time 1.06s (± 2.13%) 1.06s (± 1.83%) +0.00s (+ 0.38%) 1.04s 1.09s
Check Time 7.42s (± 0.72%) 7.43s (± 0.51%) +0.00s (+ 0.07%) 7.37s 7.47s
Emit Time 4.22s (± 0.80%) 4.21s (± 0.76%) -0.00s (- 0.05%) 4.17s 4.26s
Total Time 15.32s (± 0.55%) 15.31s (± 0.37%) -0.00s (- 0.03%) 15.25s 15.40s
material-ui - node (v16.17.1, x64)
Memory used 484,517k (± 0.01%) 484,497k (± 0.00%) -20k (- 0.00%) 484,473k 484,526k
Parse Time 3.68s (± 0.43%) 3.67s (± 0.38%) -0.01s (- 0.26%) 3.66s 3.69s
Bind Time 1.01s (± 0.76%) 1.01s (± 0.75%) -0.00s (- 0.03%) 1.01s 1.03s
Check Time 18.08s (± 1.31%) 17.95s (± 0.83%) -0.13s (- 0.70%) 17.72s 18.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.77s (± 1.09%) 22.63s (± 0.67%) -0.14s (- 0.62%) 22.40s 22.82s
xstate - node (v16.17.1, x64)
Memory used 567,830k (± 0.02%) 567,783k (± 0.01%) -47k (- 0.01%) 567,738k 567,840k
Parse Time 4.76s (± 0.20%) 4.76s (± 0.47%) +0.00s (+ 0.03%) 4.73s 4.80s
Bind Time 1.66s (± 0.41%) 1.66s (± 0.43%) +0.00s (+ 0.30%) 1.65s 1.67s
Check Time 2.83s (± 0.24%) 2.83s (± 0.62%) +0.01s (+ 0.23%) 2.81s 2.86s
Emit Time 0.09s (± 4.59%) 0.09s (± 0.16%) +0.00s (+ 1.89%) 0.09s 0.09s
Total Time 9.34s (± 0.20%) 9.35s (± 0.34%) +0.00s (+ 0.02%) 9.31s 9.39s
Angular - node (v14.15.1, x64)
Memory used 365,658k (± 0.00%) 365,681k (± 0.01%) +23k (+ 0.01%) 365,636k 365,717k
Parse Time 4.16s (± 0.72%) 4.17s (± 0.62%) +0.00s (+ 0.12%) 4.12s 4.19s
Bind Time 1.30s (± 0.38%) 1.31s (± 0.53%) +0.00s (+ 0.26%) 1.30s 1.32s
Check Time 9.67s (± 0.42%) 9.68s (± 0.72%) +0.01s (+ 0.09%) 9.60s 9.80s
Emit Time 8.19s (± 0.42%) 8.22s (± 0.55%) +0.03s (+ 0.37%) 8.16s 8.29s
Total Time 23.32s (± 0.26%) 23.37s (± 0.46%) +0.05s (+ 0.21%) 23.23s 23.56s
Compiler-Unions - node (v14.15.1, x64)
Memory used 195,114k (± 0.02%) 195,175k (± 0.01%) +61k (+ 0.03%) 195,146k 195,208k
Parse Time 1.85s (± 0.38%) 1.85s (± 0.35%) +0.00s (+ 0.11%) 1.84s 1.86s
Bind Time 0.88s (± 0.67%) 0.87s (± 0.67%) -0.01s (- 0.63%) 0.86s 0.88s
Check Time 10.17s (± 0.95%) 10.16s (± 0.47%) -0.01s (- 0.07%) 10.11s 10.23s
Emit Time 3.15s (± 1.22%) 3.13s (± 0.97%) -0.01s (- 0.44%) 3.10s 3.18s
Total Time 16.05s (± 0.76%) 16.02s (± 0.42%) -0.02s (- 0.14%) 15.95s 16.12s
Monaco - node (v14.15.1, x64)
Memory used 348,249k (± 0.00%) 348,229k (± 0.01%) -19k (- 0.01%) 348,198k 348,247k
Parse Time 3.25s (± 1.35%) 3.24s (± 0.91%) -0.02s (- 0.49%) 3.20s 3.28s
Bind Time 1.12s (± 0.76%) 1.12s (± 0.41%) -0.00s (- 0.18%) 1.12s 1.13s
Check Time 8.17s (± 0.40%) 8.17s (± 0.08%) +0.00s (+ 0.01%) 8.16s 8.18s
Emit Time 4.72s (± 0.98%) 4.71s (± 0.83%) -0.00s (- 0.07%) 4.67s 4.77s
Total Time 17.27s (± 0.36%) 17.25s (± 0.27%) -0.02s (- 0.12%) 17.17s 17.30s
TFS - node (v14.15.1, x64)
Memory used 304,293k (± 0.00%) 304,286k (± 0.00%) -6k (- 0.00%) 304,273k 304,296k
Parse Time 2.74s (± 0.54%) 2.72s (± 0.96%) -0.01s (- 0.53%) 2.69s 2.77s
Bind Time 1.09s (± 1.13%) 1.08s (± 0.32%) -0.01s (- 0.86%) 1.08s 1.09s
Check Time 7.77s (± 0.29%) 7.74s (± 0.57%) -0.03s (- 0.38%) 7.68s 7.81s
Emit Time 4.61s (± 1.03%) 4.58s (± 1.04%) -0.03s (- 0.71%) 4.52s 4.64s
Total Time 16.21s (± 0.32%) 16.12s (± 0.45%) -0.08s (- 0.51%) 16.06s 16.25s
material-ui - node (v14.15.1, x64)
Memory used 479,957k (± 0.00%) 479,960k (± 0.01%) +4k (+ 0.00%) 479,926k 479,988k
Parse Time 3.90s (± 0.73%) 3.91s (± 0.60%) +0.00s (+ 0.10%) 3.87s 3.93s
Bind Time 1.05s (± 0.42%) 1.05s (± 0.87%) -0.00s (- 0.07%) 1.03s 1.06s
Check Time 18.96s (± 0.75%) 19.06s (± 0.43%) +0.10s (+ 0.53%) 18.97s 19.16s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 23.92s (± 0.58%) 24.02s (± 0.37%) +0.10s (+ 0.43%) 23.92s 24.16s
xstate - node (v14.15.1, x64)
Memory used 556,185k (± 0.00%) 556,174k (± 0.00%) -11k (- 0.00%) 556,124k 556,196k
Parse Time 5.12s (± 0.64%) 5.13s (± 0.22%) +0.01s (+ 0.12%) 5.12s 5.15s
Bind Time 1.58s (± 0.33%) 1.59s (± 0.42%) +0.00s (+ 0.17%) 1.58s 1.59s
Check Time 3.00s (± 0.78%) 2.99s (± 0.79%) -0.00s (- 0.14%) 2.97s 3.02s
Emit Time 0.10s (± 0.15%) 0.10s (± 0.25%) -0.00s (- 0.14%) 0.10s 0.10s
Total Time 9.81s (± 0.42%) 9.80s (± 0.31%) -0.01s (- 0.06%) 9.77s 9.85s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

TSServer

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,583ms (± 1.90%) 2,535ms (± 1.91%) -48ms (- 1.86%) 2,482ms 2,624ms
Req 2 - geterr 5,388ms (± 2.14%) 5,337ms (± 0.58%) -52ms (- 0.96%) 5,297ms 5,380ms
Req 3 - references 367ms (± 2.12%) 373ms (± 0.58%) +6ms (+ 1.72%) 371ms 377ms
Req 4 - navto 321ms (±27.27%) 279ms (± 0.47%) 🟩-41ms (-12.84%) 278ms 282ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 229ms (±49.98%) 309ms (± 1.36%) 🔻+79ms (+34.59%) 304ms 316ms
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,748ms (± 1.77%) 2,741ms (± 1.27%) -7ms (- 0.26%) 2,688ms 2,779ms
Req 2 - geterr 3,945ms (± 0.76%) 3,958ms (± 0.54%) +13ms (+ 0.33%) 3,922ms 3,984ms
Req 3 - references 362ms (± 1.40%) 362ms (± 0.92%) +0ms (+ 0.00%) 357ms 366ms
Req 4 - navto 292ms (± 1.07%) 290ms (± 1.10%) -2ms (- 0.74%) 286ms 295ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 67ms (± 2.92%) 67ms (± 1.98%) +0ms (+ 0.55%) 66ms 69ms
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,399ms (± 0.34%) 3,379ms (± 0.54%) -20ms (- 0.58%) 3,348ms 3,403ms
Req 2 - geterr 1,522ms (± 0.61%) 1,550ms (± 1.17%) +27ms (+ 1.79%) 1,515ms 1,564ms
Req 3 - references 108ms (± 1.65%) 101ms (± 3.96%) 🟩-6ms (- 5.71%) 96ms 109ms
Req 4 - navto 359ms (± 0.83%) 356ms (± 1.33%) -3ms (- 0.70%) 350ms 364ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 439ms (± 1.06%) 431ms (± 0.86%) -8ms (- 1.85%) 427ms 437ms
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,759ms (± 0.89%) 2,763ms (± 0.36%) +4ms (+ 0.13%) 2,751ms 2,774ms
Req 2 - geterr 5,933ms (± 1.84%) 5,903ms (± 1.73%) -30ms (- 0.51%) 5,701ms 5,988ms
Req 3 - references 364ms (± 0.87%) 362ms (± 0.50%) -3ms (- 0.70%) 360ms 364ms
Req 4 - navto 282ms (± 1.24%) 317ms (±27.66%) +35ms (+12.26%) 278ms 496ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 133ms (±72.07%) 90ms (± 4.38%) 🟩-43ms (-32.12%) 83ms 95ms
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,908ms (± 0.47%) 2,919ms (± 0.39%) +11ms (+ 0.38%) 2,903ms 2,935ms
Req 2 - geterr 4,306ms (± 0.51%) 4,310ms (± 0.41%) +4ms (+ 0.08%) 4,284ms 4,337ms
Req 3 - references 377ms (± 0.57%) 378ms (± 0.95%) +2ms (+ 0.44%) 373ms 382ms
Req 4 - navto 299ms (± 0.86%) 302ms (± 0.46%) +3ms (+ 0.87%) 301ms 304ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 235ms (±52.91%) 318ms (± 1.64%) 🔻+83ms (+35.33%) 313ms 323ms
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,709ms (± 2.69%) 3,760ms (± 0.21%) +51ms (+ 1.38%) 3,752ms 3,770ms
Req 2 - geterr 1,483ms (± 6.02%) 1,464ms (± 1.80%) -19ms (- 1.31%) 1,431ms 1,507ms
Req 3 - references 112ms (± 2.68%) 111ms (± 2.17%) -1ms (- 0.99%) 108ms 114ms
Req 4 - navto 339ms (± 1.96%) 344ms (± 1.21%) +4ms (+ 1.24%) 336ms 348ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 458ms (± 2.81%) 473ms (± 1.90%) +15ms (+ 3.24%) 461ms 487ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,893ms (± 0.42%) 2,810ms (± 6.36%) -83ms (- 2.88%) 2,445ms 2,889ms
Req 2 - geterr 6,123ms (± 0.66%) 5,997ms (± 6.36%) -126ms (- 2.06%) 5,225ms 6,222ms
Req 3 - references 383ms (± 0.91%) 369ms (± 6.99%) 🟩-14ms (- 3.75%) 317ms 385ms
Req 4 - navto 293ms (± 0.75%) 284ms (± 6.42%) -8ms (- 2.85%) 247ms 293ms
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) 0 ( 0.00%) 1,356 1,356
Req 5 - completionInfo 240ms (±51.84%) 127ms (±76.82%) 🟩-114ms (-47.32%) 80ms 325ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,019ms (± 0.72%) 3,019ms (± 0.65%) +0ms (+ 0.01%) 2,998ms 3,053ms
Req 2 - geterr 4,565ms (± 0.90%) 4,556ms (± 0.39%) -9ms (- 0.19%) 4,536ms 4,587ms
Req 3 - references 403ms (± 1.29%) 404ms (± 0.62%) +0ms (+ 0.10%) 401ms 407ms
Req 4 - navto 309ms (± 0.99%) 304ms (± 2.26%) -5ms (- 1.48%) 290ms 309ms
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) 0 ( 0.00%) 1,518 1,518
Req 5 - completionInfo 79ms (± 7.28%) 81ms (± 7.58%) +2ms (+ 2.82%) 77ms 92ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,876ms (± 0.79%) 3,864ms (± 0.48%) -12ms (- 0.30%) 3,836ms 3,884ms
Req 2 - geterr 1,470ms (± 1.28%) 1,454ms (± 0.34%) -16ms (- 1.09%) 1,445ms 1,459ms
Req 3 - references 131ms (± 2.43%) 129ms (± 0.91%) -1ms (- 1.10%) 128ms 131ms
Req 4 - navto 400ms (± 2.05%) 395ms (± 0.32%) -5ms (- 1.24%) 393ms 397ms
Req 5 - completionInfo count 3,154 (± 0.00%) 3,154 (± 0.00%) 0 ( 0.00%) 3,154 3,154
Req 5 - completionInfo 494ms (± 1.25%) 495ms (± 0.82%) +1ms (+ 0.17%) 490ms 500ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

Startup

Comparison Report - main..51921
Metric main 51921 Delta Best Worst
tsc-startup - node (v16.17.1, x64)
Execution time 140.21ms (± 0.47%) 139.15ms (± 0.25%) -1.06ms (- 0.75%) 137.87ms 142.81ms
tsserver-startup - node (v16.17.1, x64)
Execution time 233.14ms (± 0.39%) 230.71ms (± 0.18%) -2.43ms (- 1.04%) 229.12ms 234.99ms
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 235.12ms (± 0.39%) 233.86ms (± 0.22%) -1.27ms (- 0.54%) 231.92ms 238.91ms
typescript-startup - node (v16.17.1, x64)
Execution time 216.04ms (± 0.29%) 215.34ms (± 0.21%) -0.69ms (- 0.32%) 213.93ms 220.06ms
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 51921 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

Seems like it's still noise.

name                                   old s/op   new s/op   delta
Angular_v18_10_0_parseTime             3.98 ± 3%  3.98 ± 1%    ~     (p=0.485 n=6+6)
Angular_v18_10_0_bindTime              1.19 ± 1%  1.19 ± 1%    ~     (p=0.394 n=6+6)
Angular_v18_10_0_checkTime             8.58 ± 1%  8.63 ± 1%  +0.69%  (p=0.041 n=6+6)
Angular_v18_10_0_emitTime              7.53 ± 1%  7.57 ± 2%    ~     (p=0.485 n=6+6)
Angular_v18_10_0_totalTime             21.3 ± 0%  21.4 ± 1%    ~     (p=0.240 n=6+6)
Angular_v16_17_1_parseTime             4.17 ± 1%  4.15 ± 1%    ~     (p=0.310 n=6+6)
Angular_v16_17_1_bindTime              1.27 ± 1%  1.26 ± 0%  -0.71%  (p=0.045 n=6+6)
Angular_v16_17_1_checkTime             9.30 ± 1%  9.36 ± 1%    ~     (p=0.093 n=6+6)
Angular_v16_17_1_emitTime              7.97 ± 1%  7.97 ± 1%    ~     (p=1.000 n=6+6)
Angular_v16_17_1_totalTime             22.7 ± 1%  22.7 ± 1%    ~     (p=0.485 n=6+6)
Angular_v14_15_1_parseTime             4.16 ± 1%  4.17 ± 1%    ~     (p=1.000 n=6+6)
Angular_v14_15_1_bindTime              1.30 ± 1%  1.31 ± 1%    ~     (p=0.485 n=6+6)
Angular_v14_15_1_checkTime             9.67 ± 1%  9.68 ± 1%    ~     (p=0.853 n=6+6)
Angular_v14_15_1_emitTime              8.17 ± 0%  8.22 ± 1%    ~     (p=0.082 n=5+6)
Angular_v14_15_1_totalTime             23.3 ± 0%  23.3 ± 0%    ~     (p=0.792 n=6+5)
Compiler_Unions_v18_10_0_parseTime     1.66 ± 3%  1.65 ± 2%    ~     (p=0.485 n=6+6)
Compiler_Unions_v18_10_0_bindTime      0.80 ± 0%  0.79 ± 1%    ~     (p=0.117 n=5+6)
Compiler_Unions_v18_10_0_checkTime     9.48 ± 2%  9.50 ± 1%    ~     (p=0.937 n=6+6)
Compiler_Unions_v18_10_0_emitTime      2.77 ± 0%  2.78 ± 2%    ~     (p=0.537 n=5+6)
Compiler_Unions_v18_10_0_totalTime     14.7 ± 1%  14.7 ± 1%    ~     (p=1.000 n=6+6)
Compiler_Unions_v16_17_1_parseTime     1.81 ± 0%  1.80 ± 1%    ~     (p=0.065 n=6+6)
Compiler_Unions_v16_17_1_bindTime      0.84 ± 2%  0.84 ± 0%    ~     (p=0.171 n=6+4)
Compiler_Unions_v16_17_1_checkTime     10.1 ± 1%  10.1 ± 1%    ~     (p=0.310 n=6+6)
Compiler_Unions_v16_17_1_emitTime      2.99 ± 1%  3.07 ± 8%    ~     (p=0.394 n=6+6)
Compiler_Unions_v16_17_1_totalTime     15.8 ± 1%  15.8 ± 2%    ~     (p=0.589 n=6+6)
Compiler_Unions_v14_15_1_parseTime     1.85 ± 0%  1.85 ± 0%    ~     (p=0.753 n=6+5)
Compiler_Unions_v14_15_1_bindTime      0.88 ± 0%  0.87 ± 1%  -0.70%  (p=0.048 n=4+6)
Compiler_Unions_v14_15_1_checkTime     10.2 ± 1%  10.2 ± 1%    ~     (p=0.818 n=6+6)
Compiler_Unions_v14_15_1_emitTime      3.15 ± 2%  3.13 ± 1%    ~     (p=0.589 n=6+6)
Compiler_Unions_v14_15_1_totalTime     16.0 ± 1%  16.0 ± 1%    ~     (p=0.699 n=6+6)
Monaco_v18_10_0_parseTime              2.94 ± 2%  2.96 ± 0%    ~     (p=0.537 n=6+5)
Monaco_v18_10_0_bindTime               1.04 ± 2%  1.04 ± 2%    ~     (p=0.937 n=6+6)
Monaco_v18_10_0_checkTime              7.21 ± 0%  7.22 ± 0%    ~     (p=0.310 n=5+5)
Monaco_v18_10_0_emitTime               4.25 ± 0%  4.28 ± 2%    ~     (p=0.429 n=5+6)
Monaco_v18_10_0_totalTime              15.5 ± 1%  15.5 ± 0%    ~     (p=1.000 n=6+5)
Monaco_v16_17_1_parseTime              3.19 ± 2%  3.17 ± 2%    ~     (p=0.699 n=6+6)
Monaco_v16_17_1_bindTime               1.13 ± 2%  1.12 ± 2%    ~     (p=0.180 n=6+6)
Monaco_v16_17_1_checkTime              7.87 ± 1%  7.89 ± 1%    ~     (p=0.621 n=6+6)
Monaco_v16_17_1_emitTime               4.48 ± 1%  4.47 ± 1%    ~     (p=0.247 n=5+6)
Monaco_v16_17_1_totalTime              16.7 ± 1%  16.6 ± 1%    ~     (p=0.937 n=6+6)
Monaco_v14_15_1_parseTime              3.25 ± 2%  3.24 ± 1%    ~     (p=0.699 n=6+6)
Monaco_v14_15_1_bindTime               1.12 ± 1%  1.12 ± 1%    ~     (p=0.485 n=6+6)
Monaco_v14_15_1_checkTime              8.17 ± 1%  8.17 ± 0%    ~     (p=0.937 n=6+6)
Monaco_v14_15_1_emitTime               4.72 ± 1%  4.71 ± 1%    ~     (p=0.937 n=6+6)
Monaco_v14_15_1_totalTime              17.3 ± 1%  17.2 ± 0%    ~     (p=0.818 n=6+6)
TFS_v18_10_0_parseTime                 2.26 ± 1%  2.25 ± 1%    ~     (p=0.180 n=6+6)
TFS_v18_10_0_bindTime                  1.16 ± 1%  1.16 ± 2%    ~     (p=0.240 n=6+6)
TFS_v18_10_0_checkTime                 6.78 ± 1%  6.78 ± 1%    ~     (p=0.974 n=6+6)
TFS_v18_10_0_emitTime                  3.91 ± 1%  3.91 ± 1%    ~     (p=0.738 n=6+6)
TFS_v18_10_0_totalTime                 14.1 ± 1%  14.1 ± 0%    ~     (p=0.699 n=6+6)
TFS_v16_17_1_parseTime                 2.61 ± 3%  2.61 ± 2%    ~     (p=1.000 n=6+6)
TFS_v16_17_1_bindTime                  1.06 ± 3%  1.06 ± 2%    ~     (p=1.000 n=6+6)
TFS_v16_17_1_checkTime                 7.42 ± 1%  7.43 ± 1%    ~     (p=0.937 n=6+6)
TFS_v16_17_1_emitTime                  4.22 ± 1%  4.21 ± 1%    ~     (p=0.937 n=6+6)
TFS_v16_17_1_totalTime                 15.3 ± 1%  15.3 ± 1%    ~     (p=0.894 n=6+6)
TFS_v14_15_1_parseTime                 2.74 ± 1%  2.72 ± 2%    ~     (p=0.240 n=6+6)
TFS_v14_15_1_bindTime                  1.09 ± 2%  1.08 ± 0%    ~     (p=0.177 n=6+5)
TFS_v14_15_1_checkTime                 7.77 ± 0%  7.74 ± 1%    ~     (p=0.143 n=6+6)
TFS_v14_15_1_emitTime                  4.61 ± 2%  4.58 ± 1%    ~     (p=0.394 n=6+6)
TFS_v14_15_1_totalTime                 16.2 ± 0%  16.1 ± 1%  -0.51%  (p=0.026 n=6+6)
material_ui_v18_10_0_parseTime         3.53 ± 1%  3.54 ± 1%    ~     (p=0.818 n=6+6)
material_ui_v18_10_0_bindTime          0.97 ± 1%  0.96 ± 2%    ~     (p=0.420 n=6+6)
material_ui_v18_10_0_checkTime         17.0 ± 0%  16.9 ± 1%    ~     (p=0.082 n=5+6)
material_ui_v18_10_0_emitTime          0.00       0.00         ~     (all equal)
material_ui_v18_10_0_totalTime         21.5 ± 0%  21.4 ± 0%  -0.32%  (p=0.009 n=6+5)
material_ui_v16_17_1_parseTime         3.68 ± 1%  3.67 ± 1%    ~     (p=0.180 n=6+6)
material_ui_v16_17_1_bindTime          1.01 ± 1%  1.01 ± 1%    ~     (p=0.699 n=6+6)
material_ui_v16_17_1_checkTime         18.1 ± 2%  17.9 ± 1%    ~     (p=0.589 n=6+6)
material_ui_v16_17_1_emitTime          0.00       0.00         ~     (all equal)
material_ui_v16_17_1_totalTime         22.8 ± 1%  22.6 ± 1%    ~     (p=0.699 n=6+6)
material_ui_v14_15_1_parseTime         3.90 ± 1%  3.91 ± 1%    ~     (p=1.000 n=6+6)
material_ui_v14_15_1_bindTime          1.05 ± 1%  1.05 ± 2%    ~     (p=0.665 n=6+6)
material_ui_v14_15_1_checkTime         19.0 ± 1%  19.1 ± 1%    ~     (p=0.394 n=6+6)
material_ui_v14_15_1_emitTime          0.00       0.00         ~     (all equal)
material_ui_v14_15_1_totalTime         23.9 ± 1%  24.0 ± 1%    ~     (p=0.240 n=6+6)
xstate_v18_10_0_parseTime              4.43 ± 1%  4.43 ± 1%    ~     (p=0.937 n=6+6)
xstate_v18_10_0_bindTime               1.70 ± 1%  1.70 ± 1%    ~     (p=0.459 n=5+6)
xstate_v18_10_0_checkTime              2.60 ± 1%  2.61 ± 1%    ~     (p=0.699 n=6+6)
xstate_v18_10_0_emitTime               0.08 ± 0%  0.08 ± 0%    ~     (p=0.727 n=6+6)
xstate_v18_10_0_totalTime              8.81 ± 0%  8.81 ± 0%    ~     (p=0.485 n=6+6)
xstate_v16_17_1_parseTime              4.76 ± 0%  4.76 ± 0%    ~     (p=1.000 n=4+4)
xstate_v16_17_1_bindTime               1.66 ± 1%  1.66 ± 1%    ~     (p=0.699 n=6+6)
xstate_v16_17_1_checkTime              2.83 ± 0%  2.83 ± 1%    ~     (p=1.000 n=6+6)
xstate_v16_17_1_emitTime               0.09 ± 0%  0.09 ± 0%    ~     (p=0.429 n=5+6)
xstate_v16_17_1_totalTime              9.34 ± 0%  9.35 ± 0%    ~     (p=0.937 n=6+6)
xstate_v14_15_1_parseTime              5.14 ± 0%  5.12 ± 0%    ~     (p=0.095 n=5+5)
xstate_v14_15_1_bindTime               1.58 ± 0%  1.59 ± 1%    ~     (p=0.420 n=6+6)
xstate_v14_15_1_checkTime              3.00 ± 1%  2.99 ± 1%    ~     (p=0.589 n=6+6)
xstate_v14_15_1_emitTime               0.10 ± 0%  0.10 ± 0%    ~     (p=0.258 n=6+6)
xstate_v14_15_1_totalTime              9.81 ± 1%  9.80 ± 0%    ~     (p=0.937 n=6+6)

weswigham
weswigham approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sourcemap stuff could probably be rewritten to be a generator, provided we'd be okay with some API changes.

@jakebailey
Copy link
Member Author

The sourcemap stuff could probably be rewritten to be a generator, provided we'd be okay with some API changes.

Yeah, I just wasn't confident enough to attempt that in a cleanup PR; it seemed like a bunch of perf testing had gone into producing it, so, I'd want to make sure whatever it ends up as behaves how people expect.

@jakebailey jakebailey changed the title Use native generators/iterables, remove core.ts cruft, fully remove Collection/ReadonlyCollection Use native generators/iterables, remove helper cruft Jan 6, 2023
@jakebailey jakebailey merged commit f1ff0de into microsoft:main Jan 6, 2023
@jakebailey jakebailey deleted the cleanup-1 branch January 6, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees

@jakebailey jakebailey

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakebailey @typescript-bot @weswigham