Apply a contextual type to empty arrays #51882

RyanCavanaugh · 2022-12-13T22:21:03Z

We'll need to discuss this test in particular: https://github.com/microsoft/TypeScript/compare/main...RyanCavanaugh:ctEmptyArrayRetry?expand=1#diff-143cc97a4709c639aa96ddd0c9cac92f3b8a11b104eb5611e0b83c145fdb571a ; I believe the contextual type providing logic is effectively wrong in this case and will try to make a demonstration of such.

Fixes #51853

RyanCavanaugh · 2022-12-13T22:29:46Z

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot user test tsserver
@typescript-bot test tsserver top100
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at eed0acb. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite (tsserver) on this PR at eed0acb. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at eed0acb. You can monitor the build here.

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite (tsserver) on this PR at eed0acb. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the perf test suite on this PR at eed0acb. You can monitor the build here.

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at eed0acb. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-12-13T22:29:48Z

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at eed0acb. You can monitor the build here.

RyanCavanaugh · 2022-12-13T22:31:54Z

@typescript-bot pack this

typescript-bot · 2022-12-13T22:31:56Z

Heya @RyanCavanaugh, I've started to run the tarball bundle task on this PR at eed0acb. You can monitor the build here.

typescript-bot · 2022-12-13T22:34:07Z

Hey @RyanCavanaugh, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/140386/artifacts?artifactName=tgz&fileId=F6AAD7F5EB710C3771E32C2F0B84BF0D18775E64858DC65CEDC499B45BF1DC4902&fileName=/typescript-5.0.0-insiders.20221213.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.0.0-pr-51882-10".;

typescript-bot · 2022-12-13T22:39:24Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/51882/merge:

Everything looks good!

typescript-bot · 2022-12-13T22:42:14Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/51882/merge:

Everything looks good!

typescript-bot · 2022-12-13T22:50:33Z

Heya @RyanCavanaugh, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2022-12-13T23:55:58Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/51882/merge:

Everything looks good!

typescript-bot · 2022-12-14T00:12:44Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/51882/merge:

Something interesting changed - please have a look.

Details

felixrieseberg/windows95

⚠️ Note that built also had errors ⚠️

Req #441 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:158985:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:159992:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:159989:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160036:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161647:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163033:14)

Req #441 - references
    at formatMessage2 (/typescript-51882/built/local/tsserver.js:159004:21)
    at IOSession.writeMessage (/typescript-51882/built/local/tsserver.js:160011:21)
    at IOSession.send (/typescript-51882/built/local/tsserver.js:160008:10)
    at IOSession.doOutput (/typescript-51882/built/local/tsserver.js:160055:10)
    at IOSession.onMessage (/typescript-51882/built/local/tsserver.js:161666:14)
    at Interface.<anonymous> (/typescript-51882/built/local/tsserver.js:163052:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/felixrieseberg.windows95.rawError.txt in the artifact folder

Last few requests

{"seq":438,"type":"request","command":"definitionAndBoundSpan","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":95588}}
{"seq":439,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":96407,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":440,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":96407,"entryNames":["_"]}}
{"seq":441,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/src/renderer/lib/_libwabt.js","line":13,"offset":97382}}

Repro Steps

git clone https://github.com/felixrieseberg/windows95 --recurse-submodules
In dir windows95, run git reset --hard 17a81393467e2668eb2eea291ab4b6a749756dad
In dir windows95, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/felixrieseberg.windows95.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./windows95 ./felixrieseberg.windows95.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

palantir/blueprint

⚠️ Note that built also had errors ⚠️

Req #12600 - references
    at formatMessage2 (/typescript-main/built/local/tsserver.js:158985:21)
    at IOSession.writeMessage (/typescript-main/built/local/tsserver.js:159992:21)
    at IOSession.send (/typescript-main/built/local/tsserver.js:159989:10)
    at IOSession.doOutput (/typescript-main/built/local/tsserver.js:160036:10)
    at IOSession.onMessage (/typescript-main/built/local/tsserver.js:161647:14)
    at Interface.<anonymous> (/typescript-main/built/local/tsserver.js:163033:14)

Req #12600 - references
    at formatMessage2 (/typescript-51882/built/local/tsserver.js:159004:21)
    at IOSession.writeMessage (/typescript-51882/built/local/tsserver.js:160011:21)
    at IOSession.send (/typescript-51882/built/local/tsserver.js:160008:10)
    at IOSession.doOutput (/typescript-51882/built/local/tsserver.js:160055:10)
    at IOSession.onMessage (/typescript-51882/built/local/tsserver.js:161666:14)
    at Interface.<anonymous> (/typescript-51882/built/local/tsserver.js:163052:14)

That is a filtered view of the text. To see the raw error text, go to RepoResults4/palantir.blueprint.rawError.txt in the artifact folder

Last few requests

{"seq":12597,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":245891,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":2,"triggerCharacter":" "}}
{"seq":12598,"type":"request","command":"completionInfo","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":246033,"includeExternalModuleExports":false,"includeInsertTextCompletions":true,"triggerKind":1}}
{"seq":12599,"type":"request","command":"completionEntryDetails","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":246033,"entryNames":["arguments"]}}
{"seq":12600,"type":"request","command":"references","arguments":{"file":"@PROJECT_ROOT@/site/docs/versions/1/docs-app.js","line":1,"offset":246480}}

Repro Steps

git clone https://github.com/palantir/blueprint --recurse-submodules
In dir blueprint, run git reset --hard b6c1518ea2f524accfba8045ce6f22cac7c5b56e
In dir blueprint, run yarn install --ignore-engines --ignore-scripts --silent
Back in the initial folder, download RepoResults4/palantir.blueprint.replay.txt from the artifact folder
npm install --no-save @typescript/server-replay
npx tsreplay ./blueprint ./palantir.blueprint.replay.txt path/to/tsserver.js
npx tsreplay --help to learn about helpful switches for debugging, logging, etc

Mifrill · 2023-11-20T22:09:05Z

tests/baselines/reference/arrayContextualTyping.symbols

+>isCustom : Symbol(MyCustomArray.isCustom, Decl(arrayContextualTyping.ts, 1, 51))
+}


@RyanCavanaugh Could you please clarify what is the purpose of this isCustom property? Looking at this, it seems to me like it is a condition to run a different set of tests, if so it does not seem like a good practice to have conditional tests.

RyanCavanaugh and others added 2 commits December 12, 2022 21:28

WIP

7d7750d

Update baselines

a34c556

typescript-bot assigned RyanCavanaugh Dec 13, 2022

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Dec 13, 2022

Lint

eed0acb

sandersn added this to Not started in PR Backlog Dec 22, 2022

sandersn added the Experiment A fork with an experimental idea which might not make it into master label Dec 23, 2022

sandersn removed this from Not started in PR Backlog Dec 23, 2022

Mifrill reviewed Nov 20, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply a contextual type to empty arrays #51882

Apply a contextual type to empty arrays #51882

RyanCavanaugh commented Dec 13, 2022

RyanCavanaugh commented Dec 13, 2022

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

RyanCavanaugh commented Dec 13, 2022

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 14, 2022

felixrieseberg/windows95

Last few requests

Repro Steps

palantir/blueprint

Last few requests

Repro Steps

Mifrill Nov 20, 2023

		>isCustom : Symbol(MyCustomArray.isCustom, Decl(arrayContextualTyping.ts, 1, 51))
		}

Apply a contextual type to empty arrays #51882

Are you sure you want to change the base?

Apply a contextual type to empty arrays #51882

Conversation

RyanCavanaugh commented Dec 13, 2022

RyanCavanaugh commented Dec 13, 2022

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

RyanCavanaugh commented Dec 13, 2022

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022 • edited

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 13, 2022

typescript-bot commented Dec 14, 2022

felixrieseberg/windows95

Last few requests

Repro Steps

palantir/blueprint

Last few requests

Repro Steps

Mifrill Nov 20, 2023

Choose a reason for hiding this comment

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited

typescript-bot commented Dec 13, 2022 •

edited