Fix isUnitLikeType to (again) handle tagged literal types #51545

ahejlsberg · 2022-11-16T01:46:58Z

ahejlsberg · 2022-11-16T01:47:51Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2022-11-16T01:47:53Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 3b392d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-11-16T01:47:53Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 3b392d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-11-16T01:47:53Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 3b392d9. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-11-16T01:47:53Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 3b392d9. You can monitor the build here.

typescript-bot · 2022-11-16T01:47:53Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 3b392d9. You can monitor the build here.

typescript-bot · 2022-11-16T02:00:49Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/51545/merge:

Everything looks good!

typescript-bot · 2022-11-16T02:41:40Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..51545

_Metric	_main	₅₁₅₄₅	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{340,529k (± 0.03%)}	_{340,572k (± 0.02%)}	_{+43k (+ 0.01%)}	_340,403k	_340,664k
_{Parse Time}	_{1.88s (± 0.90%)}	_{1.89s (± 0.43%)}	_{+0.01s (+ 0.53%)}	_1.87s	_1.91s
_{Bind Time}	_{0.65s (± 0.56%)}	_{0.65s (± 0.69%)}	_{+0.00s (+ 0.31%)}	_0.64s	_0.66s
_{Check Time}	_{5.17s (± 0.47%)}	_{5.17s (± 0.40%)}	_{-0.00s (- 0.02%)}	_5.12s	_5.21s
_{Emit Time}	_{5.12s (± 0.75%)}	_{5.10s (± 0.75%)}	_{-0.02s (- 0.29%)}	_5.02s	_5.19s
_{Total Time}	_{12.81s (± 0.48%)}	_{12.81s (± 0.30%)}	_{-0.00s (- 0.02%)}	_12.74s	_12.91s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{187,890k (± 0.63%)}	_{187,575k (± 0.60%)}	_{-315k (- 0.17%)}	_186,470k	_189,963k
_{Parse Time}	_{0.79s (± 0.63%)}	_{0.80s (± 1.06%)}	_{+0.01s (+ 1.78%)}	_0.78s	_0.81s
_{Bind Time}	_{0.42s (± 1.23%)}	_{0.42s (± 1.06%)}	_{+0.00s (+ 0.24%)}	_0.41s	_0.43s
_{Check Time}	_{6.00s (± 0.96%)}	_{6.04s (± 0.38%)}	_{+0.03s (+ 0.53%)}	_5.96s	_6.08s
_{Emit Time}	_{1.89s (± 0.92%)}	_{1.91s (± 0.86%)}	_{+0.02s (+ 1.22%)}	_1.88s	_1.94s
_{Total Time}	_{9.10s (± 0.79%)}	_{9.17s (± 0.34%)}	_{+0.07s (+ 0.73%)}	_9.10s	_9.24s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{319,830k (± 0.01%)}	_{319,824k (± 0.01%)}	_{-6k (- 0.00%)}	_319,740k	_319,915k
_{Parse Time}	_{1.43s (± 0.66%)}	_{1.42s (± 0.37%)}	_{-0.01s (- 0.42%)}	_1.41s	_1.43s
_{Bind Time}	_{0.59s (± 0.57%)}	_{0.59s (± 0.94%)}	_{-0.00s (- 0.17%)}	_0.58s	_0.60s
_{Check Time}	_{4.87s (± 0.54%)}	_{4.88s (± 0.39%)}	_{+0.01s (+ 0.14%)}	_4.82s	_4.91s
_{Emit Time}	_{2.73s (± 0.61%)}	_{2.72s (± 0.88%)}	_{-0.00s (- 0.15%)}	_2.65s	_2.78s
_{Total Time}	_{9.62s (± 0.47%)}	_{9.62s (± 0.43%)}	_{-0.00s (- 0.03%)}	_9.51s	_9.71s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{282,277k (± 0.02%)}	_{282,297k (± 0.01%)}	_{+20k (+ 0.01%)}	_282,247k	_282,318k
_{Parse Time}	_{1.17s (± 0.76%)}	_{1.16s (± 0.80%)}	_{-0.00s (- 0.34%)}	_1.15s	_1.19s
_{Bind Time}	_{0.66s (± 3.85%)}	_{0.63s (± 4.36%)}	_{🟩-0.03s (- 4.82%)}	_0.59s	_0.69s
_{Check Time}	_{4.74s (± 0.44%)}	_{4.76s (± 0.30%)}	_{+0.02s (+ 0.32%)}	_4.73s	_4.79s
_{Emit Time}	_{2.75s (± 2.15%)}	_{2.75s (± 1.89%)}	_{-0.00s (- 0.18%)}	_2.68s	_2.87s
_{Total Time}	_{9.32s (± 0.70%)}	_{9.30s (± 0.69%)}	_{-0.03s (- 0.29%)}	_9.17s	_9.44s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{435,269k (± 0.00%)}	_{435,284k (± 0.01%)}	_{+16k (+ 0.00%)}	_435,214k	_435,343k
_{Parse Time}	_{1.64s (± 0.68%)}	_{1.65s (± 0.45%)}	_{+0.01s (+ 0.73%)}	_1.63s	_1.66s
_{Bind Time}	_{0.50s (± 1.33%)}	_{0.50s (± 0.66%)}	_{-0.00s (- 0.60%)}	_0.49s	_0.51s
_{Check Time}	_{11.84s (± 0.70%)}	_{11.86s (± 0.93%)}	_{+0.02s (+ 0.18%)}	_11.72s	_12.17s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{13.98s (± 0.65%)}	_{14.01s (± 0.83%)}	_{+0.03s (+ 0.24%)}	_13.86s	_14.33s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{515,972k (± 0.01%)}	_{515,978k (± 0.01%)}	_{+7k (+ 0.00%)}	_515,919k	_516,067k
_{Parse Time}	_{2.31s (± 0.39%)}	_{2.32s (± 0.48%)}	_{+0.01s (+ 0.35%)}	_2.29s	_2.34s
_{Bind Time}	_{0.84s (± 1.94%)}	_{0.83s (± 1.06%)}	_{-0.01s (- 0.83%)}	_0.82s	_0.86s
_{Check Time}	_{1.36s (± 0.83%)}	_{1.35s (± 0.78%)}	_{-0.01s (- 0.59%)}	_1.33s	_1.38s
_{Emit Time}	_{0.06s (± 0.00%)}	_{0.06s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.06s	_0.06s
_{Total Time}	_{4.57s (± 0.48%)}	_{4.57s (± 0.37%)}	_{-0.00s (- 0.07%)}	_4.54s	_4.62s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-131-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₁₅₄₅	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-11-16T03:11:41Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/51545/merge:

Everything looks good!

ahejlsberg · 2022-11-16T14:10:50Z

Tests and performance are unaffected. This should be good to merge.

DanielRosenwasser · 2022-11-17T00:58:59Z

I'll try, but this probably can't be automatically cherry-picked.

@typescript-bot cherry-pick this to release-4.9

It will probably fail - if it does, would you be able to send a PR with the test and change for release-4.9?

typescript-bot · 2022-11-17T00:59:03Z

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.9 on this PR at 3b392d9. You can monitor the build here.

typescript-bot · 2022-11-17T01:04:35Z

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.9 manually.

DanielRosenwasser · 2022-11-28T19:23:29Z

tests/cases/conformance/types/unknown/unknownControlFlow.ts

+    throw new Error('never');
+}
+
+function fx20(value: Either) {


I feel like I'm having deja vu and I've asked this question, but why is this test in a file called unknownControlFlow.ts?

You did indeed: #51076 (comment). The test is in that file for the same reason.

DanielRosenwasser · 2022-12-02T22:48:08Z

Pick is in 4.9 with b4d382b.

ahejlsberg added 2 commits November 15, 2022 17:35

Fix isUnitLikeType to (again) handle tagged literal types

e98bf8c

Add regression test

3b392d9

typescript-bot assigned ahejlsberg Nov 16, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Nov 16, 2022

RyanCavanaugh approved these changes Nov 16, 2022

View reviewed changes

DanielRosenwasser reviewed Nov 28, 2022

View reviewed changes

ahejlsberg merged commit 8036b14 into main Nov 30, 2022

ahejlsberg deleted the fix51538 branch November 30, 2022 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix isUnitLikeType to (again) handle tagged literal types #51545

Fix isUnitLikeType to (again) handle tagged literal types #51545

ahejlsberg commented Nov 16, 2022

ahejlsberg commented Nov 16, 2022

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022

typescript-bot commented Nov 16, 2022

typescript-bot commented Nov 16, 2022

ahejlsberg commented Nov 16, 2022

DanielRosenwasser commented Nov 17, 2022

typescript-bot commented Nov 17, 2022 •

edited

typescript-bot commented Nov 17, 2022

DanielRosenwasser Nov 28, 2022

ahejlsberg Nov 30, 2022

DanielRosenwasser commented Dec 2, 2022

Fix isUnitLikeType to (again) handle tagged literal types #51545

Fix isUnitLikeType to (again) handle tagged literal types #51545

Conversation

ahejlsberg commented Nov 16, 2022

ahejlsberg commented Nov 16, 2022

typescript-bot commented Nov 16, 2022 • edited

typescript-bot commented Nov 16, 2022 • edited

typescript-bot commented Nov 16, 2022 • edited

typescript-bot commented Nov 16, 2022 • edited

typescript-bot commented Nov 16, 2022 • edited

typescript-bot commented Nov 16, 2022

typescript-bot commented Nov 16, 2022

typescript-bot commented Nov 16, 2022

ahejlsberg commented Nov 16, 2022

DanielRosenwasser commented Nov 17, 2022

typescript-bot commented Nov 17, 2022 • edited

typescript-bot commented Nov 17, 2022

DanielRosenwasser Nov 28, 2022

Choose a reason for hiding this comment

ahejlsberg Nov 30, 2022

Choose a reason for hiding this comment

DanielRosenwasser commented Dec 2, 2022

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 16, 2022 •

edited

typescript-bot commented Nov 17, 2022 •

edited