Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform decorators containing private field references into a 'static {}` block #50071

Closed
wants to merge 1 commit into from
Closed

Transform decorators containing private field references into a 'static {}` block #50071

wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Member

This is a WIP investigation into potential compiler performance regressions that could arise from conditionally moving decorator evaluation into a static {} block when a decorator contains a private field reference.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 27, 2022
@rbuckton
Copy link
Member Author

@typescript-bot perf test

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 27, 2022 •
edited

Heya @rbuckton, I've started to run the perf test suite on this PR at 6034e95. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..50071
Metric main 50071 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 360,250k (± 0.02%) 360,322k (± 0.02%) +72k (+ 0.02%) 360,136k 360,508k
Parse Time 2.10s (± 0.53%) 2.11s (± 0.72%) +0.01s (+ 0.62%) 2.09s 2.15s
Bind Time 0.90s (± 1.77%) 0.89s (± 0.84%) -0.01s (- 1.11%) 0.88s 0.91s
Check Time 6.04s (± 0.48%) 6.02s (± 0.25%) -0.02s (- 0.27%) 5.98s 6.05s
Emit Time 6.18s (± 0.61%) 6.21s (± 0.41%) +0.03s (+ 0.55%) 6.15s 6.27s
Total Time 15.22s (± 0.52%) 15.24s (± 0.26%) +0.02s (+ 0.13%) 15.15s 15.33s
Compiler-Unions - node (v10.16.3, x64)
Memory used 206,961k (± 0.04%) 207,043k (± 0.03%) +82k (+ 0.04%) 206,938k 207,236k
Parse Time 0.84s (± 0.80%) 0.84s (± 1.01%) +0.00s (+ 0.24%) 0.82s 0.85s
Bind Time 0.53s (± 0.94%) 0.53s (± 1.63%) +0.01s (+ 1.14%) 0.52s 0.55s
Check Time 7.18s (± 0.66%) 7.17s (± 0.67%) -0.02s (- 0.25%) 7.05s 7.27s
Emit Time 2.52s (± 1.07%) 2.53s (± 0.74%) +0.01s (+ 0.56%) 2.49s 2.57s
Total Time 11.06s (± 0.57%) 11.07s (± 0.50%) +0.01s (+ 0.05%) 10.93s 11.18s
Monaco - node (v10.16.3, x64)
Memory used 343,915k (± 0.02%) 343,876k (± 0.02%) -39k (- 0.01%) 343,695k 343,983k
Parse Time 1.60s (± 0.52%) 1.61s (± 0.40%) +0.01s (+ 0.50%) 1.60s 1.63s
Bind Time 0.76s (± 0.90%) 0.76s (± 0.68%) +0.00s (+ 0.40%) 0.75s 0.77s
Check Time 6.02s (± 0.27%) 5.99s (± 0.64%) -0.02s (- 0.37%) 5.91s 6.09s
Emit Time 3.28s (± 0.89%) 3.28s (± 0.75%) -0.00s (- 0.06%) 3.20s 3.32s
Total Time 11.66s (± 0.39%) 11.64s (± 0.51%) -0.02s (- 0.15%) 11.50s 11.78s
TFS - node (v10.16.3, x64)
Memory used 305,162k (± 0.03%) 305,145k (± 0.02%) -16k (- 0.01%) 304,968k 305,290k
Parse Time 1.29s (± 0.35%) 1.29s (± 0.43%) 0.00s ( 0.00%) 1.28s 1.30s
Bind Time 0.72s (± 0.77%) 0.72s (± 0.81%) -0.00s (- 0.14%) 0.71s 0.73s
Check Time 5.46s (± 0.65%) 5.45s (± 0.36%) -0.01s (- 0.18%) 5.40s 5.49s
Emit Time 3.45s (± 0.93%) 3.48s (± 1.02%) +0.03s (+ 0.75%) 3.42s 3.59s
Total Time 10.92s (± 0.31%) 10.94s (± 0.40%) +0.02s (+ 0.16%) 10.85s 11.02s
material-ui - node (v10.16.3, x64)
Memory used 469,391k (± 0.01%) 469,416k (± 0.01%) +24k (+ 0.01%) 469,336k 469,557k
Parse Time 1.84s (± 0.66%) 1.84s (± 0.58%) -0.01s (- 0.27%) 1.82s 1.87s
Bind Time 0.69s (± 1.53%) 0.70s (± 0.83%) +0.01s (+ 1.46%) 0.68s 0.71s
Check Time 14.61s (± 0.58%) 14.65s (± 0.43%) +0.04s (+ 0.27%) 14.50s 14.78s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 17.14s (± 0.50%) 17.19s (± 0.39%) +0.05s (+ 0.29%) 17.03s 17.32s
xstate - node (v10.16.3, x64)
Memory used 581,428k (± 1.27%) 578,295k (± 0.02%) -3,133k (- 0.54%) 578,048k 578,492k
Parse Time 2.61s (± 0.39%) 2.63s (± 0.26%) +0.02s (+ 0.77%) 2.61s 2.64s
Bind Time 1.04s (± 1.73%) 1.03s (± 1.12%) -0.00s (- 0.10%) 1.01s 1.06s
Check Time 1.57s (± 0.63%) 1.57s (± 0.66%) +0.00s (+ 0.13%) 1.55s 1.59s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.27s (± 0.45%) 5.30s (± 0.22%) +0.02s (+ 0.44%) 5.27s 5.33s
Angular - node (v12.1.0, x64)
Memory used 337,833k (± 0.01%) 337,824k (± 0.02%) -9k (- 0.00%) 337,674k 337,995k
Parse Time 2.08s (± 0.51%) 2.09s (± 0.69%) +0.01s (+ 0.43%) 2.07s 2.13s
Bind Time 0.86s (± 0.43%) 0.86s (± 1.28%) +0.01s (+ 0.94%) 0.85s 0.90s
Check Time 5.83s (± 0.69%) 5.84s (± 0.34%) +0.02s (+ 0.27%) 5.80s 5.88s
Emit Time 6.40s (± 0.89%) 6.43s (± 0.61%) +0.03s (+ 0.52%) 6.35s 6.51s
Total Time 15.17s (± 0.64%) 15.23s (± 0.42%) +0.06s (+ 0.43%) 15.11s 15.38s
Compiler-Unions - node (v12.1.0, x64)
Memory used 194,417k (± 0.15%) 194,590k (± 0.04%) +174k (+ 0.09%) 194,456k 194,731k
Parse Time 0.82s (± 0.72%) 0.82s (± 0.72%) 0.00s ( 0.00%) 0.81s 0.84s
Bind Time 0.55s (± 0.81%) 0.55s (± 0.95%) +0.00s (+ 0.18%) 0.54s 0.56s
Check Time 6.73s (± 0.77%) 6.71s (± 0.43%) -0.02s (- 0.25%) 6.67s 6.79s
Emit Time 2.55s (± 1.02%) 2.54s (± 1.08%) -0.02s (- 0.67%) 2.49s 2.61s
Total Time 10.66s (± 0.57%) 10.62s (± 0.40%) -0.03s (- 0.33%) 10.55s 10.71s
Monaco - node (v12.1.0, x64)
Memory used 326,815k (± 0.01%) 326,887k (± 0.01%) +72k (+ 0.02%) 326,781k 326,991k
Parse Time 1.57s (± 0.74%) 1.58s (± 0.79%) +0.01s (+ 0.70%) 1.55s 1.61s
Bind Time 0.74s (± 0.54%) 0.74s (± 1.28%) +0.00s (+ 0.40%) 0.73s 0.77s
Check Time 5.81s (± 0.60%) 5.82s (± 0.24%) +0.01s (+ 0.12%) 5.79s 5.86s
Emit Time 3.30s (± 0.85%) 3.31s (± 0.56%) +0.01s (+ 0.42%) 3.26s 3.36s
Total Time 11.42s (± 0.61%) 11.45s (± 0.32%) +0.03s (+ 0.27%) 11.36s 11.54s
TFS - node (v12.1.0, x64)
Memory used 289,755k (± 0.02%) 289,819k (± 0.02%) +64k (+ 0.02%) 289,662k 289,934k
Parse Time 1.31s (± 0.76%) 1.30s (± 0.72%) -0.01s (- 0.53%) 1.29s 1.33s
Bind Time 0.72s (± 1.11%) 0.72s (± 0.77%) 0.00s ( 0.00%) 0.71s 0.73s
Check Time 5.39s (± 0.60%) 5.37s (± 0.64%) -0.01s (- 0.24%) 5.30s 5.48s
Emit Time 3.53s (± 0.63%) 3.53s (± 0.63%) +0.00s (+ 0.11%) 3.49s 3.59s
Total Time 10.94s (± 0.46%) 10.93s (± 0.52%) -0.01s (- 0.11%) 10.81s 11.11s
material-ui - node (v12.1.0, x64)
Memory used 448,541k (± 0.02%) 448,585k (± 0.01%) +45k (+ 0.01%) 448,483k 448,727k
Parse Time 1.83s (± 0.54%) 1.83s (± 0.46%) +0.00s (+ 0.05%) 1.81s 1.85s
Bind Time 0.67s (± 0.51%) 0.68s (± 0.88%) +0.00s (+ 0.45%) 0.67s 0.69s
Check Time 13.12s (± 0.82%) 13.15s (± 0.48%) +0.03s (+ 0.20%) 12.98s 13.30s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.62s (± 0.72%) 15.66s (± 0.44%) +0.03s (+ 0.20%) 15.50s 15.84s
xstate - node (v12.1.0, x64)
Memory used 543,610k (± 0.01%) 543,726k (± 0.02%) +115k (+ 0.02%) 543,458k 544,013k
Parse Time 2.54s (± 0.37%) 2.55s (± 0.45%) +0.01s (+ 0.28%) 2.52s 2.58s
Bind Time 1.03s (± 1.44%) 1.02s (± 1.09%) -0.00s (- 0.49%) 1.00s 1.05s
Check Time 1.50s (± 0.50%) 1.51s (± 0.55%) +0.01s (+ 0.40%) 1.49s 1.53s
Emit Time 0.07s (± 0.00%) 0.07s (± 0.00%) 0.00s ( 0.00%) 0.07s 0.07s
Total Time 5.15s (± 0.27%) 5.16s (± 0.36%) +0.01s (+ 0.19%) 5.11s 5.20s
Angular - node (v14.15.1, x64)
Memory used 335,988k (± 0.01%) 336,016k (± 0.01%) +28k (+ 0.01%) 335,969k 336,047k
Parse Time 2.06s (± 0.61%) 2.07s (± 0.84%) +0.01s (+ 0.48%) 2.05s 2.13s
Bind Time 0.89s (± 0.93%) 0.90s (± 0.62%) +0.00s (+ 0.45%) 0.89s 0.91s
Check Time 5.81s (± 0.46%) 5.85s (± 0.56%) +0.05s (+ 0.78%) 5.79s 5.92s
Emit Time 6.35s (± 0.43%) 6.40s (± 0.39%) +0.04s (+ 0.71%) 6.33s 6.44s
Total Time 15.12s (± 0.35%) 15.22s (± 0.36%) +0.10s (+ 0.67%) 15.12s 15.32s
Compiler-Unions - node (v14.15.1, x64)
Memory used 193,137k (± 0.01%) 193,148k (± 0.01%) +12k (+ 0.01%) 193,092k 193,204k
Parse Time 0.85s (± 0.78%) 0.85s (± 0.40%) +0.00s (+ 0.35%) 0.85s 0.86s
Bind Time 0.57s (± 1.23%) 0.57s (± 0.58%) -0.00s (- 0.18%) 0.56s 0.58s
Check Time 6.73s (± 0.33%) 6.78s (± 0.81%) +0.05s (+ 0.74%) 6.68s 6.93s
Emit Time 2.47s (± 0.41%) 2.50s (± 1.06%) +0.03s (+ 1.05%) 2.46s 2.57s
Total Time 10.62s (± 0.23%) 10.70s (± 0.73%) +0.08s (+ 0.76%) 10.58s 10.91s
Monaco - node (v14.15.1, x64)
Memory used 325,657k (± 0.01%) 325,680k (± 0.01%) +24k (+ 0.01%) 325,632k 325,717k
Parse Time 1.58s (± 0.73%) 1.58s (± 0.42%) -0.00s (- 0.32%) 1.56s 1.59s
Bind Time 0.78s (± 0.93%) 0.79s (± 0.60%) +0.01s (+ 0.64%) 0.78s 0.80s
Check Time 5.69s (± 0.42%) 5.69s (± 0.33%) -0.00s (- 0.00%) 5.65s 5.73s
Emit Time 3.35s (± 0.66%) 3.36s (± 0.74%) +0.01s (+ 0.18%) 3.33s 3.43s
Total Time 11.41s (± 0.39%) 11.41s (± 0.28%) +0.00s (+ 0.04%) 11.34s 11.48s
TFS - node (v14.15.1, x64)
Memory used 288,811k (± 0.01%) 288,844k (± 0.01%) +34k (+ 0.01%) 288,793k 288,931k
Parse Time 1.36s (± 2.23%) 1.34s (± 1.36%) -0.01s (- 1.03%) 1.30s 1.38s
Bind Time 0.74s (± 1.22%) 0.75s (± 3.10%) +0.01s (+ 0.94%) 0.73s 0.84s
Check Time 5.36s (± 0.48%) 5.35s (± 0.60%) -0.01s (- 0.24%) 5.28s 5.43s
Emit Time 3.59s (± 2.11%) 3.61s (± 1.56%) +0.02s (+ 0.56%) 3.49s 3.70s
Total Time 11.05s (± 0.80%) 11.05s (± 0.52%) +0.00s (+ 0.01%) 10.93s 11.16s
material-ui - node (v14.15.1, x64)
Memory used 446,697k (± 0.01%) 446,752k (± 0.01%) +54k (+ 0.01%) 446,709k 446,817k
Parse Time 1.88s (± 0.72%) 1.88s (± 0.77%) +0.00s (+ 0.00%) 1.85s 1.92s
Bind Time 0.72s (± 0.77%) 0.72s (± 0.80%) +0.00s (+ 0.28%) 0.71s 0.73s
Check Time 13.14s (± 0.59%) 13.24s (± 0.67%) +0.10s (+ 0.77%) 13.07s 13.50s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.74s (± 0.47%) 15.85s (± 0.58%) +0.11s (+ 0.67%) 15.67s 16.12s
xstate - node (v14.15.1, x64)
Memory used 541,519k (± 0.00%) 541,590k (± 0.00%) +71k (+ 0.01%) 541,552k 541,634k
Parse Time 2.61s (± 0.48%) 2.62s (± 0.45%) +0.01s (+ 0.34%) 2.59s 2.64s
Bind Time 1.15s (± 0.87%) 1.15s (± 0.87%) -0.00s (- 0.35%) 1.13s 1.18s
Check Time 1.56s (± 0.67%) 1.56s (± 0.61%) -0.00s (- 0.06%) 1.54s 1.57s
Emit Time 0.07s (± 4.13%) 0.08s (± 3.81%) +0.01s (+ 8.33%) 0.07s 0.08s
Total Time 5.40s (± 0.30%) 5.40s (± 0.31%) +0.00s (+ 0.06%) 5.37s 5.43s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v10.16.3, x64)
  • xstate - node (v12.1.0, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50071 10
Baseline main 10

TSServer

Comparison Report - main..50071
Metric main 50071 Delta Best Worst
Compiler-UnionsTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,455ms (± 0.53%) 1,462ms (± 0.71%) +7ms (+ 0.47%) 1,438ms 1,483ms
Req 2 - geterr 3,614ms (± 0.59%) 3,627ms (± 0.44%) +13ms (+ 0.36%) 3,593ms 3,662ms
Req 3 - references 277ms (± 0.74%) 278ms (± 0.78%) +1ms (+ 0.47%) 271ms 281ms
Req 4 - navto 231ms (± 0.65%) 234ms (± 0.38%) +3ms (+ 1.38%) 232ms 236ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 69ms (± 8.82%) 70ms (± 7.62%) +1ms (+ 1.30%) 62ms 89ms
CompilerTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 1,557ms (± 0.44%) 1,557ms (± 0.42%) +0ms (+ 0.03%) 1,543ms 1,570ms
Req 2 - geterr 2,264ms (± 0.59%) 2,277ms (± 0.49%) +13ms (+ 0.57%) 2,241ms 2,303ms
Req 3 - references 297ms (± 1.23%) 296ms (± 0.80%) -1ms (- 0.27%) 292ms 303ms
Req 4 - navto 239ms (± 1.77%) 240ms (± 1.51%) +1ms (+ 0.54%) 229ms 246ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 66ms (± 2.97%) 67ms (± 3.38%) +1ms (+ 2.14%) 62ms 71ms
xstateTSServer - node (v10.16.3, x64)
Req 1 - updateOpen 2,160ms (± 0.33%) 2,172ms (± 0.51%) +12ms (+ 0.57%) 2,145ms 2,205ms
Req 2 - geterr 772ms (± 0.48%) 776ms (± 0.63%) +4ms (+ 0.47%) 761ms 787ms
Req 3 - references 96ms (± 1.00%) 96ms (± 1.58%) +1ms (+ 0.84%) 93ms 101ms
Req 4 - navto 253ms (± 0.72%) 257ms (± 1.78%) +4ms (+ 1.38%) 247ms 272ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 272ms (± 0.92%) 275ms (± 1.45%) +3ms (+ 1.10%) 264ms 283ms
Compiler-UnionsTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,471ms (± 0.59%) 1,476ms (± 0.69%) +5ms (+ 0.33%) 1,450ms 1,497ms
Req 2 - geterr 3,388ms (± 0.62%) 3,408ms (± 0.59%) +20ms (+ 0.59%) 3,372ms 3,458ms
Req 3 - references 263ms (± 0.43%) 264ms (± 0.65%) +2ms (+ 0.57%) 259ms 268ms
Req 4 - navto 205ms (± 0.86%) 205ms (± 0.80%) 0ms ( 0.00%) 201ms 209ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 77ms (±17.23%) 77ms (±13.75%) +0ms (+ 0.52%) 59ms 94ms
CompilerTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 1,568ms (± 0.65%) 1,569ms (± 0.73%) +0ms (+ 0.01%) 1,539ms 1,593ms
Req 2 - geterr 2,219ms (± 0.63%) 2,212ms (± 0.34%) -6ms (- 0.28%) 2,187ms 2,222ms
Req 3 - references 274ms (± 0.82%) 274ms (± 0.73%) -0ms (- 0.15%) 268ms 279ms
Req 4 - navto 216ms (± 1.26%) 214ms (± 0.90%) -2ms (- 0.70%) 211ms 219ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 63ms (± 2.78%) 64ms (± 3.13%) +1ms (+ 1.26%) 58ms 67ms
xstateTSServer - node (v12.1.0, x64)
Req 1 - updateOpen 2,084ms (± 0.39%) 2,100ms (± 0.69%) +15ms (+ 0.74%) 2,066ms 2,133ms
Req 2 - geterr 759ms (± 0.54%) 765ms (± 0.66%) +6ms (+ 0.82%) 754ms 780ms
Req 3 - references 66ms (± 1.43%) 66ms (± 1.37%) -0ms (- 0.30%) 64ms 67ms
Req 4 - navto 241ms (± 0.92%) 241ms (± 1.85%) -0ms (- 0.17%) 230ms 250ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 262ms (± 0.91%) 262ms (± 1.17%) +0ms (+ 0.08%) 255ms 268ms
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,524ms (± 0.53%) 1,521ms (± 0.37%) -3ms (- 0.20%) 1,509ms 1,536ms
Req 2 - geterr 3,537ms (± 0.70%) 3,531ms (± 0.45%) -6ms (- 0.17%) 3,492ms 3,561ms
Req 3 - references 275ms (± 0.50%) 276ms (± 0.55%) +1ms (+ 0.18%) 272ms 280ms
Req 4 - navto 218ms (± 0.76%) 219ms (± 0.47%) +1ms (+ 0.27%) 217ms 221ms
Req 5 - completionInfo count 1,355 (± 0.00%) 1,355 (± 0.00%) 0 ( 0.00%) 1,355 1,355
Req 5 - completionInfo 59ms (± 7.06%) 57ms (± 6.53%) -1ms (- 2.05%) 53ms 69ms
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 1,603ms (± 0.48%) 1,604ms (± 0.53%) +1ms (+ 0.05%) 1,586ms 1,617ms
Req 2 - geterr 2,341ms (± 0.34%) 2,350ms (± 0.55%) +9ms (+ 0.39%) 2,324ms 2,374ms
Req 3 - references 288ms (± 1.24%) 288ms (± 0.84%) -0ms (- 0.10%) 282ms 292ms
Req 4 - navto 230ms (± 0.67%) 235ms (± 2.58%) +6ms (+ 2.40%) 227ms 249ms
Req 5 - completionInfo count 1,517 (± 0.00%) 1,517 (± 0.00%) 0 ( 0.00%) 1,517 1,517
Req 5 - completionInfo 53ms (± 1.09%) 53ms (± 0.98%) -0ms (- 0.19%) 52ms 54ms
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,227ms (± 0.50%) 2,240ms (± 0.53%) +13ms (+ 0.57%) 2,213ms 2,266ms
Req 2 - geterr 775ms (± 0.37%) 779ms (± 0.69%) +4ms (+ 0.55%) 765ms 789ms
Req 3 - references 64ms (± 0.73%) 69ms (±10.56%) +5ms (+ 7.97%) 63ms 98ms
Req 4 - navto 250ms (± 0.33%) 252ms (± 0.79%) +2ms (+ 0.80%) 249ms 256ms
Req 5 - completionInfo count 3,244 (± 0.00%) 3,244 (± 0.00%) 0 ( 0.00%) 3,244 3,244
Req 5 - completionInfo 263ms (± 0.67%) 267ms (± 0.89%) +4ms (+ 1.56%) 264ms 274ms
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v10.16.3, x64)
  • Compiler-UnionsTSServer - node (v12.1.0, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v10.16.3, x64)
  • CompilerTSServer - node (v12.1.0, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v10.16.3, x64)
  • xstateTSServer - node (v12.1.0, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 50071 10
Baseline main 10

Developer Information:

Download Benchmark

@rbuckton rbuckton mentioned this pull request Jul 27, 2022
Merged
@rbuckton
Copy link
Member Author

#50074 seems like the better performing approach, so I will use that implementation instead.

@rbuckton rbuckton closed this Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rbuckton @typescript-bot