Exclude mapped types with optionality modifiers and 'as' clauses from constraint logic #48273

ahejlsberg · 2022-03-15T14:18:00Z

ahejlsberg · 2022-03-15T14:19:45Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster

typescript-bot · 2022-03-15T14:20:52Z

Heya @ahejlsberg, I've started to run the diff-based community code test suite on this PR at 05560c1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-03-15T14:20:52Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 05560c1. You can monitor the build here.

typescript-bot · 2022-03-15T14:20:52Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 05560c1. You can monitor the build here.

typescript-bot · 2022-03-15T14:20:52Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 05560c1. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-03-15T14:36:13Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..48273

_Metric	_main	₄₈₂₇₃	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{332,456k (± 0.01%)}	_{332,428k (± 0.01%)}	_{-28k (- 0.01%)}	_332,373k	_332,479k
_{Parse Time}	_{2.03s (± 0.43%)}	_{2.03s (± 0.52%)}	_{-0.01s (- 0.34%)}	_2.01s	_2.05s
_{Bind Time}	_{0.87s (± 0.80%)}	_{0.87s (± 0.60%)}	_{-0.00s (- 0.23%)}	_0.86s	_0.88s
_{Check Time}	_{5.60s (± 0.41%)}	_{5.61s (± 0.56%)}	_{+0.01s (+ 0.13%)}	_5.55s	_5.68s
_{Emit Time}	_{6.30s (± 0.73%)}	_{6.27s (± 0.81%)}	_{-0.03s (- 0.52%)}	_6.16s	_6.40s
_{Total Time}	_{14.81s (± 0.46%)}	_{14.77s (± 0.54%)}	_{-0.04s (- 0.24%)}	_14.64s	_15.00s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{194,479k (± 0.49%)}	_{194,035k (± 0.60%)}	_{-444k (- 0.23%)}	_191,247k	_195,221k
_{Parse Time}	_{0.86s (± 0.80%)}	_{0.86s (± 0.78%)}	_{+0.00s (+ 0.12%)}	_0.85s	_0.88s
_{Bind Time}	_{0.56s (± 0.99%)}	_{0.56s (± 1.15%)}	_{0.00s ( 0.00%)}	_0.55s	_0.58s
_{Check Time}	_{7.48s (± 0.51%)}	_{7.44s (± 0.68%)}	_{-0.05s (- 0.63%)}	_7.34s	_7.59s
_{Emit Time}	_{2.49s (± 0.99%)}	_{2.51s (± 1.31%)}	_{+0.01s (+ 0.44%)}	_2.45s	_2.61s
_{Total Time}	_{11.39s (± 0.57%)}	_{11.36s (± 0.61%)}	_{-0.03s (- 0.29%)}	_11.23s	_11.53s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{325,416k (± 0.01%)}	_{325,397k (± 0.01%)}	_{-18k (- 0.01%)}	_325,353k	_325,430k
_{Parse Time}	_{1.58s (± 0.48%)}	_{1.56s (± 0.48%)}	_{-0.01s (- 0.70%)}	_1.55s	_1.59s
_{Bind Time}	_{0.78s (± 0.63%)}	_{0.78s (± 1.33%)}	_{+0.01s (+ 0.77%)}	_0.76s	_0.81s
_{Check Time}	_{5.48s (± 0.37%)}	_{5.46s (± 0.47%)}	_{-0.02s (- 0.38%)}	_5.41s	_5.55s
_{Emit Time}	_{3.31s (± 0.88%)}	_{3.30s (± 0.75%)}	_{-0.00s (- 0.15%)}	_3.26s	_3.39s
_{Total Time}	_{11.14s (± 0.35%)}	_{11.11s (± 0.21%)}	_{-0.03s (- 0.28%)}	_11.07s	_11.18s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{288,830k (± 0.01%)}	_{288,825k (± 0.01%)}	_{-5k (- 0.00%)}	_288,758k	_288,886k
_{Parse Time}	_{1.32s (± 1.65%)}	_{1.31s (± 0.78%)}	_{-0.01s (- 0.68%)}	_1.29s	_1.33s
_{Bind Time}	_{0.73s (± 0.99%)}	_{0.73s (± 0.71%)}	_{-0.00s (- 0.41%)}	_0.72s	_0.74s
_{Check Time}	_{5.13s (± 0.38%)}	_{5.14s (± 0.63%)}	_{+0.01s (+ 0.23%)}	_5.06s	_5.21s
_{Emit Time}	_{3.56s (± 1.91%)}	_{3.46s (± 1.56%)}	_{-0.10s (- 2.78%)}	_3.38s	_3.60s
_{Total Time}	_{10.74s (± 0.80%)}	_{10.64s (± 0.43%)}	_{-0.10s (- 0.88%)}	_10.52s	_10.73s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{453,572k (± 0.06%)}	_{453,653k (± 0.03%)}	_{+82k (+ 0.02%)}	_453,114k	_453,735k
_{Parse Time}	_{1.86s (± 0.42%)}	_{1.86s (± 0.80%)}	_{-0.00s (- 0.16%)}	_1.84s	_1.91s
_{Bind Time}	_{0.71s (± 0.81%)}	_{0.70s (± 1.00%)}	_{-0.01s (- 1.68%)}	_0.69s	_0.72s
_{Check Time}	_{20.80s (± 1.19%)}	_{20.45s (± 1.14%)}	_{-0.35s (- 1.69%)}	_20.10s	_21.07s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{23.37s (± 1.06%)}	_{23.01s (± 1.08%)}	_{-0.36s (- 1.56%)}	_22.64s	_23.70s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{535,139k (± 0.01%)}	_{535,120k (± 0.00%)}	_{-20k (- 0.00%)}	_535,073k	_535,165k
_{Parse Time}	_{2.57s (± 0.47%)}	_{2.56s (± 0.33%)}	_{-0.00s (- 0.19%)}	_2.55s	_2.58s
_{Bind Time}	_{1.15s (± 0.41%)}	_{1.14s (± 0.77%)}	_{-0.00s (- 0.35%)}	_1.13s	_1.16s
_{Check Time}	_{1.51s (± 0.61%)}	_{1.50s (± 0.74%)}	_{-0.01s (- 0.46%)}	_1.49s	_1.54s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.30s (± 0.31%)}	_{5.28s (± 0.24%)}	_{-0.02s (- 0.30%)}	_5.26s	_5.32s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{4 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₈₂₇₃	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

typescript-bot · 2022-03-15T14:38:19Z

@ahejlsberg
Great news! no new errors were found between main..refs/pull/48273/merge

RyanCavanaugh · 2022-03-15T16:03:14Z

src/compiler/checker.ts

-            return type.flags & TypeFlags.IndexedAccess && getObjectFlags((type as IndexedAccessType).objectType) & ObjectFlags.Mapped &&
-                !isGenericMappedType((type as IndexedAccessType).objectType) && isGenericIndexType((type as IndexedAccessType).indexType);
+            let objectType;
+            return !!(type.flags & TypeFlags.IndexedAccess && getObjectFlags(objectType = (type as IndexedAccessType).objectType) & ObjectFlags.Mapped &&


Seems like this would be improved by De Morgan's law

# Conflicts: # src/compiler/checker.ts

ahejlsberg added 2 commits March 15, 2022 07:00

Exclude mapped types with optionality modifiers and 'as' clauses

1d08203

Add regression tests

05560c1

ahejlsberg requested a review from RyanCavanaugh March 15, 2022 14:18

typescript-bot assigned ahejlsberg Mar 15, 2022

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Mar 15, 2022

RyanCavanaugh reviewed Mar 15, 2022

View reviewed changes

RyanCavanaugh approved these changes Mar 15, 2022

View reviewed changes

Merge branch 'main' into fix48157

25882af

# Conflicts: # src/compiler/checker.ts

ahejlsberg merged commit 8e5a84a into main Mar 16, 2022

ahejlsberg deleted the fix48157 branch March 16, 2022 00:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude mapped types with optionality modifiers and 'as' clauses from constraint logic #48273

Exclude mapped types with optionality modifiers and 'as' clauses from constraint logic #48273

ahejlsberg commented Mar 15, 2022

ahejlsberg commented Mar 15, 2022

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022

typescript-bot commented Mar 15, 2022

RyanCavanaugh Mar 15, 2022

Exclude mapped types with optionality modifiers and 'as' clauses from constraint logic #48273

Exclude mapped types with optionality modifiers and 'as' clauses from constraint logic #48273

Conversation

ahejlsberg commented Mar 15, 2022

ahejlsberg commented Mar 15, 2022

typescript-bot commented Mar 15, 2022 • edited

typescript-bot commented Mar 15, 2022 • edited

typescript-bot commented Mar 15, 2022 • edited

typescript-bot commented Mar 15, 2022 • edited

typescript-bot commented Mar 15, 2022

typescript-bot commented Mar 15, 2022

RyanCavanaugh Mar 15, 2022

Choose a reason for hiding this comment

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited

typescript-bot commented Mar 15, 2022 •

edited