Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only suggest @param codefixes in TS #47959

Merged
merged 4 commits into from Feb 18, 2022
Merged

Only suggest @param codefixes in TS #47959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
465042e
Only issue @param suggestions with codefixes in TS
sandersn Feb 18, 2022
4056b38
Minimise test
sandersn Feb 18, 2022
4fb10f1
Merge branch 'main' into only-suggest-param-codefixes-in-ts
sandersn Feb 18, 2022
72499ac
Merge branch 'main' into only-suggest-param-codefixes-in-ts
sandersn Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/compiler/checker.ts
View file
Open in desktop
Expand Up @@ -38650,9 +38650,9 @@ namespace ts {
const containsArguments = containsArgumentsReference(node);
if (containsArguments) {
const lastJSDocParam = lastOrUndefined(jsdocParameters);
if (lastJSDocParam && isIdentifier(lastJSDocParam.name) && lastJSDocParam.typeExpression &&
if (isJs && lastJSDocParam && isIdentifier(lastJSDocParam.name) && lastJSDocParam.typeExpression &&
lastJSDocParam.typeExpression.type && !parameters.has(lastJSDocParam.name.escapedText) && !isArrayType(getTypeFromTypeNode(lastJSDocParam.typeExpression.type))) {
errorOrSuggestion(isJs, lastJSDocParam.name, Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name_It_would_match_arguments_if_it_had_an_array_type, idText(lastJSDocParam.name));
error(lastJSDocParam.name, Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name_It_would_match_arguments_if_it_had_an_array_type, idText(lastJSDocParam.name));
}
}
else {
Expand All @@ -38661,7 +38661,9 @@ namespace ts {
return;
}
if (isQualifiedName(name)) {
errorOrSuggestion(isJs, name, Diagnostics.Qualified_name_0_is_not_allowed_without_a_leading_param_object_1, entityNameToString(name), entityNameToString(name.left));
if (isJs) {
error(name, Diagnostics.Qualified_name_0_is_not_allowed_without_a_leading_param_object_1, entityNameToString(name), entityNameToString(name.left));
}
}
else {
errorOrSuggestion(isJs, name, Diagnostics.JSDoc_param_tag_has_name_0_but_there_is_no_parameter_with_that_name, idText(name));
Expand Down
18 changes: 18 additions & 0 deletions tests/cases/fourslash/jsdocParam_suggestion1.ts
View file
Open in desktop
@@ -0,0 +1,18 @@
/// <reference path="fourslash.ts" />
// @Filename: a.ts
//// /**
//// * @param options - whatever
//// * @param options.zone - equally bad
//// */
//// declare function bad(options: any): void
////
//// /**
//// * @param {number} obtuse
//// */
//// function worse(): void {
//// arguments
//// }

goTo.file('a.ts')
verify.getSuggestionDiagnostics([]);