Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash for import code fixes with dotted require #47433

Merged
merged 6 commits into from Jan 19, 2022
Merged

Avoid crash for import code fixes with dotted require #47433

merged 6 commits into from Jan 19, 2022

Commits on Jan 13, 2022

  1. Add failing test.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 13, 2022
    Copy the full SHA
    fce282b View commit details
    Browse the repository at this point in the history

  2. Update failing test.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 13, 2022
    Copy the full SHA
    ea2c290 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Finalized failing test case.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 14, 2022
    Copy the full SHA
    d954948 View commit details
    Browse the repository at this point in the history

  2. Separate our usages of utilities that expect variables initialized to… 

    … require(...) and require(...).foo.
    @DanielRosenwasser
    DanielRosenwasser committed Jan 14, 2022
    Copy the full SHA
    f476e84 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2022

  1. Renamed types and utilities, removed accidental indentation.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 19, 2022
    Copy the full SHA
    9f0810c View commit details
    Browse the repository at this point in the history

  2. Renamed both utilitiy functions uniformly.

    @DanielRosenwasser
    DanielRosenwasser committed Jan 19, 2022
    Copy the full SHA
    bf708bf View commit details
    Browse the repository at this point in the history