Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for undefined globalObjectType in getPropertyOfObjectType #47183

Closed
wants to merge 2 commits into from
Closed

Check for undefined globalObjectType in getPropertyOfObjectType #47183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9256e11
Check for undefined globalObjectType in getPropertyOfObjectType
sandersn Dec 17, 2021
c71e781
Add comment, switch to &&.
DanielRosenwasser Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Expand Up @@ -12360,7 +12360,9 @@ namespace ts {
return symbol;
}
}
return getPropertyOfObjectType(globalObjectType, name);
// TODO: In some cases, the containing function may be called before global types have been initialized.
// This simple guard avoids issues with those cases, but in the future we may need to reconsider how these steps are ordered.
return globalObjectType && getPropertyOfObjectType(globalObjectType, name);
}
if (type.flags & TypeFlags.UnionOrIntersection) {
return getPropertyOfUnionOrIntersectionType(type as UnionOrIntersectionType, name, skipObjectFunctionPropertyAugment);
Expand Down