Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 44422 #44430

Closed
wants to merge 1 commit into from
Closed

fix 44422 #44430

wants to merge 1 commit into from

Conversation

ShuiRuTian
Copy link
Contributor

Fixes #44422

@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jun 4, 2021
@ShuiRuTian
Copy link
Contributor Author

But Where should we add the test? Could we add the test now?

@sandersn
Copy link
Member

Oops, sorry I didn't see this. I ended up fixing this separately in #44443. The test is very tricky -- since it's a problem with the API, and wouldn't show up in our baselines, I created a unit test in src/testRunner/unittests/publicApi.ts

@ShuiRuTian ShuiRuTian closed this Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts.Node.getChildren() returns duplicate copies of the same AST nodes in TS 4.3
3 participants
@ShuiRuTian @sandersn @typescript-bot