Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only issue matching token errors on non-dupe locations #43460

Merged
merged 4 commits into from Mar 31, 2021
Merged

Only issue matching token errors on non-dupe locations #43460

merged 4 commits into from Mar 31, 2021

Commits on Mar 31, 2021

  1. Only issue matching token errors on non-dupe locations 

    Intead of unconditionally retrieving the last error and attaching a
related span, `parseErrorAt` and friends now return the last error and
return `false` when there is none.

Also make one more place use parseExpectedMatchingBrackets that I missed
last time.
    @sandersn
    sandersn committed Mar 31, 2021
    Copy the full SHA
    c141447 View commit details
    Browse the repository at this point in the history

  2. Inline parseTokenForError, return undefined not false

    @sandersn
    sandersn committed Mar 31, 2021
    Copy the full SHA
    723616f View commit details
    Browse the repository at this point in the history

  3. skip redundant undefined assignment

    @sandersn
    sandersn committed Mar 31, 2021
    Copy the full SHA
    435c99d View commit details
    Browse the repository at this point in the history

  4. address PR comments

    @sandersn
    sandersn committed Mar 31, 2021
    Copy the full SHA
    ed04130 View commit details
    Browse the repository at this point in the history