Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inherit jsdoc tags from overloaded signatures (#43165) #43180

Merged
merged 2 commits into from Mar 24, 2021

Commits on Mar 10, 2021

  1. Don't inherit jsdoc tags from overloaded signatures (microsoft#43165)

    Previously, when getting jsdoc for signatures, the services layer would
    get the jsdoc tags for the base symbol of a signature if it was
    present. This is fine except when the base was overloaded. In that case,
    the multiple signatures of the overload would all contribute jsdoc,
    which is not correct.
    
    A more correct fix would be to resolve overloads to the base, but
    the compiler doesn't have this capability and adding it or jury-rigging
    it seems like it would be complex, inappropriate for a fix to ship in a
    patch version.
    
    Co-authored-by: Orta Therox <git@orta.io>
    
    Co-authored-by: Orta Therox <git@orta.io>
    sandersn and orta committed Mar 10, 2021
    Copy the full SHA
    5a98be3 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Update baseline

    orta committed Mar 11, 2021
    Copy the full SHA
    dd897f9 View commit details
    Browse the repository at this point in the history