Adjust scanning of keywordy jsx namespace names, add grammar error for jsx dotted names containing namespace names #43104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r jsx dotted names containing namespace names
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
approved these changes
Mar 19, 2021
src/compiler/checker.ts
Outdated
| } | ||
| } | ||
|
|
||
| function checkGrammarJsxNestedIdentifier(name: MemberName | ThisExpression) { |
There was a problem hiding this comment.
This doesn't have a strong reason to be nested, I think.
There was a problem hiding this comment.
Mostly just to avoid pollution in the containing scope, since it's only needed here. Since it doesn't close over anything, it should be just as effective as a function in the surrounding scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42963
The JSX spec doesn't visibly forbid namespace names where a component of the namespace is a keyword, so those are adjusted to parse as
Identifiers (so they then typecheck), and I've also added a grammar error ona:b.cand the like.