Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specific diagnostic suggestions for unexpected keyword or identifier #43005
Specific diagnostic suggestions for unexpected keyword or identifier #43005
Changes from 22 commits
0c967f9
107e10d
12088e9
73a9852
cc70a1b
23e0acb
5cf8606
05e8d0f
f547914
972da93
c554519
5a0804b
182f75a
dabe89a
6d40a4c
7e49aa6
a052314
8e9e46d
dd47c39
ad6f591
cd4d28d
b878e74
b16d5eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only report an error here if there's no preceding line terminator. This is valid JS:
ASI inserts a
;
betweena
andb
, and betweenb
andc()
. I would expect the same to be true for decorators:This should be legal since ASI would insert a
;
betweena
and@dec
, however now it is an error.