Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃 Pick PR #42766 (Avoid getting undefined `callSignat...) into release-4.2 #42950

Merged
merged 1 commit into from Feb 25, 2021
Merged

馃 Pick PR #42766 (Avoid getting undefined `callSignat...) into release-4.2 #42950

merged 1 commit into from Feb 25, 2021

Commits on Feb 25, 2021

  1. Cherry-pick PR microsoft#42766 into release-4.2 

    Component commits:
ed26816 Avoid getting undefined `callSignatures`/`constructSignatures` in `getPropertyOfType`
e350c35 (microsoft#40228) introduced a subtle bug: it switched the flags to an
alias, dropping `SymbolFlags.Property` --- and that makes
`symbolIsValue()` get to the `resolveAlias(symbol)` call, which leads to
`getPropertyOfType()` with`resolved.callSignatures`+`constructSignatures`
being `undefined`.  So initialize them in `setStructuredTypeMembers`
before calling `getNamedMembers()`.

Fixes microsoft#42350
    @elibarzilay
    elibarzilay authored and typescript-bot committed Feb 25, 2021
    Copy the full SHA
    0fe88c9 View commit details
    Browse the repository at this point in the history