Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Pick PR #42779 (No did-you-mean-to-call error on ca...) into release-4.2 #42820

Merged

Commits on Feb 16, 2021

  1. Cherry-pick PR microsoft#42779 into release-4.2

    Component commits:
    214ef0c No did-you-mean-to-call error on casts
    I chose to do the ad-hoc check rather than yet another tree walk.
    
    1. It's faster to run and easier to read.
    2. This error came from looking at real code. It happened twice, so I
    think the best estimate for other uses that happened zero times is in
    fact zero.
    3. I couldn't think of other places to put the cast, given the
    restrictions on `testedNode` just before the new code.
    
    1d34778 Merge branch 'master' into no-did-you-mean-to-call-error-on-casts
    
    b3be79a Skip parentheses
    
    2a28812 Merge branch 'master' into no-did-you-mean-to-call-error-on-casts
    sandersn authored and typescript-bot committed Feb 16, 2021
    Copy the full SHA
    122cb0a View commit details
    Browse the repository at this point in the history