Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No did-you-mean-to-call error on casts Part 2 #42779

Merged
merged 4 commits into from Feb 12, 2021

Commits on Feb 3, 2021

  1. No did-you-mean-to-call error on casts

    I chose to do the ad-hoc check rather than yet another tree walk.
    
    1. It's faster to run and easier to read.
    2. This error came from looking at real code. It happened twice, so I
    think the best estimate for other uses that happened zero times is in
    fact zero.
    3. I couldn't think of other places to put the cast, given the
    restrictions on `testedNode` just before the new code.
    sandersn committed Feb 3, 2021
    Copy the full SHA
    214ef0c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Copy the full SHA
    1d34778 View commit details
    Browse the repository at this point in the history
  2. Skip parentheses

    sandersn committed Feb 12, 2021
    Copy the full SHA
    b3be79a View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2a28812 View commit details
    Browse the repository at this point in the history