Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid getting undefined callSignatures/constructSignatures in getPropertyOfType #42766

Merged
merged 1 commit into from Feb 11, 2021

Commits on Feb 11, 2021

  1. Avoid getting undefined callSignatures/constructSignatures in `ge…

    …tPropertyOfType`
    
    e350c35 (microsoft#40228) introduced a subtle bug: it switched the flags to an
    alias, dropping `SymbolFlags.Property` --- and that makes
    `symbolIsValue()` get to the `resolveAlias(symbol)` call, which leads to
    `getPropertyOfType()` with`resolved.callSignatures`+`constructSignatures`
    being `undefined`.  So initialize them in `setStructuredTypeMembers`
    before calling `getNamedMembers()`.
    
    Fixes microsoft#42350
    elibarzilay committed Feb 11, 2021
    Copy the full SHA
    ed26816 View commit details
    Browse the repository at this point in the history