Handle output file names descripency between tsc --b and actual program emit file path calculation #41811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
andrewbranch
and removed request for
sandersn
typescript-bot
added
the
For Uncommitted Bug
…rootDir, the paths should be calculated from rootDir
sheetalkamat
force-pushed
the
outputFileNames
branch
from
b3d20a1
to
555acd6
Compare
andrewbranch
approved these changes
Dec 7, 2020
benmccann
reviewed
Dec 7, 2020
|
Thank you so much for the fix!! Any idea whether it might be in 4.1.3 or not until 4.2.0? |
|
We would probably want to wait for 4.2 as it is not minor fix and not patch it to 4.1 |
scalder27
pushed a commit
to scalder27/TypeScript
that referenced
this pull request
Dec 7, 2020
…am emit file path calculation (microsoft#41811) * Baseline showing microsoft#41801 and other issues with output path calculation * Add a way to note descripencies between clean and incremental build * Add descripency when no rootDir is specified but project is composite * if rootDir is specified, irrespective of whether all files belong to rootDir, the paths should be calculated from rootDir * Fix the output file names api to use the correct common source directory * Tests for microsoft#41780 * Spelling
9 tasks
|
@sheetalkamat I don't see this in the 4.2.0 or 4.2.1 list of issues for those milestones. Can you confirm it made it into either release? |
|
Yes, I believe this is working in TypeScript 4.2 now. It appears there was a new issue introduced directly in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tsc -bthat usesgetOutputFileNamesapiFixes tsc --build takes wrong assumption on project rootDir #41801 and getOutputFileNames is returning incorrect path #41780