transformGenerators: handle CommaListExpression
#41079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
rbuckton
requested changes
Oct 13, 2020
Uses essentially the same code as `visitCommaExpression` (which was
moved, to keep both together and close to
`visit{Right,Left}AssociativeBinaryExpression`).
Fixes microsoft#40614.
rbuckton
approved these changes
Oct 14, 2020
|
@typescript-bot cherry-pick this to release-4.0 |
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
|
Hey @DanielRosenwasser, I've opened #41193 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Oct 22, 2020
Component commits: 6fa32ba `transformGenerators`: handle `CommaListExpression` Uses essentially the same code as `visitCommaExpression` (which was moved, to keep both together and close to `visit{Right,Left}AssociativeBinaryExpression`). Fixes microsoft#40614.
DanielRosenwasser
added a commit
that referenced
this pull request
Oct 22, 2020
* Cherry-pick PR #41079 into release-4.0 Component commits: 6fa32ba `transformGenerators`: handle `CommaListExpression` Uses essentially the same code as `visitCommaExpression` (which was moved, to keep both together and close to `visit{Right,Left}AssociativeBinaryExpression`). Fixes #40614. * Accepted baselines. Co-authored-by: Eli Barzilay <eli@barzilay.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses essentially the same code as
visitCommaExpression(which wasmoved, to keep both together and close to
visit{Right,Left}AssociativeBinaryExpression).Fixes #40614.