Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on aliased, exported @enum tag in jsdoc #36996

Merged
merged 1 commit into from
Feb 25, 2020

Commits on Feb 24, 2020

  1. Fix crash on aliased,exported @enum tag in jsdoc

    THe code to bind `@enum` and `@typedef` didn't handle the case that the
    `@enum` was on a property assignment to an alias of module.exports.
    Specifically, `x` needs to be correctly aliased to the file's symbol in
    the example below:
    
    ```
    var x = module.exports = {};
    /** @enum {string} */
    x.E = {
      A: "A"
    };
    ```
    sandersn committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    888ebf4 View commit details
    Browse the repository at this point in the history