Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle getScriptVersion correctly to ensure program structure is checked correctly #36808

Merged
merged 6 commits into from
Feb 26, 2020

Conversation

sheetalkamat
Copy link
Member

Fixes #36748

This means earlier we were creating fresh program everytime we did LS operation
Now we reuse same program, so quick info depends on order of quickinfo demands
…valuated before finding references, it cant find all definitions from the merge
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough context to understand this change. From the bug, it sounds like the fix applies to language service API users. Does it affect our usage of the language service too?

src/server/editorServices.ts Outdated Show resolved Hide resolved
src/server/editorServices.ts Show resolved Hide resolved
src/server/project.ts Outdated Show resolved Hide resolved
src/server/scriptInfo.ts Show resolved Hide resolved
sheetalkamat and others added 2 commits February 24, 2020 12:42
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@sheetalkamat
Copy link
Member Author

@sandersn have resolved all the comments.. Please take a look.. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isProgramUpToDate reports false because it expects HostCache to include typescript/lib/*.d.ts files
3 participants