Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Cherry-pick PR #35058 into release-3.7 #35241

Merged

Commits on Nov 20, 2019

  1. Cherry-pick PR microsoft#35058 into release-3.7

    Component commits:
    8ae5a8c useDefineForClassFields skips emit of ambient properties
    Previously:
    
    ```ts
    class C {
      declare p
    }
    ```
    
    would incorrectly emit
    
    ```js
    class C {
        constructor() {
            Object.defineProperty(this, "p", {
                enumerable: true,
                configurable: true,
                writable: true,
                value: void 0
            });
        }
    }
    ```
    
    when useDefineForClassFields was turned on (for targets <ESNext).
    
    0ec9c04 Fix bug for ESNext as well
    This moves the check earlier in the pipeline.
    
    e1aa034 update baselines
    sandersn authored and typescript-bot committed Nov 20, 2019
    Copy the full SHA
    0f48bec View commit details
    Browse the repository at this point in the history