馃 User test baselines have changed for refs/heads/master #34759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20190901-refs/heads/master
branch
5 times, most recently
from
fccdf81
to
f2f6661
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20190901-refs/heads/master
branch
from
f2f6661
to
3c86221
Compare
sandersn
requested changes
Oct 29, 2019
| @@ -23,6 +23,7 @@ node_modules/@glimmer/util/dist/types/lib/destroy.d.ts(3,69): error TS2677: A ty | |||
| Index signature is missing in type 'SymbolDestroyable'. | |||
| node_modules/@glimmer/util/dist/types/lib/dom.d.ts(1,31): error TS2307: Cannot find module '@simple-dom/interface'. | |||
| node_modules/@glimmer/util/dist/types/lib/is-serialization-first-node.d.ts(1,28): error TS2307: Cannot find module '@simple-dom/interface'. | |||
| node_modules/@typescript-eslint/typescript-estree/dist/create-program/createWatchProgram.d.ts(1,8): error TS1259: Module '"/prettier/prettier/node_modules/typescript/lib/typescript"' can only be default-imported using the 'esModuleInterop' flag | |||
There was a problem hiding this comment.
this is a problem new to typescript-estree
There was a problem hiding this comment.
Filed typescript-eslint/typescript-eslint#1153 to track this
| @@ -36,6 +37,8 @@ src/cli/util.js(693,22): error TS2339: Property 'name' does not exist on type 'n | |||
| src/cli/util.js(693,46): error TS2339: Property 'alias' does not exist on type 'never'. | |||
| src/common/create-ignorer.js(34,19): error TS2349: This expression is not callable. | |||
| Type 'typeof import("/prettier/prettier/node_modules/ignore/index")' has no call signatures. | |||
| src/common/get-file-info.js(36,27): error TS2339: Property 'resolveConfig' does not exist on type '{ ignorePath?: string | undefined; withNodeModules?: boolean | undefined; plugins: any; }'. | |||
| Property 'additionalProperty' does not exist on type 'RefParams'. | ||
| lib/validateSchema.js(51,31): error TS2339: Property 'additionalProperty' does not exist on type 'ErrorParameters'. | ||
| Property 'additionalProperty' does not exist on type 'RefParams'. | ||
| lib/MultiCompiler.js(15,65): error TS2300: Duplicate identifier 'AsyncSeriesHook'. |
There was a problem hiding this comment.
This seems bad. Everything looks correct and checks correctly except there is a duplicate identifier error on all the typedefs.
Fortunately it's not in 3.7.
| lib/logging/Logger.js(103,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "info" | "warn" | "log" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/logging/Logger.js(117,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "info" | "warn" | "log" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/logging/Logger.js(127,20): error TS2345: Argument of type 'string' is not assignable to parameter of type '"error" | "time" | "group" | "debug" | "info" | "warn" | "log" | "trace" | "groupCollapsed" | "groupEnd" | "profile" | "profileEnd" | "clear" | "status"'. | ||
| lib/util/registerExternalSerializer.js(218,14): error TS2339: Property 'start' does not exist on type 'typeof SourceLocation'. |
There was a problem hiding this comment.
uh oh. This looks like another case where the type reference is getting the static side of the class incorrectly.
First appeared in #34503, 15/10 15:38 PDT, new since 14/10 9:24 PDT. On both master and 3.7.
| @@ -269,10 +269,16 @@ node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(751, | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(778,24): error TS2694: Namespace 'Protocol' has no exported member 'Page'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(811,11): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(7,11): error TS2339: Property 'AnimationScreenshotPopover' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | |||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationScreenshotPopover.js(18,39): error TS2345: Argument of type 'new (width?: number, height?: number) => HTMLImageElement' is not assignable to parameter of type 'Node'. | |||
There was a problem hiding this comment.
should be type HTMLImageElement not new () => HTMLImageElement. Another incorrectly resolved type reference.
Same as the webpack error:
First appeared in #34503, 15/10 15:38 PDT, new since 14/10 9:24 PDT. On both master and 3.7.
There was a problem hiding this comment.
#34803 tracks this, although it might be the same as the webpack issue.
| @@ -9613,8 +9619,6 @@ node_modules/chrome-devtools-frontend/front_end/sdk/RemoteObject.js(704,32): err | |||
| node_modules/chrome-devtools-frontend/front_end/sdk/RemoteObject.js(727,14): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | |||
| node_modules/chrome-devtools-frontend/front_end/sdk/RemoteObject.js(728,32): error TS2694: Namespace 'Protocol' has no exported member 'Runtime'. | |||
| node_modules/chrome-devtools-frontend/front_end/sdk/RemoteObject.js(729,14): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | |||
| node_modules/chrome-devtools-frontend/front_end/sdk/RemoteObject.js(731,3): error TS2416: Property 'callFunctionJSON' in type 'RemoteObjectImpl' is not assignable to the same property in base type 'RemoteObject'. | |||
There was a problem hiding this comment.
removed duplicated error. good, but ... I'm not sure why it happened.
| @@ -11958,7 +11960,6 @@ node_modules/chrome-devtools-frontend/front_end/ui/Geometry.js(272,13): error TS | |||
| node_modules/chrome-devtools-frontend/front_end/ui/Geometry.js(316,13): error TS2304: Cannot find name 'CSSMatrix'. | |||
| node_modules/chrome-devtools-frontend/front_end/ui/GlassPane.js(18,17): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | |||
| node_modules/chrome-devtools-frontend/front_end/ui/GlassPane.js(72,15): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | |||
| node_modules/chrome-devtools-frontend/front_end/ui/GlassPane.js(82,5): error TS2739: Type 'Size' is missing the following properties from type 'Size': isEqual, widthToMax, addWidth, heightToMax, addHeight | |||
sandersn
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript