Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add browser field entries for all require calls in sys.ts #33242

Merged
merged 1 commit into from Sep 4, 2019
Merged

Add browser field entries for all require calls in sys.ts #33242

merged 1 commit into from Sep 4, 2019

Conversation

weswigham
Copy link
Member

@weswigham
Copy link
Member Author

cc @andrewbranch who also seems to show interest in our packability

@andrewbranch
Copy link
Member

Submodules changed 😖

@uniqueiniquity
Copy link
Contributor

Looks good, though where is this documented? Having trouble finding it.

@AviVahl
Copy link

AviVahl commented Sep 4, 2019

@uniqueiniquity https://github.com/defunctzombie/package-browser-field-spec via https://webpack.js.org/configuration/resolve/#resolvealiasfields

@weswigham weswigham merged commit 2b153fc into microsoft:master Sep 4, 2019
@weswigham weswigham deleted the more-browser-field-entries branch September 4, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueiniquity uniqueiniquity uniqueiniquity approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@sheetalkamat sheetalkamat Awaiting requested review from sheetalkamat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weswigham @andrewbranch @uniqueiniquity @AviVahl