Apply 'no-unnecessary-type-assertion' lint rule #22005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of type assertions have become unnecesary as we added stricter node types. This lint rule prevents us from writing
x as T
if the type ofx
is already assignable toT
.Required changing
no-unnecessary-type-assertion
to ignorex!
since we don't have--strictNullChecks
yet -- made a pull request upstream at palantir/tslint#3724.Also switches us to using the
--project
tslint option. This increases lint time from about 13 to 19.5 seconds.