Revert "Bind typedef/enum on all assignment decl kinds (#33240)"

This reverts commit b542bdf.
microsoft · Sep 5, 2019 · e50e01f · e50e01f
1 parent b3ec4ed
commit e50e01f
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 84 deletions.
diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts
@@ -1827,23 +1827,7 @@ namespace ts {
                         bindPotentiallyMissingNamespaces(file.symbol, declName.parent, isTopLevel,
                             !!findAncestor(declName, d => isPropertyAccessExpression(d) && d.name.escapedText === "prototype"), /*containerIsClass*/ false);
                         const oldContainer = container;
-                        switch (getAssignmentDeclarationPropertyAccessKind(declName.parent)) {
-                            case AssignmentDeclarationKind.ExportsProperty:
-                            case AssignmentDeclarationKind.ModuleExports:
-                                container = file;
-                                break;
-                            case AssignmentDeclarationKind.ThisProperty:
-                                container = declName.parent.expression;
-                                break;
-                            case AssignmentDeclarationKind.PrototypeProperty:
-                                container = (declName.parent.expression as PropertyAccessExpression).name;
-                                break;
-                            case AssignmentDeclarationKind.Property:
-                                container = isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name : declName.parent.expression;
-                                break;
-                            case AssignmentDeclarationKind.None:
-                                return Debug.fail("Shouldn't have detected typedef or enum on non-assignment declaration");
-                        }
+                        container = isPropertyAccessExpression(declName.parent.expression) ? declName.parent.expression.name : declName.parent.expression;
                         declareModuleMember(typeAlias, SymbolFlags.TypeAlias, SymbolFlags.TypeAliasExcludes);
                         container = oldContainer;
                     }

diff --git a/tests/baselines/reference/enumTagOnExports.symbols b/tests/baselines/reference/enumTagOnExports.symbols
diff --git a/tests/baselines/reference/enumTagOnExports.types b/tests/baselines/reference/enumTagOnExports.types
diff --git a/tests/baselines/reference/enumTagOnExports2.symbols b/tests/baselines/reference/enumTagOnExports2.symbols
diff --git a/tests/baselines/reference/enumTagOnExports2.types b/tests/baselines/reference/enumTagOnExports2.types
diff --git a/tests/cases/conformance/jsdoc/enumTagOnExports.ts b/tests/cases/conformance/jsdoc/enumTagOnExports.ts
diff --git a/tests/cases/conformance/jsdoc/enumTagOnExports2.ts b/tests/cases/conformance/jsdoc/enumTagOnExports2.ts