fix(57445): No inlay hints for property declaration types inferred fr…

…om constructor (#57494) Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
microsoft · Mar 12, 2024 · 884d649 · 884d649
1 parent 47a800f
commit 884d649
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/services/inlayHints.ts b/src/services/inlayHints.ts
@@ -118,6 +118,7 @@ import {
     tokenToString,
     TupleTypeReference,
     Type,
+    TypeFlags,
     unescapeLeadingUnderscores,
     UserPreferences,
     usingSingleLineStringWriter,
@@ -260,7 +261,10 @@ export function provideInlayHints(context: InlayHintsContext): InlayHint[] {
     }
 
     function visitVariableLikeDeclaration(decl: VariableDeclaration | PropertyDeclaration) {
-        if (!decl.initializer || isBindingPattern(decl.name) || isVariableDeclaration(decl) && !isHintableDeclaration(decl)) {
+        if (
+            decl.initializer === undefined && !(isPropertyDeclaration(decl) && !(checker.getTypeAtLocation(decl).flags & TypeFlags.Any)) ||
+            isBindingPattern(decl.name) || (isVariableDeclaration(decl) && !isHintableDeclaration(decl))
+        ) {
             return;
         }
 

diff --git a/tests/baselines/reference/inlayHintsPropertyDeclarations.baseline b/tests/baselines/reference/inlayHintsPropertyDeclarations.baseline
@@ -6,4 +6,13 @@
   "position": 15,
   "kind": "Type",
   "whitespaceBefore": true
+}
+
+    d;
+     ^
+{
+  "text": ": number | null",
+  "position": 50,
+  "kind": "Type",
+  "whitespaceBefore": true
 }
diff --git a/tests/cases/fourslash/inlayHintsPropertyDeclarations.ts b/tests/cases/fourslash/inlayHintsPropertyDeclarations.ts
@@ -1,9 +1,18 @@
 /// <reference path="fourslash.ts" />
 
+// @strict: true
 //// class C {
 ////     a = 1
 ////     b: number = 2
 ////     c;
+////     d;
+////
+////     constructor(value: number) {
+////         this.d = value;
+////         if (value <= 0) {
+////             this.d = null;
+////         }
+////     }
 //// }
 
 verify.baselineInlayHints(undefined, {